[PR #1302] [MERGED] fix(contracts): advertise NUL as the hex escape strict validators accept #2782

New issue

Closed

opened 2026-10-17 21:10:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1302
Author: @Yi-111-a
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/advertise-portable-nul-escape

📝 Commits (5)

8110ae1 fix(contracts): advertise NUL as the hex escape strict validators accept
800403d chore: integrate current schema contracts for portable NUL validation
15b7043 test(mcp): consolidate verified schema portability coverage
251cc04 style: format the hook-adjusted Android input options
e31357e chore: refresh release checkpoint for schema portability

📊 Changes

8 files changed (+31 additions, -21 deletions)

View changed files

📝 src/application/android/AndroidAnalysisService.ts (+4 -3)
📝 src/contracts/native/nativeToolContracts.ts (+1 -1)
📝 src/domain/apple/dylibResolution.ts (+1 -1)
📝 src/domain/javascript/electronActiveObservation.ts (+1 -1)
📝 src/domain/localPath.ts (+10 -2)
📝 src/domain/native/nativeCallObservation.ts (+3 -5)
📝 src/domain/process/processScenario.ts (+3 -3)
📝 tests/boundary/mcp/advertisedPatternsVMode.test.ts (+8 -5)

📄 Description

A schema pattern rejected by a model provider can prevent every turn before any REA tool runs. Retain the contributor's NUL hex-escape change and integrate current main's look-around-free path and environment-name validators, preserving their accepted inputs and diagnostics.

Closes #1329. Related #1327 tracks delivery through a published package; merging source does not itself update npm latest.

Verification:

96 focused tests passed across five files: actual SDK-advertised schemas, declared JSON Schema validity, relative-path equivalence, reserved environment names and process runtime validation.
Actual stdio SDK verification preserves all 139 canonical tools. All 864 advertised pattern occurrences (92 distinct expressions) compile in JavaScript's default, u and v modes and the installed Rust regex engine. The reported short NUL escape is independently rejected by that engine; the hex replacement compiles.
Hex versus Unicode NUL spellings retain acceptance across control-byte, path, reserved-name and Unicode samples. Actual tool calls still reject NUL and reserved names before provider execution; a real process capture preserves an ordinary caller environment name, validated success and subsequent ping.
Build and strict static checks passed under the local resource guard. No authentication-based DeepSeek API request was made, and no new real Hopper/Ghidra runtime claim is made.

The existing live-catalog regression owns pattern portability coverage. A duplicate generated-catalog scanner was removed because it omitted schemas nested in arrays and overstated cross-engine coverage. Rust regex also accepts the Unicode NUL spelling, so the original blanket claim about that form was corrected.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1302 **Author:** [@Yi-111-a](https://github.com/Yi-111-a) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/advertise-portable-nul-escape` --- ### 📝 Commits (5) - [`8110ae1`](https://github.com/morluto/rea/commit/8110ae1eb8dbafb906f28acaaf34946603116d8b) fix(contracts): advertise NUL as the hex escape strict validators accept - [`800403d`](https://github.com/morluto/rea/commit/800403d1d659b8f37abf2f76cea370591cc6b708) chore: integrate current schema contracts for portable NUL validation - [`15b7043`](https://github.com/morluto/rea/commit/15b70437e7cfd4305e354d73d9e30acbf58b2d42) test(mcp): consolidate verified schema portability coverage - [`251cc04`](https://github.com/morluto/rea/commit/251cc04840ecd6ffeb64d3f6ecc7f9e756c73255) style: format the hook-adjusted Android input options - [`e31357e`](https://github.com/morluto/rea/commit/e31357e8ece0e7fbe16e842545a2a6038fb8e334) chore: refresh release checkpoint for schema portability ### 📊 Changes **8 files changed** (+31 additions, -21 deletions) <details> <summary>View changed files</summary> 📝 `src/application/android/AndroidAnalysisService.ts` (+4 -3) 📝 `src/contracts/native/nativeToolContracts.ts` (+1 -1) 📝 `src/domain/apple/dylibResolution.ts` (+1 -1) 📝 `src/domain/javascript/electronActiveObservation.ts` (+1 -1) 📝 `src/domain/localPath.ts` (+10 -2) 📝 `src/domain/native/nativeCallObservation.ts` (+3 -5) 📝 `src/domain/process/processScenario.ts` (+3 -3) 📝 `tests/boundary/mcp/advertisedPatternsVMode.test.ts` (+8 -5) </details> ### 📄 Description A schema pattern rejected by a model provider can prevent every turn before any REA tool runs. Retain the contributor's NUL hex-escape change and integrate current main's look-around-free path and environment-name validators, preserving their accepted inputs and diagnostics. Closes #1329. Related #1327 tracks delivery through a published package; merging source does not itself update npm latest. Verification: - 96 focused tests passed across five files: actual SDK-advertised schemas, declared JSON Schema validity, relative-path equivalence, reserved environment names and process runtime validation. - Actual stdio SDK verification preserves all 139 canonical tools. All 864 advertised pattern occurrences (92 distinct expressions) compile in JavaScript's default, u and v modes and the installed Rust regex engine. The reported short NUL escape is independently rejected by that engine; the hex replacement compiles. - Hex versus Unicode NUL spellings retain acceptance across control-byte, path, reserved-name and Unicode samples. Actual tool calls still reject NUL and reserved names before provider execution; a real process capture preserves an ordinary caller environment name, validated success and subsequent ping. - Build and strict static checks passed under the local resource guard. No authentication-based DeepSeek API request was made, and no new real Hopper/Ghidra runtime claim is made. The existing live-catalog regression owns pattern portability coverage. A duplicate generated-catalog scanner was removed because it omitted schemas nested in arrays and overstated cross-engine coverage. Rust regex also accepts the Unicode NUL spelling, so the original blanket claim about that form was corrected. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 00:30:55 +00:00

[GH-ISSUE #3796] [Tracker] Open feature requests by area (October 2026) #1471

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2782

No description provided.

Rows
Columns