[PR #1307] [CLOSED] fix(browser): compare complete frame projections deterministically #2787

New issue

Closed

opened 2026-10-17 21:10:14 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:14 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1307
Author: @rudycelekli
Created: 10/9/2026
Status: ❌ Closed

Base: main ← Head: fix/web-capture-frame-order

📝 Commits (1)

373645f fix(browser): compare complete frame projections deterministically

📊 Changes

2 files changed (+44 additions, -2 deletions)

View changed files

📝 src/domain/webCaptureDiff.ts (+8 -2)
📝 tests/boundary/browser/webCaptureDiff.test.ts (+36 -0)

📄 Description

Comparing two captures with the same frame URLs and origins in a different enumeration order incorrectly reports a DOM change when frames share a URL. Sort complete projected URL/origin pairs by canonical JSON code point order before hashing, retaining frame multiplicity. The fake-CDP consumer regression includes opaque and inherited-origin about:blank frames. No schemas or provider behavior change.

Validation: 1 failed, 8 passed on baseline 411498d4. Fixed: 9 passed. 33 passed in three files across affected suites. npm run check and git diff --check pass with pinned Node 24.18.0/npm 11.16.0.

Tests use owned fixtures and isolated processes; no real provider or full repository suite certification is claimed. Prepared with AI assistance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1307 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/web-capture-frame-order` --- ### 📝 Commits (1) - [`373645f`](https://github.com/morluto/rea/commit/373645f9207465b0bd1d1f9d119ad5482d7ad224) fix(browser): compare complete frame projections deterministically ### 📊 Changes **2 files changed** (+44 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/webCaptureDiff.ts` (+8 -2) 📝 `tests/boundary/browser/webCaptureDiff.test.ts` (+36 -0) </details> ### 📄 Description Comparing two captures with the same frame URLs and origins in a different enumeration order incorrectly reports a DOM change when frames share a URL. Sort complete projected URL/origin pairs by canonical JSON code point order before hashing, retaining frame multiplicity. The fake-CDP consumer regression includes opaque and inherited-origin about:blank frames. No schemas or provider behavior change. Validation: 1 failed, 8 passed on baseline 411498d4. Fixed: 9 passed. 33 passed in three files across affected suites. `npm run check` and `git diff --check` pass with pinned Node 24.18.0/npm 11.16.0. Tests use owned fixtures and isolated processes; no real provider or full repository suite certification is claimed. Prepared with AI assistance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:14 +00:00