[PR #1309] [CLOSED] fix(comparison): keep Ghidra generated function names ambiguous #2789

New issue

Closed

opened 2026-10-17 21:10:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1309
Author: @rudycelekli
Created: 10/9/2026
Status: ❌ Closed

Base: main ← Head: fix/comparison-ghidra-generated-names

📝 Commits (1)

414af02 fix(comparison): keep Ghidra generated function names ambiguous

📊 Changes

2 files changed (+4 additions, -2 deletions)

View changed files

📝 src/domain/functionComparison.test.ts (+3 -1)
📝 src/domain/functionComparisonNormalization.ts (+1 -1)

📄 Description

Ghidra names unnamed functions FUN_. The shared generated-name predicate recognizes Hopper/other forms but treats this address-derived Ghidra name as a real symbol. Equal autogenerated names can therefore produce matched symbol identity and unchanged calls claims across binaries. Recognize the exact hex-suffixed FUN_ form, keeping identity ambiguous and affected dimensions unknown; retain genuine nonhex FUN_ symbols. Tests exercise the public compareFunctions consumer.

Producer convention: Ghidra SymbolUtilities.

Validation: 3 failed,25 passed on baseline 411498d4. Fixed: 28 passed. 36 passed in3files across affected suites. npm run check and git diff --check pass with pinned Node 24.18.0/npm 11.16.0.

Tests use owned fixtures and isolated processes; no real provider or full repository suite certification is claimed. Prepared with AI assistance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1309 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/comparison-ghidra-generated-names` --- ### 📝 Commits (1) - [`414af02`](https://github.com/morluto/rea/commit/414af02f3278ae2d22c87be146c1f056563fcbce) fix(comparison): keep Ghidra generated function names ambiguous ### 📊 Changes **2 files changed** (+4 additions, -2 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/functionComparison.test.ts` (+3 -1) 📝 `src/domain/functionComparisonNormalization.ts` (+1 -1) </details> ### 📄 Description Ghidra names unnamed functions FUN_<hex-address>. The shared generated-name predicate recognizes Hopper/other forms but treats this address-derived Ghidra name as a real symbol. Equal autogenerated names can therefore produce matched symbol identity and unchanged calls claims across binaries. Recognize the exact hex-suffixed FUN_ form, keeping identity ambiguous and affected dimensions unknown; retain genuine nonhex FUN_ symbols. Tests exercise the public compareFunctions consumer. Producer convention: [Ghidra SymbolUtilities](https://github.com/NationalSecurityAgency/ghidra/blob/master/Ghidra/Framework/SoftwareModeling/src/main/java/ghidra/program/model/symbol/SymbolUtilities.java#L151). Validation: 3 failed,25 passed on baseline 411498d4. Fixed: 28 passed. 36 passed in3files across affected suites. `npm run check` and `git diff --check` pass with pinned Node 24.18.0/npm 11.16.0. Tests use owned fixtures and isolated processes; no real provider or full repository suite certification is claimed. Prepared with AI assistance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:15 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2789

No description provided.

Rows
Columns