[PR #1310] [CLOSED] fix(update): preserve disabled Grok Build integrations #2790

Closed
opened 2026-10-17 21:10:17 +00:00 by bsakaguchi · 0 comments
Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1310
Author: @rudycelekli
Created: 10/9/2026
Status: ❌ Closed

Base: main ← Head: fix/grok-disabled-maintenance-20261009


📝 Commits (1)

  • 515e14e fix(update): preserve disabled Grok Build integrations

📊 Changes

2 files changed (+38 additions, -1 deletions)

View changed files

📝 src/application/UpdateMaintenance.ts (+9 -1)
📝 tests/process-global/updateMaintenance.test.ts (+29 -0)

📄 Description

Problem

An owned Grok Build registration suppressed by top-level disabled_mcp_servers was still selected for update maintenance. The generated setup plan could re-enable an integration the user had explicitly disabled.

Change

Reuse the existing Grok disabled-server interpretation when selecting maintenance scope. Preserve entry-level enabled/disabled settings and refresh an enabled stale registration as before.

Verification

  • Frozen filesystem/compiled setup regression failed before the fix: the disabled registration produced a configure action.
  • After: all 16 maintenance tests passed, including Grok enabled/disabled, OpenCode disabled, foreign registrations, skill-only scope and subprocess behavior.
  • The isolated publication checkout passed npm run test:focused -- tests/process-global/updateMaintenance.test.ts, npm run check, npm run verify:package and npm pack --dry-run.
  • Configuration bytes and disabled settings remain unchanged during planning. This uses actual Grok TOML and REA setup; it does not test a live Grok service or perform an npm update installation. Hopper/Ghidra workflows are unaffected and were not run. Hosted checks are pending at submission.

AI assistance was used for investigation, implementation and verification.


🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1310 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/grok-disabled-maintenance-20261009` --- ### 📝 Commits (1) - [`515e14e`](https://github.com/morluto/rea/commit/515e14e5be5c325ae40a15864b5585f9c5d280f8) fix(update): preserve disabled Grok Build integrations ### 📊 Changes **2 files changed** (+38 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/application/UpdateMaintenance.ts` (+9 -1) 📝 `tests/process-global/updateMaintenance.test.ts` (+29 -0) </details> ### 📄 Description ## Problem An owned Grok Build registration suppressed by top-level `disabled_mcp_servers` was still selected for update maintenance. The generated setup plan could re-enable an integration the user had explicitly disabled. ## Change Reuse the existing Grok disabled-server interpretation when selecting maintenance scope. Preserve entry-level enabled/disabled settings and refresh an enabled stale registration as before. ## Verification - Frozen filesystem/compiled setup regression failed before the fix: the disabled registration produced a configure action. - After: all 16 maintenance tests passed, including Grok enabled/disabled, OpenCode disabled, foreign registrations, skill-only scope and subprocess behavior. - The isolated publication checkout passed `npm run test:focused -- tests/process-global/updateMaintenance.test.ts`, `npm run check`, `npm run verify:package` and `npm pack --dry-run`. - Configuration bytes and disabled settings remain unchanged during planning. This uses actual Grok TOML and REA setup; it does not test a live Grok service or perform an npm update installation. Hopper/Ghidra workflows are unaffected and were not run. Hosted checks are pending at submission. AI assistance was used for investigation, implementation and verification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-17 21:10:17 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#2790
No description provided.