morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #1317] [MERGED] test: share the client registration command to restore the jscpd gate #2796

New issue

Closed

opened 2026-10-17 21:10:22 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:22 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1317
Author: @kaoru0822-kitauji
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: test/dedupe-client-test-setup

📝 Commits (1)

abe2625 test: share the client registration command to restore the jscpd gate

📊 Changes

3 files changed (+21 additions, -16 deletions)

View changed files

📝 tests/boundary/filesystem/clientConfigurationDialects.test.ts (+6 -8)
📝 tests/boundary/filesystem/ompClientConfiguration.test.ts (+5 -8)
📝 tests/fixtures/clientEnvironment.ts (+10 -0)

📄 Description

Summary

npm run jscpd (part of check:ci, the "Static checks" job) fails on main at 4b8e744d:

ERROR: jscpd found too many duplicates (2.5%) over threshold (2.5%)

Measured with jscpd src/ tests/ --reporters json: 2.4990% at 24673aaa, then 2.5028% (8,049 duplicated lines) after #1301 (mine) merged. The README commit since then adds no TS. Every PR based on current main will fail Static checks until this is fixed. main's own CI run for 4b8e744d was still queued when I checked.

The new clone is from #1301. tests/boundary/filesystem/ompClientConfiguration.test.ts repeated the dialect test's imports and its 6-line npx registration command (16 duplicated lines).

Change

Export NPX_REGISTRATION_COMMAND from tests/fixtures/clientEnvironment.ts, the shared client test fixture added in #1301, and use it in both test files. Test-only change; the command value is unchanged.

Verification

npx jscpd src/ tests/: 2.4967% (8,026 duplicated lines); npm run jscpd passes.
npm run test:focused -- on ompClientConfiguration, clientConfigurationDialects, clientLifecycle and clientRegistrationStatus (85 passed)
tsc --noEmit, oxlint, npm run format:check

The margin under 2.5% is small (about 10 lines), so the next PR that adds duplicated lines will trip this again.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1317 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `test/dedupe-client-test-setup` --- ### 📝 Commits (1) - [`abe2625`](https://github.com/morluto/rea/commit/abe2625b79710a25fe7375c4e082667bfd0f92fb) test: share the client registration command to restore the jscpd gate ### 📊 Changes **3 files changed** (+21 additions, -16 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/filesystem/clientConfigurationDialects.test.ts` (+6 -8) 📝 `tests/boundary/filesystem/ompClientConfiguration.test.ts` (+5 -8) 📝 `tests/fixtures/clientEnvironment.ts` (+10 -0) </details> ### 📄 Description ## Summary `npm run jscpd` (part of `check:ci`, the "Static checks" job) fails on `main` at 4b8e744d: ``` ERROR: jscpd found too many duplicates (2.5%) over threshold (2.5%) ``` Measured with `jscpd src/ tests/ --reporters json`: 2.4990% at 24673aaa, then 2.5028% (8,049 duplicated lines) after #1301 (mine) merged. The README commit since then adds no TS. Every PR based on current `main` will fail Static checks until this is fixed. `main`'s own CI run for 4b8e744d was still queued when I checked. The new clone is from #1301. `tests/boundary/filesystem/ompClientConfiguration.test.ts` repeated the dialect test's imports and its 6-line npx registration command (16 duplicated lines). ## Change Export `NPX_REGISTRATION_COMMAND` from `tests/fixtures/clientEnvironment.ts`, the shared client test fixture added in #1301, and use it in both test files. Test-only change; the command value is unchanged. ## Verification - `npx jscpd src/ tests/`: 2.4967% (8,026 duplicated lines); `npm run jscpd` passes. - `npm run test:focused --` on `ompClientConfiguration`, `clientConfigurationDialects`, `clientLifecycle` and `clientRegistrationStatus` (85 passed) - `tsc --noEmit`, oxlint, `npm run format:check` The margin under 2.5% is small (about 10 lines), so the next PR that adds duplicated lines will trip this again. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:22 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:20 +00:00

[PR #2796] [MERGED] fix(wasm): attribute invalid paths to their selected fields #5400

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2796

No description provided.

Rows
Columns