[PR #1324] [CLOSED] fix(javascript): preserve distinct namespace provenance components #2802

New issue

Closed

opened 2026-10-17 21:10:26 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:26 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1324
Author: @rudycelekli
Created: 10/9/2026
Status: ❌ Closed

Base: main ← Head: fix/js-provenance-component-keys

📝 Commits (1)

305572c fix(javascript): retain distinct module provenance path components

📊 Changes

2 files changed (+17 additions, -1 deletions)

View changed files

➕ src/domain/javascript/javascriptSemanticAnalysis.origin_paths.test.ts (+16 -0)
📝 src/domain/javascript/javascriptSemanticProvenance.ts (+1 -1)

📄 Description

Valid JavaScript property names can contain NUL. Namespace paths ns["a\u0000b"] and ns.a.b are distinct, but NUL-joined provenance keys collapse importedPath ["a\u0000b"] and ["a", "b"], discarding one possible origin. Encode the specifier and imported path as a JSON tuple for deterministic deduplication and ordering without collisions between path components.

Validation: the public analyzeJavaScriptSemantics regression fails on the exact baseline. Fixed focused suites pass 66 tests; related semantic suites pass 236 tests across 15 files. npm run check succeeds across all 6 tasks with existing warnings and 0 errors; whitespace checks pass. No schema or provider behavior changes. Prepared with AI assistance.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1324 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/9/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/js-provenance-component-keys` --- ### 📝 Commits (1) - [`305572c`](https://github.com/morluto/rea/commit/305572cb0e08c7910a839465a0a72a60c0475e64) fix(javascript): retain distinct module provenance path components ### 📊 Changes **2 files changed** (+17 additions, -1 deletions) <details> <summary>View changed files</summary> ➕ `src/domain/javascript/javascriptSemanticAnalysis.origin_paths.test.ts` (+16 -0) 📝 `src/domain/javascript/javascriptSemanticProvenance.ts` (+1 -1) </details> ### 📄 Description Valid JavaScript property names can contain NUL. Namespace paths ns["a\u0000b"] and ns.a.b are distinct, but NUL-joined provenance keys collapse importedPath ["a\u0000b"] and ["a", "b"], discarding one possible origin. Encode the specifier and imported path as a JSON tuple for deterministic deduplication and ordering without collisions between path components. Validation: the public analyzeJavaScriptSemantics regression fails on the exact baseline. Fixed focused suites pass 66 tests; related semantic suites pass 236 tests across 15 files. `npm run check` succeeds across all 6 tasks with existing warnings and 0 errors; whitespace checks pass. No schema or provider behavior changes. Prepared with AI assistance. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:26 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:24 +00:00

[PR #2802] [MERGED] fix(apktool): resolve Windows PATH launchers before invocation #5406

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2802

No description provided.

Rows
Columns