[PR #1346] [MERGED] fix(skill): pin packaged commands to the shipping package version #2814

New issue

Closed

opened 2026-10-17 21:10:35 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:10:35 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1346
Author: @Yi-111-a
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/9/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/skill-pin-package-version

📝 Commits (5)

c0b5148 fix(skill): pin packaged commands to the shipping package version
1e6b874 fix(skill): render packaged commands from the canonical registration version
f841d04 test(build): emit skill command identity in the cached build fixture
fc2276e chore: integrate current skill installation and diagnostic changes
1013759 Merge remote-tracking branch 'origin/main' into review/skill-version-1338

📊 Changes

3 files changed (+10 additions, -9 deletions)

View changed files

📝 scripts/generate-skill-metadata.mjs (+4 -4)
📝 tests/boundary/filesystem/dependencyInstall.test.ts (+4 -3)
📝 tests/boundary/filesystem/generatedSkill.test.ts (+2 -2)

📄 Description

Fixes #1338.

Agents following a pinned REA installation should run that package version. The bundled skill now renders its four authored rea-agents@latest commands using the canonical PRODUCT_IDENTITY.registrationPackageSpecifier, keeping them aligned with the MCP registration and byte-for-byte skill identity check. Authored instructions remain unchanged; generated outputs are not committed.

Validation:

Generated-skill and dependency-cache regression cases pass, including CRLF normalization, stale/missing references, and the cached-build fixture emitting the new identity prerequisite.
Actual CLI setup in an isolated home first prints its plan, installs the generated bundle, and performs no actions on repeat setup. doctor --skill --json reports healthy and an aligned skill identity. Installed bytes exactly match the bundle, and every REA command uses the package's version.
npm run build:cached and npm run docs:check pass.

The source package is currently 6.2.0; the generator follows future release metadata automatically. This verifies the candidate bundle, not publication of the fix to npm. No real Hopper/Ghidra verification is needed or claimed for this packaging-only change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1346 **Author:** [@Yi-111-a](https://github.com/Yi-111-a) **Created:** 10/9/2026 **Status:** ✅ Merged **Merged:** 10/9/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/skill-pin-package-version` --- ### 📝 Commits (5) - [`c0b5148`](https://github.com/morluto/rea/commit/c0b5148d595c7f600cf9d139df84aeb11f48c3ea) fix(skill): pin packaged commands to the shipping package version - [`1e6b874`](https://github.com/morluto/rea/commit/1e6b87414677468f69ffd91f3c75ec1d99df7fab) fix(skill): render packaged commands from the canonical registration version - [`f841d04`](https://github.com/morluto/rea/commit/f841d0485ee32d8ba0545c1f4964e86782bdb9ab) test(build): emit skill command identity in the cached build fixture - [`fc2276e`](https://github.com/morluto/rea/commit/fc2276ee5087a32ced50cc5cef3b6e8d08526fbb) chore: integrate current skill installation and diagnostic changes - [`1013759`](https://github.com/morluto/rea/commit/1013759b2c2e5a6ad4d977501d60a3df2aedee83) Merge remote-tracking branch 'origin/main' into review/skill-version-1338 ### 📊 Changes **3 files changed** (+10 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `scripts/generate-skill-metadata.mjs` (+4 -4) 📝 `tests/boundary/filesystem/dependencyInstall.test.ts` (+4 -3) 📝 `tests/boundary/filesystem/generatedSkill.test.ts` (+2 -2) </details> ### 📄 Description Fixes #1338. Agents following a pinned REA installation should run that package version. The bundled skill now renders its four authored `rea-agents@latest` commands using the canonical `PRODUCT_IDENTITY.registrationPackageSpecifier`, keeping them aligned with the MCP registration and byte-for-byte skill identity check. Authored instructions remain unchanged; generated outputs are not committed. Validation: - Generated-skill and dependency-cache regression cases pass, including CRLF normalization, stale/missing references, and the cached-build fixture emitting the new identity prerequisite. - Actual CLI setup in an isolated home first prints its plan, installs the generated bundle, and performs no actions on repeat setup. `doctor --skill --json` reports healthy and an aligned skill identity. Installed bytes exactly match the bundle, and every REA command uses the package's version. - `npm run build:cached` and `npm run docs:check` pass. The source package is currently 6.2.0; the generator follows future release metadata automatically. This verifies the candidate bundle, not publication of the fix to npm. No real Hopper/Ghidra verification is needed or claimed for this packaging-only change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:10:35 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:26 +00:00

[PR #2814] [MERGED] fix(ida): retain cleanup facts and let one-shot commands exit #5411

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2814

No description provided.

Rows
Columns