mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-17 21:10:51 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#2838
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/1376
Author: @rasatpetabit
Created: 10/9/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @morluto
Base:
main← Head:feat/pi-client-support📝 Commits (5)
cc1f35bfeat(setup): add native Pi client supportbaeadd5fix(setup): isolate invalid Pi agent directory overridesc0713c8fix(setup): parse Pi configuration as strict JSONd335cffMerge remote-tracking branch 'origin/main' into codex/fix-pi-review43c526fmerge: resolve Pi client conflicts with Hermes support📊 Changes
11 files changed (+763 additions, -12 deletions)
View changed files
📝
docs/installation.md(+28 -0)📝
src/application/ClientConfigurationDocument.ts(+5 -0)📝
src/application/ClientRegistrationStatus.ts(+13 -3)📝
src/application/SetupClientConfiguration.ts(+5 -0)📝
src/application/SetupHost.ts(+1 -0)📝
src/application/SupportedClients.ts(+71 -8)📝
src/application/Uninstall.ts(+2 -0)➕
tests/boundary/cli/piClientSetup.test.ts(+301 -0)📝
tests/boundary/filesystem/clientConfigurationDialects.test.ts(+3 -1)📝
tests/boundary/filesystem/clientLifecycle.test.ts(+1 -0)➕
tests/boundary/filesystem/piClientConfiguration.test.ts(+333 -0)📄 Description
Summary
Add first-class native Pi support to REA's existing client setup, doctor, and uninstall flows.
Pi users can already run REA's stdio MCP server by hand, but REA has no
piclient, sorea setupcannot discover or register Pi andrea doctorcannot diagnose a Pi registration. This adds--client pias a distinct client. It is not an alias of OMP (oh-my-pi), which uses a different directory, profiles, and server allow/deny lists.No Pi-specific issue or PR was found in this repository. This is a focused extension of the existing client-adapter system, alongside the separate OMP integration (#1301).
Problem and expected behavior
Pi reads user MCP registrations from
~/.pi/agent/mcp.json, or from the agent directory selected byPI_CODING_AGENT_DIR(MCP docs, agent-directory resolver). Reusing OMP's behavior would select the wrong file and misread Pi'senabled: false.Expected behavior: a scoped, additive registration that preserves unrelated configuration, installs REA's bundled skill where Pi already discovers skills, and works with the existing dry-run/approval, doctor, and owned-only uninstall flows:
Change and scope
pi/Pi/pi.~expansion; absolute paths; file URLs; relative paths resolved against the working directory (never silently replaced by the default); Windows native,~\, and Git Bash/MSYS, Cygwin, and WSL drive paths.JSON.parse). Comments, trailing commas, a byte-order mark, and empty files are reported as invalid and never rewritten. A missing file is created as valid JSON. Other clients keep their existing JSONC/BOM/empty-file tolerance.stdio, reports other transports as invalid, and treatsenabled: falseas disabled.enabledServers/disabledServershandling OMP-only.PI_CODING_AGENT_DIRfrom breaking other clients. Previously, an invalid value (for examplefile:///agent%2fdir) threw during client enumeration, so evenrea setup --client codexfailed. The error now stays on Pi's entry: scoped setup/doctor for other clients succeeds, and selecting Pi fails closed with remediation and no filesystem access to a fallback directory.~/.agents/skills, which Pi discovers..pi/mcp.jsonoverrides,/mcpreplacement extensions, and/reload.Not included: project-scope setup, installing Pi or analysis providers, provider/native-analysis changes, or MCP tool changes. Generated catalogs and
skills/are not committed.Contract and boundary impact
SupportedClients.ts), then configuration parsing (ClientConfigurationDocument.ts).pivalue for the existing--clientoption on setup, doctor, and uninstall; no MCP tool or result-schema change.docs/public/product-catalog.json), package, or installation impact: supported-client metadata derives from the registry through existing generators; no build outputs committed.Evidence and regression coverage
Tests added or updated:
tests/boundary/filesystem/piClientConfiguration.test.ts(new): path resolution across override forms and platforms, OMP isolation, preservation, idempotency, owned-only uninstall, transport/enableddoctor states, and a strict-JSON matrix (comment, trailing comma, BOM-prefixed, empty, whitespace-only, BOM-only): parse rejected, setup fails before writing, doctorinvalid, uninstall preserves bytes, no backup created. It also covers missing-file initialization and confirms another JSON client still accepts the same inputs.tests/boundary/cli/piClientSetup.test.ts(new): public CLI in an isolated temporary home covering plan → approval → apply → doctor → repeat → uninstall; malformedPI_CODING_AGENT_DIRwith scoped Codex setup/doctor; missing-file creation; and malformed-fileneeds_humanwith no planned or applied actions.clientConfigurationDialects.test.ts,clientLifecycle.test.ts: Pi added to the shared dialect and lifecycle tables.Base reproduction or other evidence: the new tests were written first and failed before each production change: missing
piclient (38 failed), strict-JSON parsing (7 failed), and the malformed-override case through the real CLI.Consumer check: a separate probe packed this branch, ran its packaged CLI in an isolated home, and then loaded the result with Pi v1.1.0's own modules (
loadMcpConfig,McpServerConnection, the skill loader). It confirmed:enabled: falseoverride was honored.No Pi CLI, LLM, or interactive session was launched.
User-visible CLI/MCP output (trimmed, temporary home shown as
~):Remaining proof gaps: Windows path handling is covered by unit tests on Linux, not a native Windows Pi run. The Pi check exercises Pi's real loaders, not a full interactive session. Non-default
PI_CODING_AGENT_DIRforms are tested against Pi's resolver semantics, not through the live loader.For evidence-bearing changes:
Validation performed
On
c0713c8rebased ontomainata9f5dad, with Node.js 24.18.0 / npm 11.16.0 (the repository pins):npm run test:focused --with the 10 client/configuration test files (Pi, OMP, dialects, lifecycle, Pi CLI, registration status, setup skill, transactions, BOM, update maintenance) — passed, 184 testsnpm run verify:test-discovery— passed, 698 files discovered exactly oncenpm run check— passed, includingverify:architecture-guards; only existing lint warnings remainnpm run docs:check— passednpm run verify:package— passednpm pack --dry-run— passed, 1,052 filesPackaged REA → Pi v1.1.0 loader probe described above — passed
npm test— 6,098 passed, 8 failed, 89 skipped. All 8 failures are in firmware tests this PR does not touch, and they also fail on unmodifiedmainon this host:firmwareIntegration.test.ts(7 cases) andfirmwareMcp.test.ts(1 case) fail withUnsupported tool version 26.6.4; accepted releases are Binwalk 3.1.x.realpath('/usr/bin/true')is/usr/bin/gnutrue. The firmware test fixture detects its fake engine by a/truepath suffix, so it misidentifies the engine and reports the wrong version. It is a fixture/host interaction, not a Binwalk installation issue; I can file it separately if useful.An earlier full run, before rebasing onto current
main, also had three timing failures in unchanged process tests (localToolContracts.test.ts,processCaptureNormalization.test.ts). Those passed in this run and when run alone.Compatibility, safety, and release
/reloadto pick up a new registration.Review checklist
type(scope): outcome.Maintainer validation after updating main
Updated the contributor branch to current main with merge commit
d335cff69, resolving the path-import conflict with the merged Qwen home fix without rewriting contributor commits. Review found no additional Pi-specific behavior correction needed beyond that integration conflict.On macOS with Node 24.18.0 / npm 11.16.0, 102 tests passed across Pi filesystem configuration, Pi public CLI setup, shared client lifecycle, and Qwen path coverage.
npm run check,npm run docs:check,npm run verify:package, andnpm pack --dry-runpassed. The package verifier discovered 139 MCP tools and verified the bundled skill and Skills 1.7.2 repository discovery. This maintainer pass did not repeat the contributor's native Pi loader probe or run a Windows/interactive Pi session.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.