[PR #1403] [MERGED] feat: add Hermes as a supported MCP client #2859

New issue

Closed

opened 2026-10-17 21:11:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:11:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1403
Author: @zaydiscold
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @morluto

Base: main ← Head: feat/hermes-mcp-client

📝 Commits (6)

8eda982 feat: add Hermes as a supported MCP client
1268239 docs: document the Hermes client and its config path
a1050eb Merge remote-tracking branch 'origin/main' into codex/fix-hermes-review
52b5b85 refactor(setup): resolve skill destinations per client
19ef27b fix(setup): install Hermes skills in the active profile
be79688 fix(setup): identify each client skill action uniquely

📊 Changes

19 files changed (+512 additions, -141 deletions)

View changed files

📝 docs/installation.md (+12 -0)
📝 package-lock.json (+2 -2)
📝 package.json (+3 -3)
📝 scripts/verify-package-install.mjs (+10 -1)
📝 src/application/ClientConfigurationDocument.ts (+47 -0)
📝 src/application/ClientRegistrationStatus.ts (+1 -17)
📝 src/application/Doctor.ts (+2 -2)
📝 src/application/Setup.fixture.ts (+4 -1)
📝 src/application/SetupHost.ts (+6 -8)
📝 src/application/SetupPlan.ts (+5 -12)
📝 src/application/SetupSkill.ts (+27 -44)
📝 src/application/SetupTypes.ts (+2 -1)
📝 src/application/SupportedClients.ts (+102 -30)
📝 src/application/Uninstall.ts (+11 -12)
➕ tests/boundary/cli/hermesClientSetup.test.ts (+98 -0)
📝 tests/boundary/filesystem/clientLifecycle.test.ts (+1 -0)
➕ tests/boundary/filesystem/hermesClientConfiguration.test.ts (+165 -0)
📝 tests/boundary/filesystem/setupSkill.test.ts (+11 -8)
📝 tests/fixtures/clientEnvironment.ts (+3 -0)

📄 Description

Hermes users currently have to register REA by hand. This adds rea setup --client hermes, doctor support, and owned-registration uninstall using Hermes's config.yaml / mcp_servers format. Existing settings and YAML comments are preserved, backups precede updates, and repeated setup is a no-op.

Setup resolves the active Hermes home, including whitespace trimming, environment-variable and home expansion, platform defaults, and HERMES_DATA_DIR_SUFFIX. The bundled skill installs in that profile's skills/reverse-engineer-anything directory, which Hermes discovers by default. Setup previews, installation, doctor and uninstall share the client-specific skill destinations.

YAML is a direct runtime dependency. The package verifier now installs with npm's nested production dependency layout, preventing an unrelated hoisted dependency from masking a missing runtime dependency. Before this correction, that install succeeded but both CLI help and setup crashed with ERR_MODULE_NOT_FOUND: yaml.

Validation on macOS with Node 24.18.0 / npm 11.16.0:

77 targeted filesystem/CLI tests passed; 16 focused skill-plan tests passed after assigning distinct action IDs to personal skill destinations.
npm run check, npm run docs:check, npm run verify:test-discovery, npm run verify:package, and npm pack --dry-run passed.
An actual packed npx --package <tarball> rea-agents workflow with nested dependencies and HERMES_HOME=" ~/profile " passed setup, doctor with skill validation, and uninstall. The skill appeared in the expanded profile's personal skill directory.
Updated against current main without rewriting the contributor's commits.

No analysis provider behavior changed. Hermes native skill-loader/interactive sessions and native Windows execution were not run in this maintainer validation; skill-root and home semantics were checked against upstream source. No version bump or generated outputs are committed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1403 **Author:** [@zaydiscold](https://github.com/zaydiscold) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `feat/hermes-mcp-client` --- ### 📝 Commits (6) - [`8eda982`](https://github.com/morluto/rea/commit/8eda9821a6ff2d30a80ecdbe82b471f7a98f6491) feat: add Hermes as a supported MCP client - [`1268239`](https://github.com/morluto/rea/commit/1268239f1bece882c8880974a13875798c57f9b6) docs: document the Hermes client and its config path - [`a1050eb`](https://github.com/morluto/rea/commit/a1050eb6d65bb6803ae141881c04590e3bb42d69) Merge remote-tracking branch 'origin/main' into codex/fix-hermes-review - [`52b5b85`](https://github.com/morluto/rea/commit/52b5b85a072346a5ccf73246834833da830229ed) refactor(setup): resolve skill destinations per client - [`19ef27b`](https://github.com/morluto/rea/commit/19ef27b6cc7a4fd3b00518e3a739a5963a442675) fix(setup): install Hermes skills in the active profile - [`be79688`](https://github.com/morluto/rea/commit/be79688f5413aa7d9561857e5f3e384a716dc9ba) fix(setup): identify each client skill action uniquely ### 📊 Changes **19 files changed** (+512 additions, -141 deletions) <details> <summary>View changed files</summary> 📝 `docs/installation.md` (+12 -0) 📝 `package-lock.json` (+2 -2) 📝 `package.json` (+3 -3) 📝 `scripts/verify-package-install.mjs` (+10 -1) 📝 `src/application/ClientConfigurationDocument.ts` (+47 -0) 📝 `src/application/ClientRegistrationStatus.ts` (+1 -17) 📝 `src/application/Doctor.ts` (+2 -2) 📝 `src/application/Setup.fixture.ts` (+4 -1) 📝 `src/application/SetupHost.ts` (+6 -8) 📝 `src/application/SetupPlan.ts` (+5 -12) 📝 `src/application/SetupSkill.ts` (+27 -44) 📝 `src/application/SetupTypes.ts` (+2 -1) 📝 `src/application/SupportedClients.ts` (+102 -30) 📝 `src/application/Uninstall.ts` (+11 -12) ➕ `tests/boundary/cli/hermesClientSetup.test.ts` (+98 -0) 📝 `tests/boundary/filesystem/clientLifecycle.test.ts` (+1 -0) ➕ `tests/boundary/filesystem/hermesClientConfiguration.test.ts` (+165 -0) 📝 `tests/boundary/filesystem/setupSkill.test.ts` (+11 -8) 📝 `tests/fixtures/clientEnvironment.ts` (+3 -0) </details> ### 📄 Description Hermes users currently have to register REA by hand. This adds `rea setup --client hermes`, doctor support, and owned-registration uninstall using Hermes's `config.yaml` / `mcp_servers` format. Existing settings and YAML comments are preserved, backups precede updates, and repeated setup is a no-op. Setup resolves the active Hermes home, including whitespace trimming, environment-variable and home expansion, platform defaults, and `HERMES_DATA_DIR_SUFFIX`. The bundled skill installs in that profile's `skills/reverse-engineer-anything` directory, which Hermes discovers by default. Setup previews, installation, doctor and uninstall share the client-specific skill destinations. YAML is a direct runtime dependency. The package verifier now installs with npm's nested production dependency layout, preventing an unrelated hoisted dependency from masking a missing runtime dependency. Before this correction, that install succeeded but both CLI help and setup crashed with `ERR_MODULE_NOT_FOUND: yaml`. Validation on macOS with Node 24.18.0 / npm 11.16.0: - 77 targeted filesystem/CLI tests passed; 16 focused skill-plan tests passed after assigning distinct action IDs to personal skill destinations. - `npm run check`, `npm run docs:check`, `npm run verify:test-discovery`, `npm run verify:package`, and `npm pack --dry-run` passed. - An actual packed `npx --package <tarball> rea-agents` workflow with nested dependencies and `HERMES_HOME=" ~/profile "` passed setup, doctor with skill validation, and uninstall. The skill appeared in the expanded profile's personal skill directory. - Updated against current main without rewriting the contributor's commits. No analysis provider behavior changed. Hermes native skill-loader/interactive sessions and native Windows execution were not run in this maintainer validation; skill-root and home semantics were checked against upstream source. No version bump or generated outputs are committed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:11:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:06:40 +00:00

[PR #2859] [CLOSED] fix(qlog): mark records incomplete when a declaration hides the event name #5443

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2859

No description provided.

Rows
Columns