[PR #1443] [MERGED] test(android): retain incomplete cleanup failure reasons #2890

New issue

Closed

opened 2026-10-17 21:11:28 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:11:28 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1443
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/jadx-cleanup-diagnostics-1441

📝 Commits (3)

5c81ccd test(android): retain incomplete cleanup failure reasons
21a720b test(android): include stop reasons in every failure reporter
6a826e1 Merge remote-tracking branch 'origin/main' into test/jadx-cleanup-diagnostics-1441

📊 Changes

1 file changed (+4 additions, -1 deletions)

View changed files

📝 tests/fixtures/android/jadx.ts (+4 -1)

📄 Description

The JADX process fixture asserted only the stop status when teardown was incomplete, dropping the typed reason needed to investigate the CI failure in #1441. Include the full stop disposition in the assertion message so every failure reporter retains that reason while enforcing the same cleanup requirement.

Vitest's object-subset matcher also strips unmatched reason fields from its failure diff. A controlled failure-output probe confirmed the reason was absent from the old subset assertion and present with the explicit disposition message. The temporary output probe is not committed.

Validation: all seven production process-boundary tests pass, including partial replies, cancellation and failed cleanup; full serial typecheck, lint and formatting pass under the documented two-CPU/process-family budget. Sixteen serial repetitions of the original case on frozen main also passed. This fixture uses a synthetic JADX protocol producer; no real JADX engine was exercised.

The original CI cleanup failure remains unreproduced. This diagnostic change adds no retries, skips or relaxed ownership checks and does not establish a root-cause fix.

Refs #1441, #1065.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1443 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/jadx-cleanup-diagnostics-1441` --- ### 📝 Commits (3) - [`5c81ccd`](https://github.com/morluto/rea/commit/5c81ccd3b4b1f718b68f581b77ec37916e5dd4d4) test(android): retain incomplete cleanup failure reasons - [`21a720b`](https://github.com/morluto/rea/commit/21a720bcc82cc9e45e1eb71db22bcdf5e4fef243) test(android): include stop reasons in every failure reporter - [`6a826e1`](https://github.com/morluto/rea/commit/6a826e116a7146c18b22e0a82ce0199f114be65d) Merge remote-tracking branch 'origin/main' into test/jadx-cleanup-diagnostics-1441 ### 📊 Changes **1 file changed** (+4 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `tests/fixtures/android/jadx.ts` (+4 -1) </details> ### 📄 Description The JADX process fixture asserted only the stop status when teardown was incomplete, dropping the typed reason needed to investigate the CI failure in #1441. Include the full stop disposition in the assertion message so every failure reporter retains that reason while enforcing the same cleanup requirement. Vitest's object-subset matcher also strips unmatched reason fields from its failure diff. A controlled failure-output probe confirmed the reason was absent from the old subset assertion and present with the explicit disposition message. The temporary output probe is not committed. Validation: all seven production process-boundary tests pass, including partial replies, cancellation and failed cleanup; full serial typecheck, lint and formatting pass under the documented two-CPU/process-family budget. Sixteen serial repetitions of the original case on frozen main also passed. This fixture uses a synthetic JADX protocol producer; no real JADX engine was exercised. The original CI cleanup failure remains unreproduced. This diagnostic change adds no retries, skips or relaxed ownership checks and does not establish a root-cause fix. Refs #1441, #1065. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:11:28 +00:00