[PR #1534] [MERGED] fix(ci): synchronize browser fixture events before inspection #2950

New issue

Closed

opened 2026-10-17 21:12:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:12:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1534
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/ci-browser-event-barrier

📝 Commits (1)

8386c70 fix(ci): synchronize browser fixture events before inspection

📊 Changes

3 files changed (+162 additions, -155 deletions)

View changed files

📝 tests/boundary/cli/browserCli.test.ts (+144 -145)
📝 tests/fixtures/fakeCdpBrowser.ts (+16 -10)
📝 tests/fixtures/fakeCdpBrowserTypes.ts (+2 -0)

📄 Description

The zero-millisecond browser CLI inspection sometimes reports a partial response body because the fake CDP producer acknowledges Network.enable before emitting its request/response/completion events. PR #1524 CI run 38043339226 exposed this ordering race; the production result correctly preserves the request shape.

Add an explicit producer option to deliver those events before the command acknowledgement, and use that wire barrier in the CLI contract fixture. Keep the complete body-shape assertion, without sleeps or product runtime changes. Flatten the redundant single-test suite wrapper to keep the existing lint limit.

Validation: both existing CLI journeys and both MCP browser tests passed; npm run check:fast passed. These are production HTTP/WebSocket/CLI/MCP boundary tests with a controlled producer, not a real-Chrome claim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1534 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/ci-browser-event-barrier` --- ### 📝 Commits (1) - [`8386c70`](https://github.com/morluto/rea/commit/8386c700611f4ddcf343304807c4880c8797b047) fix(ci): synchronize browser fixture events before inspection ### 📊 Changes **3 files changed** (+162 additions, -155 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/cli/browserCli.test.ts` (+144 -145) 📝 `tests/fixtures/fakeCdpBrowser.ts` (+16 -10) 📝 `tests/fixtures/fakeCdpBrowserTypes.ts` (+2 -0) </details> ### 📄 Description The zero-millisecond browser CLI inspection sometimes reports a partial response body because the fake CDP producer acknowledges `Network.enable` before emitting its request/response/completion events. PR #1524 CI run 38043339226 exposed this ordering race; the production result correctly preserves the request shape. Add an explicit producer option to deliver those events before the command acknowledgement, and use that wire barrier in the CLI contract fixture. Keep the complete body-shape assertion, without sleeps or product runtime changes. Flatten the redundant single-test suite wrapper to keep the existing lint limit. Validation: both existing CLI journeys and both MCP browser tests passed; `npm run check:fast` passed. These are production HTTP/WebSocket/CLI/MCP boundary tests with a controlled producer, not a real-Chrome claim. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:12:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:12:58 +00:00

[GH-ISSUE #8564] [Bug] WABT artifact verifier releases both roots after MCP cleanup fails #6653

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2950

No description provided.

Rows
Columns