mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[PR #1540] [MERGED] fix(javascript): accept the Wakaru 1.x release line and verify 1.14.0 #2956
Closed
opened 2026-10-17 21:12:14 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#2956
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/1540
Author: @pionxzh
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @morluto
Base:
main← Head:fix/wakaru-release-line📝 Commits (3)
5e7bee7fix(javascript): accept the Wakaru 1.x release line and verify 1.14.01cd1e2ffix(javascript): project known Wakaru warning fieldsb691b8bMerge remote-tracking branch 'origin/main' into HEAD📊 Changes
16 files changed (+272 additions, -66 deletions)
View changed files
📝
.github/workflows/real-javascript-recovery.yml(+2 -2)📝
docs/javascript-recovery.md(+34 -7)📝
docs/testing.md(+4 -2)📝
scripts/verify/javascript/recovery.mjs(+3 -3)📝
src/application/CapabilityInventory.ts(+1 -1)📝
src/contracts/javascript/javascriptRecoveryToolContracts.ts(+1 -1)📝
src/javascript/recovery/WakaruCommand.ts(+1 -1)📝
src/javascript/recovery/WakaruExecution.ts(+36 -32)📝
src/javascript/recovery/WakaruPublication.ts(+17 -3)📝
src/javascript/recovery/WakaruRelease.ts(+11 -3)📝
src/javascript/recovery/WakaruReport.ts(+12 -7)➕
src/javascript/recovery/WakaruVersion.test.ts(+39 -0)➕
src/javascript/recovery/WakaruVersion.ts(+39 -0)📝
tests/boundary/javascript-recovery/wakaruIntegration.test.ts(+38 -0)📝
tests/fixtures/javascript-recovery/producer.mjs(+33 -3)📝
third_party/wakaru(+1 -1)📄 Description
Summary
I maintain Wakaru. The recovery adapter from #848 only runs with Wakaru 1.13.0. It rejects every other build by exact
--versionequality, andz.strictObjectrejects any field Wakaru adds to its reports. So each Wakaru release breaksrecover_javascript_sourcesuntil REA re-pins.Wakaru 1.14.0 is out. Starting with that release, Wakaru documents a compatibility policy for its machine-readable output: within a major version,
--version,--json,provenance.jsonand the exit status rules change only by addition (new fields, and new values for category fields such askindandstatus). Wakaru's own tests lock the current key sets.This PR applies the release-line pattern from #844 (Binwalk/Unblob) and #840 (Ghidra) to Wakaru, and moves the verified build to 1.14.0.
Problem and expected behavior
REA_WAKARU_COMMANDto any Wakaru build other than 1.13.0, such as 1.14.0.capability_unavailable, "This adapter requires Wakaru 1.13.0".verified. Any other^1.13.0release iscompatible: it is accepted, Evidence reports the observed version instead of the pinned constant, and a limitation says the parser was not verified against that release. Other versions are still refused, with the accepted range in the message.First-time users also had no install hint. The refusal now points to a new "Install Wakaru" section with the release-binary and npm commands. A user write-up on
rea-agents@5.0.0(ai-100days day 010) hit this and had to guessnpm install wakaru@1.13.0, then find the platform binary insidenode_modulesby hand.Change and scope
WakaruVersion.ts:admitWakaruVersionreturnsverified/compatible/unsupported, likeadmitFirmwareVersion. It uses the existingsemverdependency. The accepted range is a major line (^1.13.0), not major.minor: Wakaru ships a minor release every one to three weeks and never ships patch releases, so a minor line would still be an exact pin in practice. The upstream policy above is what makes the major line safe.WakaruReport.ts:z.strictObject→z.looseObject, so unknown fields are kept inraw_result, not stripped.modules[].statusis now a string; it was already exposed asreported_status: string.kindstays"javascript": REA never passes--vue-sfc, so another kind would mean a non-JS artifact that REA should not publish as a module.extra-file,extra-provenance), symlink rejection, source-map validation, and engine/input digest re-checks.WAKARU_RELEASE,third_party/wakaru(8219bf50, v1.14.0), the CI download and SHA-256, andverify:javascript:recovery.bun extract. I can open issues for those if you're interested.Contract and boundary impact
src/javascript/recovery/).provider_missingremediation now name^1.13.0 (verified with 1.14.0). Input and output schemas are unchanged.^1.13.0; verified build 1.14.0. Still Linux x64 only.engine.versionand the provider version are now the observed version, not the pinned constant. Compatible releases add one limitation.audited_source_revisionis still the pinned revision.metadata:generateanddocs:generateproduced no tracked changes. No package changes.Evidence and regression coverage
WakaruVersion.test.ts: verified 1.14.0; compatible 1.13.0 and 1.15.2; rejects 1.12.0, 2.0.0, prerelease,v-prefixed, bare and empty banners.wakaruIntegration.test.ts+producer.mjs: a newadditivemode reportswakaru 1.99.0, unknown fields at every report and provenance level, and an unknown module status. The test expectscomplete, the observed version inengine.versionandprovider.version, the compatibility limitation, and the unknown field preserved inreports/stdout.json. On the base revision, this mode would fail at the version check, and then at strict parsing (source-derived; not run).buildRecoveryFixtures) through the darwin-arm64 builds of Wakaru 1.13.0 and 1.14.0 with the adapter's exact arguments. Both versions gave the same report keys, module kinds and statuses, formats, module counts, andsafety, and the recovered entry passed the fixture oracle for every non-inspection case. The Linux x64 1.14.0 binary from the release tarball and from@wakaru/cli-linux-x64@1.14.0on npm have the same SHA-256 (664fa067…).verify:javascript:recoverywith the real Linux x64 binary;real-javascript-recovery.ymlcovers that on this PR. The Linux-only boundary suite ran in an arm64node:24.18.0container with the platform guard lifted locally; that change is not part of this PR.For evidence-bearing changes:
Validation performed
npx vitest run src/javascript/recovery/WakaruVersion.test.ts(macOS): 9 passednpx vitest run tests/boundary/javascript-recovery src/javascript/recovery(Linux arm64 container,node:24.18.0, platform guard lifted locally): 40 passednpx vitest run src/application src/contracts src/javascript tests/acceptance/nonBinaryComposition.test.ts(macOS): 707 passed, 5 skippednpm run check:fast: passednpm run docs:check: passednpm run verify:test-discovery: passedoxfmt --checkon changed files: passedCompatibility, safety, and release
compatible.Review checklist
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.