[PR #1567] [CLOSED] fix(process): release terminal resources after observation failure #2976

New issue

Closed

opened 2026-10-17 21:12:27 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:12:27 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1567
Author: @rudycelekli
Created: 10/10/2026
Status: ❌ Closed

Base: main ← Head: fix/terminal-cleanup-failed-observation-20261010

📝 Commits (1)

ab00948 fix(process): release terminal resources after observation failure

📊 Changes

2 files changed (+37 additions, -3 deletions)

View changed files

➕ src/process/capture/TerminalRenderer.cleanup.test.ts (+28 -0)
📝 src/process/capture/TerminalRenderer.ts (+9 -3)

📄 Description

A failed queued terminal observation prevents dispose from releasing its addon and terminal. Release both resources even when the pending observation rejects, preserving the original failure.

Validation: actual headless xterm cleanup regression fails on baseline; all three related tests pass fixed. npm run check and test discovery pass on pinned Node24.18. No real PTY/provider workflow was run.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1567 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/10/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/terminal-cleanup-failed-observation-20261010` --- ### 📝 Commits (1) - [`ab00948`](https://github.com/morluto/rea/commit/ab00948229e13438c3051fecec554e81745f0af9) fix(process): release terminal resources after observation failure ### 📊 Changes **2 files changed** (+37 additions, -3 deletions) <details> <summary>View changed files</summary> ➕ `src/process/capture/TerminalRenderer.cleanup.test.ts` (+28 -0) 📝 `src/process/capture/TerminalRenderer.ts` (+9 -3) </details> ### 📄 Description A failed queued terminal observation prevents dispose from releasing its addon and terminal. Release both resources even when the pending observation rejects, preserving the original failure. Validation: actual headless xterm cleanup regression fails on baseline; all three related tests pass fixed. npm run check and test discovery pass on pinned Node24.18. No real PTY/provider workflow was run. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:12:27 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:07:22 +00:00

[PR #2976] [MERGED] fix(session): reject an unknown configured provider before unbound routing #5532

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#2976

No description provided.

Rows
Columns