mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-17 21:12:35 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#2986
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/1579
Author: @dakjdakd
Created: 10/10/2026
Status: ❌ Closed
Base:
main← Head:fix/browser-storage-seed-lifecycle📝 Commits (1)
1465ed8fix(browser): seed storage once per scenario storage area📊 Changes
7 files changed (+1014 additions, -44 deletions)
View changed files
📝
docs/browser-scenario-contract.md(+9 -0)➕
scripts/lib/browser-scenario-storage-e2e.mjs(+454 -0)📝
scripts/verify-real-browser.mjs(+12 -0)📝
src/browser/BrowserScenarioPartialObservation.ts(+8 -1)➕
src/browser/PlaywrightScenarioSession.test.ts(+55 -0)📝
src/browser/PlaywrightScenarioSession.ts(+68 -43)➕
src/browser/PlaywrightScenarioStorage.ts(+408 -0)📄 Description
Summary
Fixes #1578.
Initialize browser-scenario web storage once per actual browser storage area, before application code runs, and preserve the application's subsequent state across navigation. A scenario that starts with
state=initial, clicks a button writingupdated, and navigates on the same origin now capturesupdatedon the next document. Removal and empty strings are preserved as well.The change moves initialization ownership out of a persistent page script and into a provider-owned Chromium session. This avoids adding hidden keys to application storage and handles a declared origin first reached through an out-of-process iframe or through a later top-level navigation. The same implementation serves launch and external-connect scenarios through the existing shared provider.
Problem and expected behavior
browserScenarioStorageSchemacalls the supplied cookies and web-storage entries initial state. Before this change, cookies were added once, while local and session storage were written bypage.addInitScripton every new document. The application could visibly update its state, then have that state reset by the observer before its next script executed.The smallest executed reproduction is a local HTTP application with an Update button and a document-load read of both stores. The public CLI captures
initialatscenario_start,updatedafter the click, andinitialagain after a same-origingoto. The ordinary Chrome control preservesupdated. REA nevertheless reports completed steps and a complete, equality-eligible result, so the problem affects the fidelity of the captured execution rather than only the presentation of an artifact.Checking for an absent key would not repair the ownership rule. Logout and other ordinary workflows intentionally remove entries, and
""is a valid stored value. The observer must remember that it has initialized the storage area without interpreting the current application value as an initialization flag. The first read also needs to see the supplied seed: applying state after navigation or during artifact collection is too late for startup code.Change and scope
PlaywrightScenarioStorageowns one additional CDP connection for scenarios with declared web-storage blocks. It resolves seed values through the existingBrowserScenarioSecrets, combines entries for duplicate origin blocks, and keeps the initialized-area set in the provider process. No page-storage sentinel, window-name marker, synthetic navigation, or request interception is needed. Scenarios with no local/session storage blocks skip this owner entirely.For each document, a short isolated-world bootstrap has a unique source URL. A native breakpoint targets only that bootstrap's executable line. When the bootstrap pauses, the provider identifies its execution context and frame, obtains
Storage.getStorageKeyForFrame, and evaluates the initial assignments on that paused call frame. Application scripts proceed only after the provider resumes the bootstrap. Subsequent bootstrap executions for an initialized key resume without writing the stores.The storage key is the browser's actual area identity. In an externally launched Chrome with ordinary third-party partitioning, the same origin inside a cross-site iframe and at the top level has different keys. Each area receives its own initial state once. In a Playwright launch where those areas are shared, the shared key is initialized once and later frames see the application's changes. Session storage remains within the selected root tab because the owner attaches only to that tab and its iframe target tree.
Out-of-process iframe targets are configured while their startup is paused, then resumed. Nested target sessions forward protocol replies through their parent session. Startup targets are resumed even when configuration fails, and detached targets reject outstanding replies for their complete descendant tree. Page, context, and browser disconnection also settle the manually tracked child replies.
The change is confined to seven files:
src/browser/PlaywrightScenarioStorage.tsowns native initialization, area identity, descendant sessions, and teardown.src/browser/PlaywrightScenarioSession.tsacquires that owner, checks pending initialization failures within the existing execution boundaries, and releases it with the session. Storage cleanup runs independently of the browser owner's cached event finalization, so a failed storage close can be retried without repeating event finalization or browser closure. Startup cleanup retains the initialization promise and retry closure, including storage acquired after cancellation.src/browser/PlaywrightScenarioSession.test.tsverifies that storage cleanup retries while event finalization and browser closure each run once.src/browser/BrowserScenarioPartialObservation.tsadds the applicable instrumentation explanation to capture limitations.scripts/lib/browser-scenario-storage-e2e.mjscontains the real-browser storage regressions and assertions.scripts/verify-real-browser.mjscalls those regressions from the existing browser verifier.docs/browser-scenario-contract.mddocuments initial-state lifetime, partition identity, and the debugging interaction.Contract and boundary impact
There is a real debugging interaction worth calling out. Storage initialization briefly pauses the provider's isolated bootstrap on document startup. While its debugger connection is active, target debugger statements are resumed so a scenario does not become stuck on an unrelated pause. A simultaneous debugging session on an attached tab can therefore be affected. The docs and capture limitations state this explicitly. There is no global before-script instrumentation breakpoint, and scenarios without web-storage seeds do not enable this storage debugger owner.
Evidence and regression coverage
9ffc6210and the initial contribution basec19e15a2. The updated base603d04eechanges cleanup ownership but retains the same unconditional per-document storage assignment. The baseline CLI returned complete Evidence and successful owned-process cleanup while its post-navigation values reverted to the seeds.initial → updated → updated; removal followsinitial → null → null, and the empty-string case remains empty on the next document. No new output object or storage key is introduced. The shared provider correction also serves MCP callers.AbortSignalis an API argument. The broaderverify:browserjourney and a separate MCP storage execution were not run. The listed browser version defines the real-provider coverage for this change.For Evidence-bearing changes:
Validation performed
Verification used Windows, Chrome
154.0.8037.98, Node24.18.0, npm11.16.0, and Playwright1.58.2. The fix was rebased onto603d04ee3ac6ed496f84478164f832a9b5ce3b91, with startup and session teardown adapted to the current cleanup owner. Build, static checks, documentation, test discovery, and all focused real-browser workflows below were rerun on the updated commit.npm run build:cached— passed.npm run check— passed, including typecheck, lint, formatting, knip, metadata checks, resolved module boundaries, and architecture guards.npm run docs:check— passed.npm run test:local -- src/browser/PlaywrightScenarioBrowser.test.ts src/browser/PlaywrightBrowserScenarioProvider.test.ts src/browser/PlaywrightExecutionBoundary.test.ts src/browser/PlaywrightScenarioArtifacts.test.ts src/browser/PlaywrightScenarioEvents.test.ts src/browser/PlaywrightScenarioSession.test.ts— 28 tests passed, including the new independent storage-cleanup retry regression. The existing assertionkeeps failed event finalization failed across cleanup retriesalso fails on unmodified base603d04ee; that upstream event-finalization behavior is outside this storage correction.npm run verify:test-discovery— all 766 test files discovered exactly once.verifyScenarioStorageandverifyScenarioStorageFramesagainst a real launch-mode browser — passed. They check actual public CLI artifacts and confirm temporary-profile cleanup.connect— passed. Ordinary browser partitioning creates distinct iframe/top-level areas, each of which is initialized correctly. After capture, a native update/reload and deletion/reload retain their results, and the external target remains open.verifyScenarioStorageFailuresagainst the real provider — passed. A failed navigation retains its failed step with confirmed owned-browser cleanup. Cancelling an unfinished initial navigation returnsAnalysisCancelledErrorwithcleanupIncomplete: false.The simultaneous-frame regression creates four iframe navigations together. Their first scripts read and increment a shared seeded counter; the observed values, sorted independently of arrival order, are exactly
0, 1, 2, 3in both stores. This catches reseeding that would be hidden by testing only sequential navigation. The live-frame regression separately covers update, delete, and empty-string transitions before a top-level partition change and a return to the original iframe area.Compatibility, safety, and release
Review checklist
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.