[PR #1603] [CLOSED] fix(ci): preserve Git reads and simplify boundary fixtures #2999

New issue

Closed

opened 2026-10-17 21:12:43 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-17 21:12:43 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1603
Author: @N0zoM1z0
Created: 10/10/2026
Status: ❌ Closed

Base: main ← Head: fix/main-maintenance-ci-20261010

📝 Commits (10+)

69485e2 fix(ci): restore capture and maintenance regression checks
3ad063b Merge remote-tracking branch 'origin/main' into fix/main-maintenance-ci-20261010
3b66532 Merge commit '603d04ee3a' into fix/main-maintenance-ci-20261010
87b7bf8 fix(reference-source): distinguish Git API probes from failed reads
cace19c fix(ci): reconcile lifecycle checks with current main
2a6bef5 chore(ci): include current snapshot and runtime repairs
16caa5c chore(ci): refresh maintenance checks against current main
3c794a5 Merge commit '5100a1a1a5' into fix/ci-duplicate-boundaries-1603
c7fdd7e test(artifacts): share ASAR member fixture setup
1b3371a fix(ci): reconcile Git ownership and preserve portable checks

📊 Changes

5 files changed (+103 additions, -27 deletions)

View changed files

📝 src/application/ReferenceSourceVcsAdapter.ts (+12 -5)
📝 tests/boundary/cli/jsonInputSize.test.ts (+20 -4)
📝 tests/boundary/filesystem/javascript-applications/electronApplicationAnalysis.test.ts (+16 -12)
📝 tests/boundary/filesystem/referenceSourceVcs.test.ts (+31 -1)
📝 tests/process-global/updateMaintenance.test.ts (+24 -5)

📄 Description

Preserve Git read failures and maintenance inputs, and repair the shared CI duplication failure reproduced on main 5100a1a1.

Git reads validate encodings at the adapter boundary and keep unreadable loose refs unknown instead of falling back to packed refs. The CLI and Evidence boundary checks distinguish malformed oversized JSON from a typed string-assembly resource constraint. Noninteractive maintenance retains the existing owned skill destination and its bytes. Electron computed access preserves an explicit empty requested-members list and dynamic-access facts; a literal * remains a literal member.

The ASAR boundary tests now share eight identical archive setups and nine fully enumerated member selections. All existing cases and assertions remain, including cancellation, identity changes, retained handles after failed cleanup, combined handle/snapshot recovery, and streaming allocation checks. No duplication threshold or excluded-test configuration changes.

Validation on this source combined with frozen main 5100a1a1: fresh six-step runtime/metadata build, 19 ASAR cases before and after the fixture refactor, two actual Git/worktree/read-failure cases, seven Electron cases, and all eight static/documentation/architecture/discovery checks passed. Main alone reproduces the jscpd failure at 2.52%; the refactor removes 99 duplicated lines and passes at 2.49% with the unchanged 2.5% threshold. Fresh compiled public CLI/pinned-SDK MCP controls for 63-byte computed access and 45-byte literal-member targets verify complete normalized-result and Evidence-ID parity, unchanged JavaScript inputs and subsequent ping.

Earlier independent validation remains tied to its recorded revisions: 193 affected tests across 16 files, an 18-byte public Git import, and the bounded-heap JSON readers. The current native-addon controls are static and use an opaque three-byte .node fixture; they do not establish native export verification, Electron runtime behavior, or Hopper/Ghidra behavior. Final-source CI is pending. Original source and contributor history are retained.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1603 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/main-maintenance-ci-20261010` --- ### 📝 Commits (10+) - [`69485e2`](https://github.com/morluto/rea/commit/69485e27f7bee406f79a6cf862c4431ea3bc9e64) fix(ci): restore capture and maintenance regression checks - [`3ad063b`](https://github.com/morluto/rea/commit/3ad063b4542a2af91f704bcd2fae6cd9053c0a94) Merge remote-tracking branch 'origin/main' into fix/main-maintenance-ci-20261010 - [`3b66532`](https://github.com/morluto/rea/commit/3b66532e268f0940358ba5390d440f50e7e5c7b2) Merge commit '603d04ee3ac6ed496f84478164f832a9b5ce3b91' into fix/main-maintenance-ci-20261010 - [`87b7bf8`](https://github.com/morluto/rea/commit/87b7bf8db12a558b262402b6880a60d12f45095e) fix(reference-source): distinguish Git API probes from failed reads - [`cace19c`](https://github.com/morluto/rea/commit/cace19caadfe82e328d31a54c11545df3761fd28) fix(ci): reconcile lifecycle checks with current main - [`2a6bef5`](https://github.com/morluto/rea/commit/2a6bef5589f021ead51c4ae32e18a03d1299c750) chore(ci): include current snapshot and runtime repairs - [`16caa5c`](https://github.com/morluto/rea/commit/16caa5ca9bf973e7e54d15c4237c064fb73f0396) chore(ci): refresh maintenance checks against current main - [`3c794a5`](https://github.com/morluto/rea/commit/3c794a5cc0e822d80e6c7fe12be5750019c28f76) Merge commit '5100a1a1a56b810c8246b8c7ed19ff42c4d9dbe1' into fix/ci-duplicate-boundaries-1603 - [`c7fdd7e`](https://github.com/morluto/rea/commit/c7fdd7e153627a48b02c2f661cbdf7882a23a187) test(artifacts): share ASAR member fixture setup - [`1b3371a`](https://github.com/morluto/rea/commit/1b3371ad7f21410979c2ebb337f2774a44c69ba9) fix(ci): reconcile Git ownership and preserve portable checks ### 📊 Changes **5 files changed** (+103 additions, -27 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ReferenceSourceVcsAdapter.ts` (+12 -5) 📝 `tests/boundary/cli/jsonInputSize.test.ts` (+20 -4) 📝 `tests/boundary/filesystem/javascript-applications/electronApplicationAnalysis.test.ts` (+16 -12) 📝 `tests/boundary/filesystem/referenceSourceVcs.test.ts` (+31 -1) 📝 `tests/process-global/updateMaintenance.test.ts` (+24 -5) </details> ### 📄 Description Preserve Git read failures and maintenance inputs, and repair the shared CI duplication failure reproduced on main `5100a1a1`. Git reads validate encodings at the adapter boundary and keep unreadable loose refs unknown instead of falling back to packed refs. The CLI and Evidence boundary checks distinguish malformed oversized JSON from a typed string-assembly resource constraint. Noninteractive maintenance retains the existing owned skill destination and its bytes. Electron computed access preserves an explicit empty requested-members list and dynamic-access facts; a literal `*` remains a literal member. The ASAR boundary tests now share eight identical archive setups and nine fully enumerated member selections. All existing cases and assertions remain, including cancellation, identity changes, retained handles after failed cleanup, combined handle/snapshot recovery, and streaming allocation checks. No duplication threshold or excluded-test configuration changes. Validation on this source combined with frozen main `5100a1a1`: fresh six-step runtime/metadata build, 19 ASAR cases before and after the fixture refactor, two actual Git/worktree/read-failure cases, seven Electron cases, and all eight static/documentation/architecture/discovery checks passed. Main alone reproduces the `jscpd` failure at 2.52%; the refactor removes 99 duplicated lines and passes at 2.49% with the unchanged 2.5% threshold. Fresh compiled public CLI/pinned-SDK MCP controls for 63-byte computed access and 45-byte literal-member targets verify complete normalized-result and Evidence-ID parity, unchanged JavaScript inputs and subsequent ping. Earlier independent validation remains tied to its recorded revisions: 193 affected tests across 16 files, an 18-byte public Git import, and the bounded-heap JSON readers. The current native-addon controls are static and use an opaque three-byte `.node` fixture; they do not establish native export verification, Electron runtime behavior, or Hopper/Ghidra behavior. Final-source CI is pending. Original source and contributor history are retained. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-17 21:12:43 +00:00