morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[GH-ISSUE #5347] Review request: three CI-passing PRs awaiting maintainer assignment (#4941, #4946, #4947) #3254

New issue

Closed

opened 2026-10-31 00:38:26 +00:00 by bsakaguchi · 7 comments

bsakaguchi commented

2026-10-31 00:38:26 +00:00

Owner

Originally created by @ShuaixinHuang on GitHub (Oct 20, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/5347

Maintainer decision needed

I have many additional independent fixes queued locally, but the three-open-PR limit is fully occupied by #4941, #4946 and #4947. This prevents me from submitting further bug-fix PRs. Please identify a reviewer and a rough review/merge window, or explain what I should change and how I can continue contributing if these PRs are deferred.

This replaces #5318 with a concise account of the current, CI-passing state. The previous discussion remains linked for context.

Current verified state

Rechecked on October 20, 2026, at approximately 17:05 Beijing time: all three current heads remain open, with CI required and author readiness passing and no merge conflict reported by GitHub.

PR	Current head	Required CI	Author readiness	Merge conflict
#4947 — small Windows OpenCode test-fixture correction	`07d1af55`	Passed	Passed	None reported
#4946 — Windows environment override identity	`b4483ce8`	Passed	Passed	Resolved
#4941 — JavaScript application path ownership	`35e2cad5`	Passed	Passed	None reported

#4946's synchronization passed all 38 selected CI jobs, including five portable shards with 9,636 tests passing and zero failures. The PR descriptions retain their verification evidence and limitations. I remain responsible for the changes and for responding to human review feedback.

Why I am asking

These PRs opened on October 18 and are entering their third calendar day. While waiting, moving upstream has required repeated synchronization, conflict resolution and rerunning validation. The open-PR limit also leaves 10+ follow-up contributions queued locally. Repeating this work without a review owner or approximate review window is discouraging and makes it difficult to continue contributing.

Requested decision

Please identify who will review these PRs and give a rough review/merge window. Starting with the small test-only #4947 would help unblock the queue.
Please provide a concrete list of remaining code changes, manual verification, documentation or other requirements I should complete.
If any PR is deferred or not intended for merge, please state that decision and advise which should be narrowed or closed, or whether another independent PR may be submitted while these wait. I need a practical way to submit the additional fixes already queued locally.
Please clarify whether contributors should resynchronize continuously while waiting, or refresh once a reviewer is ready.

This is a review-coordination request; the existing CI and human-review requirements remain in place. Related workflow discussions: #3445 and #3588. Thank you for your time.

Originally created by @ShuaixinHuang on GitHub (Oct 20, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/5347 ### Maintainer decision needed I have many additional independent fixes queued locally, but the three-open-PR limit is fully occupied by #4941, #4946 and #4947. This prevents me from submitting further bug-fix PRs. Please identify a reviewer and a rough review/merge window, or explain what I should change and how I can continue contributing if these PRs are deferred. This replaces #5318 with a concise account of the current, CI-passing state. The previous discussion remains linked for context. ### Current verified state Rechecked on October 20, 2026, at approximately **17:05 Beijing time**: all three current heads remain open, with **CI required and author readiness passing** and **no merge conflict reported by GitHub**. | PR | Current head | Required CI | Author readiness | Merge conflict | | --- | --- | --- | --- | --- | | #4947 — small Windows OpenCode test-fixture correction | `07d1af55` | [Passed](https://github.com/morluto/rea/actions/runs/39092134233/job/117573151265) | Passed | None reported | | #4946 — Windows environment override identity | `b4483ce8` | [Passed](https://github.com/morluto/rea/actions/runs/39352850029/job/118405107631) | Passed | Resolved | | #4941 — JavaScript application path ownership | `35e2cad5` | [Passed](https://github.com/morluto/rea/actions/runs/39350036839/job/118396947381) | Passed | None reported | #4946's synchronization passed all 38 selected CI jobs, including five portable shards with 9,636 tests passing and zero failures. The PR descriptions retain their verification evidence and limitations. I remain responsible for the changes and for responding to human review feedback. ### Why I am asking These PRs opened on October 18 and are entering their third calendar day. While waiting, moving upstream has required repeated synchronization, conflict resolution and rerunning validation. The open-PR limit also leaves 10+ follow-up contributions queued locally. Repeating this work without a review owner or approximate review window is discouraging and makes it difficult to continue contributing. ### Requested decision 1. Please identify who will review these PRs and give a rough review/merge window. Starting with the small test-only #4947 would help unblock the queue. 2. Please provide a concrete list of remaining code changes, manual verification, documentation or other requirements I should complete. 3. If any PR is deferred or not intended for merge, please state that decision and advise which should be narrowed or closed, or whether another independent PR may be submitted while these wait. I need a practical way to submit the additional fixes already queued locally. 4. Please clarify whether contributors should resynchronize continuously while waiting, or refresh once a reviewer is ready. This is a review-coordination request; the existing CI and human-review requirements remain in place. Related workflow discussions: #3445 and #3588. Thank you for your time.

bsakaguchi closed this issue

2026-10-31 00:38:26 +00:00

bsakaguchi commented

2026-10-31 00:38:27 +00:00

Author

Owner

@ShuaixinHuang commented on GitHub (Oct 20, 2026):

@morluto @N0zoM1z0 @kaoru0822-kitauji @baron — could one of you review #4941, #4946 and #4947, or help assign a reviewer?

The current-head CI results, readiness and conflict status are summarized above. Reviewing the small test-only #4947 first would help unblock the contribution queue. An acknowledgement or rough review window would also help me avoid repeated upstream synchronization while waiting.

Thank you for your time and help.

@ShuaixinHuang commented on GitHub (Oct 20, 2026): @morluto @N0zoM1z0 @kaoru0822-kitauji @baron — could one of you review #4941, #4946 and #4947, or help assign a reviewer? The current-head CI results, readiness and conflict status are summarized above. Reviewing the small test-only #4947 first would help unblock the contribution queue. An acknowledgement or rough review window would also help me avoid repeated upstream synchronization while waiting. Thank you for your time and help.

bsakaguchi commented

2026-10-31 00:38:27 +00:00

Author

Owner

@XinwangTao commented on GitHub (Oct 20, 2026):

赞同按 #4947 → #4946 → #4941 的顺序安排审查，从改动面最小的 test-only PR 起步确实能更快验证审查流程并释放积压队列。补充一点关于 resync 策略的想法：与其持续跟随上游同步（每次都要解决冲突并重跑 CI），不如等 reviewer 就位后再统一 resync 一次——只要 PR 尚未进入 review，冲突风险就主要是信息性的，先冻结能省下大量重复劳动；当然如果项目规范要求保持 head 最新，那给出一个明确的「多久必须 resync 一次」的时限也会让贡献者更可预期。另外 #4946 的 38 项 CI 全绿 + 9636 测试零失败是很强的验证信号，建议在回复中明确告知贡献者这些证据是否足够，还是需要补人工测试。

@XinwangTao commented on GitHub (Oct 20, 2026): 赞同按 #4947 → #4946 → #4941 的顺序安排审查，从改动面最小的 test-only PR 起步确实能更快验证审查流程并释放积压队列。补充一点关于 resync 策略的想法：与其持续跟随上游同步（每次都要解决冲突并重跑 CI），不如等 reviewer 就位后再统一 resync 一次——只要 PR 尚未进入 review，冲突风险就主要是信息性的，先冻结能省下大量重复劳动；当然如果项目规范要求保持 head 最新，那给出一个明确的「多久必须 resync 一次」的时限也会让贡献者更可预期。另外 #4946 的 38 项 CI 全绿 + 9636 测试零失败是很强的验证信号，建议在回复中明确告知贡献者这些证据是否足够，还是需要补人工测试。

bsakaguchi commented

2026-10-31 00:38:27 +00:00

Author

Owner

@XinwangTao commented on GitHub (Oct 20, 2026):

@XinwangTao commented on GitHub (Oct 20, 2026): 赞同按 #4947 → #4946 → #4941 的顺序安排审查，从改动面最小的 test-only PR 起步确实能更快验证审查流程并释放积压队列。补充一点关于 resync 策略的想法：与其持续跟随上游同步（每次都要解决冲突并重跑 CI），不如等 reviewer 就位后再统一 resync 一次——只要 PR 尚未进入 review，冲突风险就主要是信息性的，先冻结能省下大量重复劳动；当然如果项目规范要求保持 head 最新，那给出一个明确的「多久必须 resync 一次」的时限也会让贡献者更可预期。另外 #4946 的 38 项 CI 全绿 + 9636 测试零失败是很强的验证信号，建议在回复中明确告知贡献者这些证据是否足够，还是需要补人工测试。

bsakaguchi commented

2026-10-31 00:38:27 +00:00

Author

Owner

@ShuaixinHuang commented on GitHub (Oct 20, 2026):

@morluto, could you please clarify the next steps for #4941, #4946 and #4947 so I can plan my remaining contributions?

Merge decision and timing: are these PRs intended to be merged? If so, what review or other blockers remain, who will handle them, and is there a rough review/merge window?
What I should do: please list any specific changes, manual verification, documentation or upstream synchronization you need from me. I would appreciate a concrete checklist so I can address the remaining requirements directly.
Submitting other work: I have other independent fixes ready, but the three-open-PR limit leaves no room. If one or more of these PRs will not be merged, or will be deferred for a long time, could you say which ones should be narrowed or closed? Alternatively, may I submit another independent PR while these wait?

Thank you for your time. A clear merge, defer or decline decision would help me avoid repeated rework and continue contributing in the way you prefer.

@ShuaixinHuang commented on GitHub (Oct 20, 2026): @morluto, could you please clarify the next steps for #4941, #4946 and #4947 so I can plan my remaining contributions? 1. **Merge decision and timing:** are these PRs intended to be merged? If so, what review or other blockers remain, who will handle them, and is there a rough review/merge window? 2. **What I should do:** please list any specific changes, manual verification, documentation or upstream synchronization you need from me. I would appreciate a concrete checklist so I can address the remaining requirements directly. 3. **Submitting other work:** I have other independent fixes ready, but the three-open-PR limit leaves no room. If one or more of these PRs will not be merged, or will be deferred for a long time, could you say which ones should be narrowed or closed? Alternatively, may I submit another independent PR while these wait? Thank you for your time. A clear merge, defer or decline decision would help me avoid repeated rework and continue contributing in the way you prefer.

bsakaguchi commented

2026-10-31 00:38:27 +00:00

Author

Owner

@ShuaixinHuang commented on GitHub (Oct 20, 2026):

@morluto, I have updated this issue with a fresh status check at 17:05 Beijing time: #4941, #4946 and #4947 still have passing CI required/readiness and no merge conflicts reported by GitHub.

I have many additional independent fixes queued locally, but all three open-PR slots are occupied. I currently cannot submit those further bug-fix PRs, which is preventing me from continuing this contribution work.

Could you please give me a concrete next step?

Who can review these PRs, and is there a rough review/merge window? Reviewing the small test-only #4947 first would help.
What specific changes or manual verification do you still need from me?
If these PRs are being deferred or will not be merged, which should be narrowed or closed, or may I submit another independent fix while they wait?

I want to keep contributing and will follow your preferred process. A clear decision would help me use my time on the fixes the project wants. Thank you.

@ShuaixinHuang commented on GitHub (Oct 20, 2026): @morluto, I have updated this issue with a fresh status check at 17:05 Beijing time: #4941, #4946 and #4947 still have passing CI required/readiness and no merge conflicts reported by GitHub. I have many additional independent fixes queued locally, but all three open-PR slots are occupied. I currently cannot submit those further bug-fix PRs, which is preventing me from continuing this contribution work. Could you please give me a concrete next step? - Who can review these PRs, and is there a rough review/merge window? Reviewing the small test-only #4947 first would help. - What specific changes or manual verification do you still need from me? - If these PRs are being deferred or will not be merged, which should be narrowed or closed, or may I submit another independent fix while they wait? I want to keep contributing and will follow your preferred process. A clear decision would help me use my time on the fixes the project wants. Thank you.

bsakaguchi commented

2026-10-31 00:38:28 +00:00

Author

Owner

@ShuaixinHuang commented on GitHub (Oct 20, 2026):

Thank you @morluto for reviewing and merging #4941, #4946 and #4947. I appreciate your time and the work involved in maintaining REA.

These merges free up the PR slots and let me continue contributing the independent fixes I have queued. I’ll keep the next contributions focused and include clear validation evidence. Thanks again!

@ShuaixinHuang commented on GitHub (Oct 20, 2026): Thank you @morluto for reviewing and merging #4941, #4946 and #4947. I appreciate your time and the work involved in maintaining REA. These merges free up the PR slots and let me continue contributing the independent fixes I have queued. I’ll keep the next contributions focused and include clear validation evidence. Thanks again!

bsakaguchi commented

2026-10-31 00:38:28 +00:00

Author

Owner

@morluto commented on GitHub (Oct 26, 2026):

Thank you for the careful status update and for the contributions. #4941, #4946 and #4947 have all been merged, and your follow-up confirms that this freed the PR slots. Closing this request as resolved; broader review-process questions remain under discussion in #7243.

@morluto commented on GitHub (Oct 26, 2026): Thank you for the careful status update and for the contributions. #4941, #4946 and #4947 have all been merged, and your follow-up confirms that this freed the PR slots. Closing this request as resolved; broader review-process questions remain under discussion in #7243.

bsakaguchi referenced this issue

2026-10-31 01:08:33 +00:00

[PR #3254] [CLOSED] fix(javascript): resolve ESM relative imports with tabs or newlines #5678

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#3254

No description provided.

Rows
Columns