mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #6471] [Bug] A corrupt Zip64 end record returns the unsupported-target error family #3880
Closed
opened 2026-10-31 00:44:53 +00:00 by bsakaguchi
·
1 comment
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#3880
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 23, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/6471
Before submitting
Area
Evidence, artifacts, or reconstruction
Observed behavior
inspect-apk-signatureexits 1 for a ZIP with a corrupted Zip64 end-record signature, returning code/categoryunsupported_targetand recovery to select a supported target format. Restoring that signature makes the same archive succeed. Classic ZIP tail damage instead returnsinvalid_request/invalid_input. The refusal is correct; the error family and recovery are wrong for damage to a supported structure.Reproduction
From the repository root of the stated source baseline, use its pinned Node toolchain, locked dependencies and prepared compiled runtime, plus Python 3. The supplied runtime was used without rebuilding or installing dependencies. Run this block; it generates five inert ZIP/text fixtures, constructs an allowlisted HOME/XDG environment for each CLI child, records nonzero exits without aborting the loop, verifies the intact/restored ZIP entry and CRC with Python, and removes its temporary root even if an assertion fails. All fixture bytes are inline; no Android SDK, device, native signing tool or target execution is involved.
The corrected fixture reproduced in both complete CLI runs. Valid and restored are independently readable ZIPs with version 45 in both Zip64 version fields; this is not an Android-installability or cryptographic-signature test.
Expected behavior
The operation accepts local ZIP files and follows Zip64 end records. Damage to that supported ZIP structure should be refused as an input error, preserving the malformed-record cause, rather than reporting an unsupported target format. For this fixture that means code
invalid_request, categoryinvalid_input, and input-oriented recovery. The documented damaged-ZIP distinction and the error algebra's unsupported-format definition apply: the intact Zip64 layout works, and corrupting its required signature damages that layout without introducing a new format. This report asks for the existing refusal contract, not successful parsing of damaged input or broader Zip64 support.Impact and scope
P2: an agent or program branching on the typed code/category receives unsupported-format recovery for damaged ZIP input. The precise malformed-record cause survives in
details.reason, so parsing that detail is an available workaround. No successful signing fact is wrong, and no security boundary crossing was observed. Only the corrupt-signature branch was exercised; real-world frequency, missing-locator behavior, unsafe-range behavior and earlier known-good source are NOT_ENOUGH_INFO.REA version
Source baseline
e32a0494d4onmain; package and CLI report 6.7.0. Used the supplied prepared compiled runtime. The publishedrea-agents-6.7.0tag lacks this operation and its implementation/docs by source inspection; a published-release runtime was not tested. This report concerns post-release source.Runtime and platform
Node.js v24.18.0 (checkout pin), npm 11.16.0, Python 3; macOS 27.0.1 arm64. No dependency install or build was run during verification.
Target and artifact context
Synthetic single-disk Zip64 ZIP with one inert
entry.txtmember, valid CRC, a 56-byte Zip64 end record with versions 45/45, locator and saturated classic end fields. Corrupt differs from valid at one byte inside the four-byte Zip64 end-record signature. Restored reconstructs valid exactly. Controls include an out-of-file classic directory offset and non-ZIP plain text.Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
Two complete CLI runs reproduced the classification for the corrected fixtures. Each intact/restored ZIP exited 0 with Evidence; corrupt, classic-damage and non-ZIP fixtures exited 1. Every CLI stderr was empty. The corrupt and intact inputs differ at one byte inside the four-byte Zip64 end-record signature; restoring that signature reconstructs the intact bytes exactly. The independently readable controls set the Zip64 version-made-by and version-needed fields to 45 (ZIP 4.5).
The corrupt diagnostic retains
details.reason: "This archive uses a Zip64 structure this reader does not decode (malformed Zip64 EOCD record)."andremediation.action: "Select a target supported by this operation or choose an operation supporting the reported target format.". Classic damage instead gives an input issue naming a central-directory extent past the ZIP end records. The plain-text case says it is not a ZIP/APK. Both valid controls pass Pythonzipfile.testzip()and return the originalentry.txtbytes.Contract breadcrumbs:
docs/apk-signature.md:237-247defines damaged-input versus non-ZIP refusal;docs/specs/apk-signature/spec.md:41-42specifies Zip64 traversal.src/domain/analysisErrorCore.ts:8-9defines unsupported target in terms of formats outside support. Input and unsupported failures project to different code/category pairs insrc/domain/analysisErrorProjection.ts:256-260andsrc/domain/analysisErrorPresentation.ts:252-256.An additional executed stdio MCP check initialized protocol
2025-06-18, listed the tool, and calledinspect_apk_signaturewith each fixture's absolute path once. For the three refused fixtures it returned the same error families, usingisError: true, no structured content, and text JSON containing the diagnostic. Valid/restored returned structured Evidence. The primary reproduction above exercises the CLI. Existing focused source tests passed: 38 tests in the ZIP-tail and APK-signature-provider test files, with one worker.Typed outcome or recovery expected
For the corrupt signature, keep refusal with code
invalid_request, categoryinvalid_input, a cause naming the damaged Zip64 end record, and input-oriented recovery. Preserve successful intact/restored inspection and the distinct genuinely non-ZIP refusal.Analysis or suspected cause
Source-derived:
src/domain/apkSignature/apkSigningBlock.ts:149-157tags the invalid Zip64 signaturezip64-unsupported;src/apkSignature/apkSignatureFailures.ts:46-51translates that tag toAnalysisUnsupportedTargetError. The public adapters expose that translation. No repair was attempted.Additional context
Proposed, not executed against a fix: rerun the inline reproduction with the corrupt case expected to remain exit 1 but return
invalid_request/invalid_input, name the malformed Zip64 end record, and offer input-oriented recovery. Keep valid/restored at exit 0 with complete Evidence, classic damage atinvalid_request/invalid_input, and genuinely non-ZIP text atunsupported_target. Through MCP, retainisError: trueand the canonical input-error diagnostic for the corrupt case. Changing only the wording while retaining the wrong machine-readable code/category does not restore this contract.Open and closed searches found no matching report. #6439 concerns issuer encoding and #6440 concerns signer comparison with an empty v2 scheme. #3953 concerns a separate artifact-reader missing-header failure, and #5836 concerns resource-boundary diagnostics. Those restoration signals are independent. Feature issue #4537 requires malformed archives to remain refused, which this report preserves.
@iamdgarcia commented on GitHub (Oct 23, 2026):
Confirmed and covered with a fix (
fix/zip64-eocdr-familyon my fork, happy to open the PR).The three Zip64 branches in
centralDirectoryOffset(apkSigningBlock.ts) all returnzip64-unsupported, but two of them are damage to a structure the reader supports, not a structure it doesn't:recordOffsetnull, out of range, or signature mismatch): the locator's existence declares a supported layout; inconsistent bytes aremalformed-zipterritory. Now returns{ kind: "malformed-zip", offset: locator }.{ kind: "malformed-zip", offset: recordOffset + 32 }.Both therefore project to the
invalid_requestfamily with theinspect_input_contractrecovery, matching the classic tail-damage cases instead of telling the user to select a different target format.The no-locator case (saturated fields, no locator at all) deliberately stays
zip64-unsupported: whether the writer omitted the locator or corruption removed it is undecidable from the bytes alone, and the recovery ("this reader doesn't decode Zip64") is accurate for the writer-omitted variant.Tests: two parser-level cases (damaged record signature in place; locator pointing past the record) plus an end-to-end provider case asserting the
AnalysisInputErrorsurface for a corrupted-record APK. Area suite: 135 passed.