mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #6694] [Bug] inspect-pe-certificates rejects WIN_CERTIFICATE padding counted in dwLength #4069
Closed
opened 2026-10-31 00:46:34 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#4069
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 23, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/6694
Before submitting
Area
Native analysis or decompilation
Observed behavior
The production
inspect-pe-certificates <path> --jsoncommand registration, executed directly from source, refuses a type-2WIN_CERTIFICATEwhen itsdwLengthincludes the required zero alignment padding. Both PE32 and PE32+ fixtures returninvalid_request/invalid_input, withinvalid_formatandPKCS#7 signedData is malformed: ContentInfo has trailing data.The identical SignedData and padding bytes decode successfully when the entry length excludes those padding bytes. Microsoft documents that the finalizeddwLengthshould include this padding.Executed paths were the real production CLI registration and output wrapper, plus separate shared-service calls using the real stable-file provider. This was not an installed
reaexecutable, compiled launcher, stdio MCP, Windows loader, or signature-verification run.Reproduction
Use the source revision and locked dependencies stated below, with the supported Node runtime. Run from the checkout root. The following self-contained replay includes the full self-authored payload and PE headers. It combines the executed fixture generator, provider/service calls, and production CLI-registration harness, with scratch/import paths made portable and intermediate log-writing omitted. The original service and CLI scripts ran separately; this combined presentation was not separately executed.
The replay leaves four self-authored fixtures in a
rea-pe-padding-*directory under the system temporary directory. The source CLI callback'sexitCodeis recorded per invocation; the outer multi-case harness does not itself exit 1 after the expected failures. Both final counted-padding fixtures failed in the executed source-CLI sample; both controls passed. Separate provider/service calls produced the same two failures and two successful controls.Expected behavior
Return the structural table, certificate and signer facts for the unchanged padding-counted fixtures. Microsoft's PE attribute certificate table specification describes zero padding to the next eight-byte boundary and includes that padding in the finalized
dwLength. The security-directory size is 304 in both cases, with no truncated table, missing payload bytes, extra entry or exceeded budget.REA's documented observations promise type-2 structural certificate and signer facts; its failure profile does not exclude ordinary WIN_CERTIFICATE alignment padding. Keep raw artifact/entry ranges and hashes attributable to the original selected bytes. Signature verification is outside this expectation.
Impact and scope
P2 bounded format-compatibility failure: counting four documented zero padding bytes prevents the entire requested certificate inventory from being returned for both tested PE formats. The exact same definite-length SignedData bytes decode in the controls, isolating the PE length boundary from CMS encoding support. Each final-format pair differs only at file offset
0x400: the low byte ofdwLengthchanges from0x2cto0x30(300 to 304). The payload and padding remain identical.No same-artifact REA workaround was demonstrated. Rewriting
dwLengthcreates the passing control but changes the caller-selected bytes and digest. NOT_ENOUGH_INFO: real-artifact prevalence, other platforms and an introducing release were not measured. Windows loading and cryptographic validity are outside the executed structural inspection scope.REA version
Source revision
a7f967cf240eba8309cbf4526b2fc6338a52a617, manifestrea-agents6.7.0. The parent investigation supplied the npm-latest check as 6.7.0. No dependency install, build, global installation, source change or remote issue filing occurred.Runtime and platform
Node.js v24.22.1, Linux x64, kernel
7.2.8-9-omarchy; repository-pinned Incur 0.6.1 and tsx 4.23.15. No Hopper, Ghidra, Windows SDK or analysis engine was used. Measured final source-CLI handler durations in order PE32 control/failure, PE32+ control/failure were 19.105 / 3.507 / 5.682 / 1.074 ms. The separate service durations were 16.621 / 1.229 / 1.495 / 0.544 ms. These are individual same-process measurements, not performance or prevalence claims.Target and artifact context
Self-authored 1,328-byte PE32/PE32+ data-only DLL fixtures with conventional headers, one initialized-data section and a 304-byte certificate table at file offset 1,024. The full 292-byte definite-length SignedData above contains one structural X.509 certificate with a DER RSAPublicKey field, one SignerInfo and inert signature placeholders. The failing finalized entry has eight header bytes, 292 payload bytes and four zero padding bytes counted in
dwLength. Neither executing the fixture nor accepting its signature is required by this read-only structural contract.Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
Both source-CLI failures contain this observed output excerpt:
Both controls return
coverage: {"status":"complete","examined_entries":1,"certificates":1}and certificate/signer serials01. Final fixture SHA-256 values are: PE32 excluded5c809299f4ca837e22ca790dfafd400e2799e31d94b3a7573cfdb1e4fcd6f83d; PE32 counted76f33f51fa023ee472982df07273f21adc6df1fce63f25289121f1604a8a1a88; PE32+ excluded2e1a1dcef692c9f0da505d87f4846b75d052ae5aa6c1f3d0833923fab9a77a23; PE32+ counted31c148da6f04a79a36803ca07505d2536e5e26ec041c26b523ae633b913c6de0.Typed outcome or recovery expected
Successful structural Evidence for each unchanged padding-counted fixture, including the one certificate and signer already observed in its control. Restoration should preserve artifact identity, table/entry range evidence and original digests; both controls should continue to return the same facts. This is a proposed restoration check; no fix was implemented. A proposal to tolerate arbitrary non-padding data after ContentInfo is outside this report.
Analysis or suspected cause
Source-derived explanation: the stable-file provider passes the unchanged file snapshot to the table parser. The parser uses all
dwLength - 8bytes as ASN.1 input, including finalized entry padding; the ASN.1 reader then requires ContentInfo to end exactly at that buffer's end. The catch converts this boundary mismatch to malformed PKCS#7. MCP registration reaches the same service, but that transport was not executed here.Additional context
Open and closed GitHub issues were searched for
certificate,Authenticode,WIN_CERTIFICATE,dwLength,certificate padding, and the exact trailing-data message. Explicit open and closedcertificate paddingsearches returned no matches. The closest candidate, closed #6574, was read in full: it concerns an indefinite-length BER ContentInfo envelope. This fixture uses definite-length DER and changes only the PE entry's length field; the current documented BER support and its restoration check are distinct from the external alignment boundary. APK #6439 concerns issuer-string encoding during signer matching; APK #6603 concerns constructed BER. Neither covers PE entry padding. NOT_ENOUGH_INFO: no last-known-good release or real-world frequency was established.Triage assessment