mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #1212] [Bug] MCP tool schemas emit regex patterns rejected under strict-mode validation (observe_native_calls blocks the whole request) #428
Closed
opened 2026-10-15 18:24:58 +00:00 by bsakaguchi
·
1 comment
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#428
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @chengong-art on GitHub (Oct 9, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/1212
Before submitting
anyOfshape problem. This is a different defect: the content of emittedpatternstrings is not a valid regex under strict modes.Area
MCP or agent integration
Observed behavior
When REA's
tools/listoutput is handed to a provider that validates toolparameterswithformat: "regex", the request is rejected before the model runs and no tool is ever dispatched:The failing
patterncomes fromobjcName, used bybreakpoints[].selectorandbreakpoints[].class_nameinobserve_native_calls.src/domain/native/nativeCallObservation.ts(still current onmain, last touched by70e8a8f8on 2026-10-08):z.toJSONSchema({ target: "draft-2020-12" })copiesregex.sourceverbatim into the schema as^[^\\s[\\]]+$, i.e. the pattern text^[^\s[\]]+$. An unescaped[inside a character class is accepted by Annex-B andu-mode parsing, but rejected byv-mode parsing — and by Ruby.It is not one field. I ran a real
initialize+tools/listhandshake against the installed server and compiled every emittedpattern(351 fields across 138 tools) in each flag mode:vflag; they reduce to 9 unique patterns.u, so the defect is invisible to REA's own runtime validation (Zod usesu) and tou-based validators.evaluate_reconstruction_coverage24,capture_browser_scenario18,compare_process_captures11,build_reconstruction_obligation_ledger9,verify_reconstruction3,observe_native_calls2,build_call_path2,open_binary1,compare_source_to_bundle1.reand Perl accept all of them; Ruby rejects theobjcNameone (premature end of char-class) and accepts the-//ones. So the fleet issue isv-mode specific, while^[^\s[\]]+$is the only one that is genuinely malformed outside JS too.Two things I had to get right, since both are easy to assert wrongly:
uandvcannot be combined (new RegExp(p,"uv")throwsInvalid flags), and inside au-mode class you may only escape the syntactically-meaningful set —\:\%\~\_are themselvesInvalid escape. A blanket "escape everything" sweep would break these schemas in the opposite direction.Reproduction
No target artifact needed — pure schema validation.
Actual output on
rea-agents@6.1.0:One-liner for the language-level fact, no server required (note the doubled backslashes are the decoded JSON form):
Expected behavior
Every string REA emits as
patternshould be a valid ECMA-262 regex in bothuandvmodes, so any client enforcingformat: "regex"accepts the tool list. The intended grammar and semantics should not change.Impact and scope
observe_native_calls—selector/class_namecan never reach a strict client, so LLDB call observation of ObjC methods is unavailable through it. Where the provider aborts the whole request on one bad schema (as in #1052), the entire REA surface is lost, not one tool.v-mode check. They are not rejected by the provider I use today, so they are a compatibility risk rather than a current outage — I am reporting them so one sweep and one guard fix the class, not just my symptom.u, so in-server validation, capture, evidence integrity, isolation and recovery are all correct once a call lands. This is purely a schema-interchange defect at thetools/list→ provider boundary.namefield documents-[NSString length]as valid, andobjcNameexists precisely to reject that bracketed form forselector/class_name. Behaviour matches intent; only the serialized syntax is fragile.REA version
rea-agents@6.1.0.npm view rea-agents dist-tags→latest: 6.1.0, so this is the current published release, andmainstill carries the pattern (src/domain/native/nativeCallObservation.ts@70e8a8f8).Runtime and platform
@modelcontextprotocol/server2.3.1, Zod 4.4.3, AJV 8.20.0tools/listTarget and artifact context
None. The defect is in the emitted schema, not in any analyzed binary, bundle, or workload.
Interface
MCP
Earliest failure stage
Request parsing or validation
Relevant output or evidence
Emitted shape (
breakpoints[].selector,breakpoints[].class_name):The 9 unique rejected patterns, per-mode compile result, and the offending
v-mode character:v^[^\s[\]]+$[(also fails Ruby)^[A-Za-z][A-Za-z0-9._-]*$-before]^[a-z][a-z0-9-]*$-before]^[A-Za-z][A-Za-z0-9._:/-]*$/and-before]^[A-Za-z][A-Za-z0-9._:/-]{0,199}$/and-before]^[\w .:@/+-]+$/and-before]^[A-Za-z0-9_+-]+(?:\/[A-Za-z0-9_+-]+)*$-before]observed_at)[+-]Verified
v-mode class-syntax set in this Node:[ ] - / ( ) { } |must be escaped;. : + % ~ _must not be (escaping%,~,_,:yieldsInvalid escapeunderu).Typed outcome or recovery expected
tools/listshould return schemas that surviveformat: "regex"inuandv, so strict clients can list and callobserve_native_calls. If a field's grammar cannot be expressed portably, it should shipminLengthonly and rely on the Zod-side check rather than emit a pattern some engines reject. No change to REA's runtime validation or error typing is wanted — that part is already correct.Analysis or suspected cause
Source-derived, and confirmed by compiling the exact serialized strings rather than inferring from the provider message:
z.toJSONSchemawritesregex.sourceinto the schema without normalizing character-class contents for strict modes. Zod's runtime and the package's own tests useu, where an unescaped[in a class is tolerated, so nothing inside the repo ever sees the failure. The trigger characters are the ones thevflag promotes to class syntax ([,],-,/, and the grouping metachars). #1052 hit the same provider boundary from the shape side, which suggeststools/listoutput deserves an explicit emit-time guard instead of per-report patches.Additional context
Proposed fix for the reported field — semantics byte-identical, verified:
Accepts
NSURLSession,foo:bar:; still rejects-[NSString length]and spaces (all six probe strings match the old pattern's result exactly).For the other 8, escaping only
-and/is enough and isu-safe, e.g.^[A-Za-z][A-Za-z0-9._:\-\/]*$; I confirmed each against the originals over a sample set and found no behaviour change. A naive sweep that also escapes:/%/~/_, or that setsvon existing patterns, would break them underu— worth a check rather than a regex-over-source fixup.Suggested regression test, so the whole class is caught at emit time instead of one tool at a time:
Happy to open a PR for the one-line
observe_native_callsfix (and the mechanical-//escapes for the other 8) — but the emit-time guard is the part I would want your call on.@kaoru0822-kitauji commented on GitHub (Oct 9, 2026):
Resolved on
mainby #1220 (escaped the reserved characters in every advertisedpatternand addedtests/boundary/mcp/advertisedPatternsVMode.test.ts) and #1227 (shared the identifier and base64 patterns and completed the CDP metadata escapes).Verified on
mainatf4c99ab8with a real stdioinitialize+tools/listhandshake:patternfields (input and output schemas), 92 unique patterns: 0 rejected bynew RegExp(p, "v").objcNamepattern used byobserve_native_callsis now emitted as^[^\s\x5b\x5d]+$.Regexp.new) and Pythonre.npx vitest run tests/boundary/mcp/advertisedPatternsVMode.test.tspasses.Thanks for the detailed census.