[GH-ISSUE #7474] fix: restore Windows native verification fixture and workflow coverage #4458

New issue

Closed

opened 2026-10-31 00:49:59 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:49:59 +00:00

Owner

Originally created by @gensokyo-dev on GitHub (Oct 27, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/7474

Area

Windows native verification / test fixtures

Observed behavior

Executed on main d6f88becd531cabafca1d968b89cf7fc77a80041, Linux x64, Node 24.22.1/npm 11.16.0: eight focused files report 90 passing / 10 failing tests. Eight loader cases stop at PE admission because their fake PE declares SizeOfOptionalHeader=0; two standalone artifact-verifier cases fail because their manually copied module lists omit the current optional-header dependency.

The preceding Windows run skips full native behavior and inspection-recovery proofs after the broad curated suite fails. The addon itself is required for existing Windows ownership and private-runtime boundaries; deleting native/windows/ is not the proposed fix.

Reproduction

npm run test:focused -- src/windows/WindowsNativeLoader.test.ts src/windows/WindowsPrivateRuntime.test.ts src/windows/WindowsOwnedProcess.test.ts src/windows/WindowsHandleClose.test.ts src/domain/windowsNativeArtifact.test.ts tests/boundary/process/windowsNativeArtifactVerifier.test.ts tests/boundary/process/windowsNativeInspectionWorkspace.test.ts tests/process-global/curatedWindowsLane.test.ts

Base: 90 pass / 10 fail; 16.734 s wall, 15.376 s family CPU, 444.4 MiB family peak under a single-CPU guard; no OOM/abort. These are deterministic Linux controls, not Windows execution.

Expected behavior and scope

Valid fixtures reach their intended loader branches, malformed identities remain rejected, and both source/preinstall and packed/source-free verifier workspaces execute without installed dependencies. Run existing Windows native proofs after their artifact/build prerequisites and before unrelated curated tests can block them. Consolidate fixture ownership and remove stale dependency lists. Preserve all native implementation, runtime authority, APIs and Evidence semantics.

Candidate evidence

101 focused tests pass; restoring the exact base workflow makes only the new ordering guard fail. Real CI addon identity validation passes, while corrupt digest, corrupt declared header with matching digest, and wrong-version controls fail; the original image is restored and passes again. PR #7479 executes and passes the real Windows artifact, native behavior and inspection ownership/recovery proofs before the broad curated suite. The remaining 7 Windows failures match exact-base CI (base had 15); later package/Node 22/24 checks are skipped. Source and built-shard baseline failures and fail-fast cancellations are recorded in the PR. Candidate resource observations are documented there; failed-base timing does not establish a speedup.

Originally created by @gensokyo-dev on GitHub (Oct 27, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/7474 ### Area Windows native verification / test fixtures ### Observed behavior Executed on main `d6f88becd531cabafca1d968b89cf7fc77a80041`, Linux x64, Node 24.22.1/npm 11.16.0: eight focused files report **90 passing / 10 failing tests**. Eight loader cases stop at PE admission because their fake PE declares `SizeOfOptionalHeader=0`; two standalone artifact-verifier cases fail because their manually copied module lists omit the current optional-header dependency. The [preceding Windows run](https://github.com/morluto/rea/actions/runs/40462475909/job/122052726740) skips full native behavior and inspection-recovery proofs after the broad curated suite fails. The addon itself is required for existing Windows ownership and private-runtime boundaries; deleting `native/windows/` is not the proposed fix. ### Reproduction ```sh npm run test:focused -- src/windows/WindowsNativeLoader.test.ts src/windows/WindowsPrivateRuntime.test.ts src/windows/WindowsOwnedProcess.test.ts src/windows/WindowsHandleClose.test.ts src/domain/windowsNativeArtifact.test.ts tests/boundary/process/windowsNativeArtifactVerifier.test.ts tests/boundary/process/windowsNativeInspectionWorkspace.test.ts tests/process-global/curatedWindowsLane.test.ts ``` Base: 90 pass / 10 fail; 16.734 s wall, 15.376 s family CPU, 444.4 MiB family peak under a single-CPU guard; no OOM/abort. These are deterministic Linux controls, not Windows execution. ### Expected behavior and scope Valid fixtures reach their intended loader branches, malformed identities remain rejected, and both source/preinstall and packed/source-free verifier workspaces execute without installed dependencies. Run existing Windows native proofs after their artifact/build prerequisites and before unrelated curated tests can block them. Consolidate fixture ownership and remove stale dependency lists. Preserve all native implementation, runtime authority, APIs and Evidence semantics. ### Candidate evidence 101 focused tests pass; restoring the exact base workflow makes only the new ordering guard fail. Real CI addon identity validation passes, while corrupt digest, corrupt declared header with matching digest, and wrong-version controls fail; the original image is restored and passes again. PR #7479 executes and passes the real Windows artifact, native behavior and inspection ownership/recovery proofs before the broad curated suite. The remaining 7 Windows failures match exact-base CI (base had 15); later package/Node 22/24 checks are skipped. Source and built-shard baseline failures and fail-fast cancellations are recorded in the PR. Candidate resource observations are documented there; failed-base timing does not establish a speedup.

bsakaguchi closed this issue

2026-10-31 00:49:59 +00:00

bsakaguchi referenced this issue

2026-10-31 01:13:14 +00:00

[PR #4503] [CLOSED] fix(ownership): retain failed artifact and native handles #6278