mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
[GH-ISSUE #7531] [Bug] PE certificate decoder budgets are reported as malformed input #4474
Closed
opened 2026-10-31 00:50:08 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#4474
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Originally created by @coygeek on GitHub (Oct 27, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/7531
Before submitting
Area
Native analysis or decompilation
Observed behavior
node scripts/rea.mjs inspect-pe-certificates "$WORK/certs-400.exe" --jsonrefuses a synthetic certificate table withcode: "invalid_request",category: "invalid_input", and apathissue with reasoninvalid_format, although its diagnostic identifies exhaustion of the fixed decoded-text budget. Recovery tells the caller to inspect the input schema and correct request fields. The same happens for the ASN.1 node budget withcerts-600.exe.The refusal itself is expected at the fixed allowance. The incorrect behavior is treating the exhausted decoder allowance as malformed PKCS#7 and request-field invalidity. Both failures already correctly report
retryable: false. Smaller fixtures generated by the same procedure return complete certificate inventories.Reproduction
REA_*,HOPPER_*,GHIDRA_*, andNODE_OPTIONSoverrides before running.This exact inline procedure was replayed once during verification, with two calls per input. The same final fixtures had also produced these results in an earlier independent CLI replay.
Expected behavior
Keep the bounded refusal and the existing no-partial-success behavior. Report an exhausted fixed decoder allowance as a non-retryable
resource_constraint, naming the applicable allowance and numeric limit, with recovery explaining that the allowance is fixed. A request-field correction cannot raise it.The documented operation performs bounded structural inspection and explicitly gives decoded certificate fields a shared 64 KiB budget. The shared semantic error contract distinguishes bounded resource admission refusals from malformed input and provides recovery for fixed decoder allowances. This expectation does not require accepting larger payloads, raising the limits, validating signatures, or returning partial inventories.
Impact and scope
P2: callers receive the wrong machine-readable failure category and recovery discriminator for two deterministic decoder-capacity refusals. The observed error identifies the selected path as invalid format instead of preserving resource exhaustion. No downstream automated retry loop or incorrect successful analysis was observed.
The tested scope is four synthetic PE32 files with one type-2 WIN_CERTIFICATE each. The 400-certificate file is 65016 bytes and the 600-certificate file is 97416 bytes, both far below the default 64 MiB file-read budget and using only one of the default eight table entries. The complete inventory is unavailable on refusal, as intended by the bounded operation; the report concerns classification and recovery rather than that intentional lack of partial output.
NOT_ENOUGH_INFO: prevalence in real signed binaries, a same-artifact public workaround, and downstream caller consequences were not established. The strict request schema exposes file-byte and table-entry limits, with no override for these decoder allowances. Signature validity and Windows trust acceptance were not tested or asserted.
REA version
Exact
node scripts/rea.mjs --versionoutput:Source commit:
65f1c447344a423fa2785847dbcea1e9a9e2454a.Runtime and platform
Node.js v24.22.1; Darwin 27.0.0, arm64. The built CLI ran locally with isolated HOME/XDG directories. No disassembler, analysis provider, Windows runtime, or target execution was involved.
Target and artifact context
Self-authored PE32 structural fixtures: 512-byte headers and an eight-byte-aligned overlay table with one type-2 WIN_CERTIFICATE. Its definite-length ContentInfo/SignedData holds 2, 200, 400, or 600 structural X.509 certificates, each with a positive serial, UTF8String issuer/subject, validity fields, SPKI and signatureValue, plus one non-empty SignerInfo. Key and signature bytes are inert placeholders, without a claim of cryptographic validity. Encoded payload lengths are 448, 32089, 64489, and 96893 bytes respectively.
Interface
CLI
Earliest failure stage
Native analysis or reconstruction
Relevant output or evidence
The public CLI replay above produced this error excerpt for both 400-certificate attempts:
Both 600-certificate attempts returned the same classification with this issue message:
The complete refusal remediation was:
The 2- and 200-certificate controls returned
coverage.status: "complete",examined_entries: 1, andcertificates: 2or200respectively.Expected source at the stated baseline:
docs/pe-certificates.md:46-73documents the fixed decoded-text allowance, bounded structural scope, and absence of signature verification.src/domain/analysisErrorCore.ts:24-48distinguishes resource failures from malformed input, defines bounded admission refusal, and carries fixed decoder allowance recovery.src/domain/fixedAllowanceRemediation.ts:1-25,59-71supplies deterministic fixed-parser recovery and non-retryability.docs/error-contract.schema.json:507-570supplies the public resource-constraint envelope.src/domain/asn1Ber.ts:14-19,55-60explicitly classifies exhausted nodes asbudget-exceededwith a numeric limit.src/domain/native/peCertificates.ts:39-60exposes only path, file-byte, and table-entry request fields.Failure source at the same baseline:
src/native/pe/PeCertificateAsn1.ts:48-55discards the shared reader's failure kind and numeric limit.:72-85reports decoded-text exhaustion through the same untagged failure type.src/native/pe/PeCertificateParser.ts:107-123,171-174reaches both failures through supported type-2 inspection and labels them malformed. Its:16-18helper makes them format failures.src/native/pe/PeCertificatesProvider.ts:144-151maps that reason to an invalid-input path issue.Supplemental executed source-owner probe: with a larger node allowance only for the probe, the unchanged BER reader consumed each payload exactly and counted 89, 6029, 12029, and 18029 nodes, all at maximum depth 9. The unchanged certificate decoder accepted every embedded certificate individually. With its standard 16384-node allowance, the reader returned explicit
budget-exceeded/limit16384on the 600-certificate payload. These checks establish structural framing and certificate-field premises; they do not establish a public decoder-limit override or cryptographic validity.Typed outcome or recovery expected
code: "resource_constraint", categoryresource_constraint,retryable: false, and structured limits identifying decoded-text bytes or ASN.1 nodes. Recovery should describe the exhausted fixed allowance rather than ask for request-schema corrections. The precise resource subtype and field names can follow the existing error contract; changing the allowance or returning partial success is not requested.Analysis or suspected cause
Source-derived explanation: the PE-specific ASN.1 boundary erases the shared reader's resource tag. Text-budget exhaustion also uses the generic certificate ASN.1 error. The table parser then converts both to a format failure, which the provider projects as invalid input. Keeping the refusal reason typed through these boundaries is a possible correction; no implementation or restoration test was performed.
Additional context
Open and closed issues and PRs were searched for certificate budgets, PKCS#7 malformed failures, PE resource constraints, and the exact two allowance messages. No duplicate was found. Closed #6574 addresses BER indefinite-length support; this reproduction uses definite lengths. Closed #6694 addresses counted WIN_CERTIFICATE padding, and closed #6709 addresses TeletexString names. Open PR #7160 raises the nesting-depth allowance and explicitly leaves failure classification unchanged; these fixtures have depth 9 and exhaust different allowances. Closed #5556 concerns recovery advice for other refusals already classified as resource constraints. No last-known-good or first-bad revision was established.
Triage assessment