[GH-ISSUE #7724] fix(windows): resolve default tools from the selected PATH before launch #4626

New issue

Closed

opened 2026-10-31 00:51:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:51:32 +00:00

Owner

Originally created by @gensokyo-dev on GitHub (Oct 28, 2026).
Original GitHub issue: https://github.com/morluto/rea/issues/7724

Before submitting

Searched open and closed issues (including the previously fixed JADX Java selection).
Removed credentials and private target data.

Area / interface / earliest stage

Provider discovery and upgrade; CLI/MCP; command selection before process launch.

Observed behavior

Source-derived finding at b0fb51cb4c: default ADB selection keeps the bare adb name; Apktool explicitly prepends the working directory unless an environment flag disables it; update passes bare package-manager commands to cross-spawn. Selection therefore depends on implicit Windows executable lookup rather than only the caller's selected PATH.

Reproduction and evidence

Source inspection: src/adb/AdbConfiguration.ts (resolveAdbBinary), src/apktool/ApktoolConfiguration.ts (resolveApktoolCommand), and src/application/UpdateCommandRunner.ts (runUpdateProcess). NOT_ENOUGH_INFO for a native Windows runtime reproduction at issue creation; the current development host is Linux. Regression checks and real Windows CI execution are proposed.

Expected behavior

Resolve default Windows commands from the selected PATH before launch; preserve explicitly configured absolute executables, explicit relative PATH entries, PATHEXT ordering, batch launcher handling, cancellation and diagnostic failures. If resolution fails, report that failure without falling back to implicit current-directory lookup.

Impact and scope

ADB, Apktool and update default executable selection on Windows. POSIX and explicitly selected executables should retain their behavior. Other provider selection is outside this focused issue. Runtime frequency and external impact are unknown.

Version / runtime / target

Source b0fb51cb; Node 24.22.1; Linux x64 development host. Target: Windows executable selection; no analysis target required.

Originally created by @gensokyo-dev on GitHub (Oct 28, 2026). Original GitHub issue: https://github.com/morluto/rea/issues/7724 ### Before submitting - [x] Searched open and closed issues (including the previously fixed JADX Java selection). - [x] Removed credentials and private target data. ### Area / interface / earliest stage Provider discovery and upgrade; CLI/MCP; command selection before process launch. ### Observed behavior Source-derived finding at b0fb51cb4c54a73da130087c3f3875ecdf1ea43e: default ADB selection keeps the bare `adb` name; Apktool explicitly prepends the working directory unless an environment flag disables it; update passes bare package-manager commands to cross-spawn. Selection therefore depends on implicit Windows executable lookup rather than only the caller's selected PATH. ### Reproduction and evidence Source inspection: `src/adb/AdbConfiguration.ts` (`resolveAdbBinary`), `src/apktool/ApktoolConfiguration.ts` (`resolveApktoolCommand`), and `src/application/UpdateCommandRunner.ts` (`runUpdateProcess`). NOT_ENOUGH_INFO for a native Windows runtime reproduction at issue creation; the current development host is Linux. Regression checks and real Windows CI execution are proposed. ### Expected behavior Resolve default Windows commands from the selected PATH before launch; preserve explicitly configured absolute executables, explicit relative PATH entries, PATHEXT ordering, batch launcher handling, cancellation and diagnostic failures. If resolution fails, report that failure without falling back to implicit current-directory lookup. ### Impact and scope ADB, Apktool and update default executable selection on Windows. POSIX and explicitly selected executables should retain their behavior. Other provider selection is outside this focused issue. Runtime frequency and external impact are unknown. ### Version / runtime / target Source b0fb51cb; Node 24.22.1; Linux x64 development host. Target: Windows executable selection; no analysis target required.

bsakaguchi closed this issue

2026-10-31 00:51:32 +00:00

bsakaguchi referenced this issue

2026-10-31 01:13:41 +00:00

[PR #4626] feat(native): inspect 16-bit NE executables #6338