[PR #1617] [CLOSED] test: verify current maintenance boundary behavior #4704

New issue

Closed

opened 2026-10-31 00:54:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:54:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1617
Author: @N0zoM1z0
Created: 10/10/2026
Status: ❌ Closed

Base: main ← Head: test/maintenance-boundary-contracts-20261011

📝 Commits (3)

058bc0a test: verify current maintenance boundary behavior
1ae4bec Merge remote-tracking branch 'origin/main' into test/maintenance-boundary-contracts-20261011
c2e2ed9 test(firmware): retain unverified workers before further launches

📊 Changes

6 files changed (+57 additions, -22 deletions)

View changed files

📝 tests/boundary/browser/cdpCleanupCancellation.test.ts (+8 -6)
📝 tests/boundary/evm/evmoleInterfaceProvider.test.ts (+34 -8)
📝 tests/boundary/filesystem/qwenClientConfiguration.test.ts (+8 -1)
📝 tests/boundary/firmware/firmwareIntegration.test.ts (+4 -7)
📝 tests/fixtures/fakeCdpBrowser.ts (+1 -0)
📝 tests/fixtures/fakeCdpBrowserTypes.ts (+2 -0)

📄 Description

Existing maintenance regressions fail on current behavior because they require optional CDP shutdown commands, deletion of a skill directory containing user files, flattened EVM diagnostics after an additional cleanup failure, and another firmware launch while prior process ownership remains unverified. Verify actual socket release while the external browser remains available, removal of the managed skill manifest while preserving caller files, the public projected diagnostic chain with retained-root cleanup after recovery, and blocked firmware launches while the uncertain workspace remains retained.

The EVM fixture now forwards actual cleanup confirmation from the owned launcher or the shared token-aware process-group helper. Its reporting-failure injection no longer discards that confirmation when recovery is enabled. Product code, public schemas and tool inventory are unchanged. The unverified-worker assertion correction is also present in #1616; that PR's actual retained-workspace recovery and provider changes remain separate.

Final integration includes main dce81ca4; at c2e2ed9aa2469b7ff8225018fddc8c6e071ebe5a, npm run test:focused -- tests/boundary/browser/cdpCleanupCancellation.test.ts tests/boundary/browser/cdpConnection.test.ts tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts tests/boundary/filesystem/qwenClientConfiguration.test.ts tests/boundary/evm/evmoleInterfaceProvider.test.ts tests/boundary/firmware/firmwareIntegration.test.ts passes all 84 runnable cases, with 2 host-only skips across six files. The focused preparation rebuilt the current runtime; the lane exited normally without an external guard stop. npm run check:fast, explicit-file formatting and git diff --check pass.

Linux x64, Node 24.18.0/npm 11.16.0; one lane, CPUs 13/15, nice 10, 2304 MiB family-RSS guard and 2 GiB host reserve. The workflows use real local HTTP/WebSocket, filesystem and subprocess boundaries with controlled producers. No real Chrome, Qwen agent, EVM Python engine or Hopper/Ghidra execution is claimed; Windows/macOS were not verified.

Refs #1065. Helps unblock #1601 without mixing its allocation implementation into this test-only change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1617 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/maintenance-boundary-contracts-20261011` --- ### 📝 Commits (3) - [`058bc0a`](https://github.com/morluto/rea/commit/058bc0af35c75a15f049be9260867af4c171ab4f) test: verify current maintenance boundary behavior - [`1ae4bec`](https://github.com/morluto/rea/commit/1ae4bec45bb779a27fc563be2a8d7e91a0983e52) Merge remote-tracking branch 'origin/main' into test/maintenance-boundary-contracts-20261011 - [`c2e2ed9`](https://github.com/morluto/rea/commit/c2e2ed9aa2469b7ff8225018fddc8c6e071ebe5a) test(firmware): retain unverified workers before further launches ### 📊 Changes **6 files changed** (+57 additions, -22 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/browser/cdpCleanupCancellation.test.ts` (+8 -6) 📝 `tests/boundary/evm/evmoleInterfaceProvider.test.ts` (+34 -8) 📝 `tests/boundary/filesystem/qwenClientConfiguration.test.ts` (+8 -1) 📝 `tests/boundary/firmware/firmwareIntegration.test.ts` (+4 -7) 📝 `tests/fixtures/fakeCdpBrowser.ts` (+1 -0) 📝 `tests/fixtures/fakeCdpBrowserTypes.ts` (+2 -0) </details> ### 📄 Description Existing maintenance regressions fail on current behavior because they require optional CDP shutdown commands, deletion of a skill directory containing user files, flattened EVM diagnostics after an additional cleanup failure, and another firmware launch while prior process ownership remains unverified. Verify actual socket release while the external browser remains available, removal of the managed skill manifest while preserving caller files, the public projected diagnostic chain with retained-root cleanup after recovery, and blocked firmware launches while the uncertain workspace remains retained. The EVM fixture now forwards actual cleanup confirmation from the owned launcher or the shared token-aware process-group helper. Its reporting-failure injection no longer discards that confirmation when recovery is enabled. Product code, public schemas and tool inventory are unchanged. The unverified-worker assertion correction is also present in #1616; that PR's actual retained-workspace recovery and provider changes remain separate. Final integration includes main `dce81ca4`; at `c2e2ed9aa2469b7ff8225018fddc8c6e071ebe5a`, `npm run test:focused -- tests/boundary/browser/cdpCleanupCancellation.test.ts tests/boundary/browser/cdpConnection.test.ts tests/boundary/browser/cdpBrowserProvider.lifecycle_failures.test.ts tests/boundary/filesystem/qwenClientConfiguration.test.ts tests/boundary/evm/evmoleInterfaceProvider.test.ts tests/boundary/firmware/firmwareIntegration.test.ts` passes all 84 runnable cases, with 2 host-only skips across six files. The focused preparation rebuilt the current runtime; the lane exited normally without an external guard stop. `npm run check:fast`, explicit-file formatting and `git diff --check` pass. Linux x64, Node 24.18.0/npm 11.16.0; one lane, CPUs 13/15, nice 10, 2304 MiB family-RSS guard and 2 GiB host reserve. The workflows use real local HTTP/WebSocket, filesystem and subprocess boundaries with controlled producers. No real Chrome, Qwen agent, EVM Python engine or Hopper/Ghidra execution is claimed; Windows/macOS were not verified. Refs #1065. Helps unblock #1601 without mixing its allocation implementation into this test-only change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:54:10 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4704

No description provided.

Rows
Columns