[PR #1631] [MERGED] test(javascript): share semantic graph fixtures #4713

New issue

Closed

opened 2026-10-31 00:54:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:54:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1631
Author: @N0zoM1z0
Created: 10/10/2026
Status: ✅ Merged
Merged: 10/10/2026
Merged by: @morluto

Base: main ← Head: test/semantic-fixture-duplication

📝 Commits (1)

ca16f50 test(javascript): share semantic graph fixtures

📊 Changes

3 files changed (+296 additions, -430 deletions)

View changed files

📝 src/domain/javascript/javascriptSemanticGraphQuery.test.ts (+27 -226)
📝 src/domain/javascript/javascriptSemanticGraphTraversal.test.ts (+17 -204)
➕ tests/support/javascriptSemanticGraphFixture.ts (+252 -0)

📄 Description

The main duplicate-code gate fails at 2.52%, blocking unrelated contributions such as #1627. Share the identical semantic graph Evidence and relation fixture builders between the query and traversal suites. Keep their assertions, graph identities, provenance, unknown frontiers and coverage unchanged.

The existing 2.5% threshold and scanner inputs remain unchanged; duplication falls from 9367 / 372253 lines (2.52%) to 9198 / 372119 (2.47%). Production code is unchanged.

Closes #1630
Refs #1627

Validation: all 38 focused query/traversal tests pass before and after. npm run build:cached and npm run check:ci pass with the original duplicate gate. Linux x64, Node 24.18.0/npm 11.16.0; no new real-provider claim.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1631 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/10/2026 **Status:** ✅ Merged **Merged:** 10/10/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `test/semantic-fixture-duplication` --- ### 📝 Commits (1) - [`ca16f50`](https://github.com/morluto/rea/commit/ca16f50e8f6ddc1f4e84e58f38e12da355f62450) test(javascript): share semantic graph fixtures ### 📊 Changes **3 files changed** (+296 additions, -430 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/javascript/javascriptSemanticGraphQuery.test.ts` (+27 -226) 📝 `src/domain/javascript/javascriptSemanticGraphTraversal.test.ts` (+17 -204) ➕ `tests/support/javascriptSemanticGraphFixture.ts` (+252 -0) </details> ### 📄 Description The main duplicate-code gate fails at 2.52%, blocking unrelated contributions such as #1627. Share the identical semantic graph Evidence and relation fixture builders between the query and traversal suites. Keep their assertions, graph identities, provenance, unknown frontiers and coverage unchanged. The existing 2.5% threshold and scanner inputs remain unchanged; duplication falls from 9367 / 372253 lines (2.52%) to 9198 / 372119 (2.47%). Production code is unchanged. Closes #1630 Refs #1627 Validation: all 38 focused query/traversal tests pass before and after. `npm run build:cached` and `npm run check:ci` pass with the original duplicate gate. Linux x64, Node 24.18.0/npm 11.16.0; no new real-provider claim. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:54:15 +00:00