mirror of
https://github.com/morluto/rea.git
synced 2026-11-05 06:45:22 +00:00
Closed
opened 2026-10-31 00:54:41 +00:00 by bsakaguchi
·
0 comments
No Branch/Tag specified
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
Mirrored from GitHub Pull Request
question
roadmap
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
morluto/rea#4752
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
📋 Pull Request Information
Original PR: https://github.com/morluto/rea/pull/1683
Author: @sathariels
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @morluto
Base:
main← Head:fix/dom-urls-xhtml-svg-prefix📝 Commits (2)
97ccfa0fix(browser): resolve XLink and SVG prefixes in XHTML dom_urls20a38e1fix(browser): bound XML namespace resolution and reject cyclic ancestry📊 Changes
4 files changed (+872 additions, -62 deletions)
View changed files
📝
src/browser/CdpCaptureDocuments.baseUrl.test.ts(+399 -0)📝
src/browser/CdpCaptureDocuments.ts(+40 -60)➕
src/browser/CdpCaptureDomSvg.ts(+275 -0)📝
tests/boundary/browser/cdpSvgXlinkHref.test.ts(+158 -2)📄 Description
Summary
inspect-web-pagestill omitsdom_urlsentries for some SVG links in XHTML. There is no linked issue for this change. It is the follow-up CassieFox23 reported on https://github.com/morluto/rea/pull/1602#issuecomment-6100254993 after #1602 merged: a prefixed<svg:a xlink:href>in an XHTML page is a link in Chrome and still gets no entry. This resolves element and attribute prefixes from in-scopexmlnsdeclarations in XML documents only. HTML documents are unchanged. Refs #1586.Problem and expected behavior
#1602 reports a literal
xlink:hrefwhen an element or ancestor is namedsvgand a closer ancestor is notforeignObject. Chrome's XML parser keeps prefixes, so an XHTML document's nodes arehtml,svg:svg, andsvg:a, and none of those names matchsvg.Smallest trigger: an XHTML page (
application/xhtml+xml) containing<svg:a xlink:href="/xl-pa1">.metadata.dom_urlshas no entry. Chrome treats that node as a link (namespaceURIis the SVG namespace,href.baseValis set, and it matches:any-link).Expected, still stored as attribute
href, with the same base URL and origin policy as a plainhref:<svg:a xlink:href>in XHTML, including one nested undersvg:foreignObject<svg:a xlink:href>with nosvgparent, when thesvgprefix is bound to the SVG namespace<svg:image xlink:href><a p:href>whenpis any prefix bound tohttp://www.w3.org/1999/xlinkPlain
hrefwins even when it is empty. The first duplicate attribute wins. These stay unreported: an XHTML<a>or<h:a>insideforeignObjectwhose namespace is XHTML, and<bogus:svg>whose prefix is bound to a namespace other than SVG. HTML documents keep today's literalxlink:hrefbehavior.Change and scope
DOMSnapshot.captureSnapshotstill has no namespace field. It does keepxmlnsandxmlns:pas attributes. HTML documents show an uppercase document element (HTML); XHTML and other XML documents show lowercasehtmlor a prefixed root.HTML documents (document element
HTML, and the existing synthetic snapshots whose root is unprefixedsvg) still use the per-document ancestry cache: SVG context is the namesvg, stopped byforeignObject. The fallback attribute remains the literal namexlink:href.XML documents resolve prefixes in one walk and store the result in that same per-document cache. Each node reuses its parent's namespace scope when it has no local
xmlnsdeclaration, so a deep tree does not walk ancestors again and does not copy a map per level. A cyclic parent chain fails closed. The default namespace applies to unprefixed elements and not to unprefixed attributes. An element is SVG only when its resolved namespace ishttp://www.w3.org/2000/svg. The fallback is the firstp:hrefwhose prefix resolves tohttp://www.w3.org/1999/xlink. It is used only when plainhrefis absent, and it is reported ashref. Node names and attribute names are not rewritten.Intentionally not included:
dom_urls[].attributechange.browserObservationSchemas.tsis unchanged.svgroot with noxmlnsas XML. Those snapshots stay on the HTML-parser path so #1602's tests stay valid.Contract and boundary impact
domMetadatain the browser CDP capture adapter, while normalizing aDOMSnapshot.captureSnapshotresult intometadata.dom_urls. Prefix resolution is owned bysrc/browser/CdpCaptureDomSvg.tsat that same stage. No earlier capture stage changes.dom_urls[].attributeenum stayshref | src | action | formaction | poster. XHTML pages that previously omitted prefixed SVG links now include those URLs ashref.HTMLvshtml) andxmlnsattributes preserved on the snapshot.hrefvalues (resolved URL plusdestination_scope). Observed node names and attribute names stay prefixed (svg:a,xlink:href).docs/public/product-catalog.json), package, or installation impact (CI generates and validates ignored catalogs andskills/; edit authored instructions inskill-src/and never commit build outputs): none. No schema, catalog, package, or skill source change.Evidence and regression coverage
Executed against
upstream/main(3749ccec) with the new tests applied and the production change reverted, then again with the change.src/browser/CdpCaptureDocuments.baseUrl.test.ts(prefixedsvg:aandsvg:image, orphansvg:a,svg:aundersvg:foreignObject, XHTML<a>and<h:a>excluded, custom XLink prefix, literalxlinkrebound to another namespace, href wins including empty href, outside-policy origin,bogus:svg, HTML document unchanged, xmlns on the element itself, forward ancestor, 4000 nested elements under 1000ms).tests/boundary/browser/cdpSvgXlinkHref.test.ts(real headless Chrome, page served asapplication/xhtml+xml).3749ccec,npm run test:focused -- src/browser/CdpCaptureDocuments.baseUrl.test.ts tests/boundary/browser/cdpSvgXlinkHref.test.tsfailed 9 tests and passed 36. The XHTML Chrome test received 2hrefentries (the plainhrefand the emptyhref) and not the 8 entries the page should produce. Prefixed snapshot fixtures produced[]instead of the SVG URL. The custom-prefix fixture reportedhttps://app.example.test/not-xlinkfrom the literal namexlink:hrefinstead ofhttps://app.example.test/xl-custom. The HTML-document test and the plain-href precedence test passed on that base because plainhrefis already collected for every element and HTML names are unchanged.metadata.dom_urlsfromCdpBrowserProvider.inspectPage, the same records the CLI and MCP adapters return. For<svg:a xlink:href="/xl-pa1">the entry is attributehref, url{origin}/xl-pa1, destination_scopeapproved. The DOM node stayssvg:awith attribute namexlink:href. The CLI and MCP routes were not invoked.verify:browserlane,inspect-web-pageCLI, and MCP route were not run. No real-world SVG page beyond the fixture.For evidence-bearing changes:
Validation performed
npm ci(Node v24.18.0, npm 11.16.0) - passed.npm run format:checkon unmodifiedupstream/main3749ccec- passed (All matched files use the correct format, 2491 files). The earlier unrelated format failure is not present on this base.npm run test:focused -- src/browser/CdpCaptureDocuments.baseUrl.test.ts tests/boundary/browser/cdpSvgXlinkHref.test.tson that base with these tests - failed, 9 failed / 36 passed.REA_BROWSER_NO_SANDBOX=true.npm run check- passed. Turbo typecheck, lint, format:check, knip, and metadata:check succeeded. Lint reported 707 warnings and 0 errors in unrelated files. Architecture guards passed across 1110 source files.format:checkpassed on this branch as well (All matched files use the correct format, 2492 files).npm run verify:test-discovery- passed (Discovered all 811 test files exactly once).npm run check:fast- passed on push.Compatibility, safety, and release
dom_urlsoutput is unchanged. XHTML pages gainhrefentries that were previously missing. Callers that assumed those links were absent will now see them, with the same attribute enum and destination policy.REA_BROWSER_NO_SANDBOX=truebecause this environment requires it. The test skips when no Chrome-family executable is installed. Hopper and Ghidra are not involved.outside_policyorunsupported. No new process authority. The boundary test starts a local Chrome and a loopback fixture server and tears both down.Review checklist
type(scope): outcome.🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.