[PR #1739] [MERGED] test(evidence): cover workflow question whitespace normalization #4786

New issue

Closed

opened 2026-10-31 00:55:03 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:55:03 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1739
Author: @014-code
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @morluto

Base: main ← Head: fix/workflow-unknown-whitespace

📝 Commits (1)

fab5889 test(evidence): cover workflow question whitespace normalization

📊 Changes

1 file changed (+57 additions, -0 deletions)

View changed files

📝 src/application/WorkflowEvidence.test.ts (+57 -0)

📄 Description

Summary

Add workflow-level regressions for residual questions with leading or trailing spaces, LF/tab, and U+FEFF.
Verify normalized questions are retained as unknowns while workflow Evidence preserves the original result.
Reject questions that become empty after whitespace normalization.
The production normalization fix is already in main via #1733; this PR adds regression coverage for the workflow boundary.

Verification

npm run test:local -- src/application/WorkflowEvidence.test.ts (9 tests passed)
npm run check:fast
npm run build:cached
oxfmt --check src/application/WorkflowEvidence.test.ts
git diff --check

The targeted tests, formatter, and build were run with Node 24.19.0 and npm 11.6.2. The push precheck also passed check:fast on the rebased commit.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1739 **Author:** [@014-code](https://github.com/014-code) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/workflow-unknown-whitespace` --- ### 📝 Commits (1) - [`fab5889`](https://github.com/morluto/rea/commit/fab5889e04ffe853ad1ff942f0a4324557f673c4) test(evidence): cover workflow question whitespace normalization ### 📊 Changes **1 file changed** (+57 additions, -0 deletions) <details> <summary>View changed files</summary> 📝 `src/application/WorkflowEvidence.test.ts` (+57 -0) </details> ### 📄 Description ## Summary - Add workflow-level regressions for residual questions with leading or trailing spaces, LF/tab, and U+FEFF. - Verify normalized questions are retained as unknowns while workflow Evidence preserves the original result. - Reject questions that become empty after whitespace normalization. - The production normalization fix is already in `main` via #1733; this PR adds regression coverage for the workflow boundary. ## Verification - `npm run test:local -- src/application/WorkflowEvidence.test.ts` (9 tests passed) - `npm run check:fast` - `npm run build:cached` - `oxfmt --check src/application/WorkflowEvidence.test.ts` - `git diff --check` The targeted tests, formatter, and build were run with Node 24.19.0 and npm 11.6.2. The push precheck also passed `check:fast` on the rebased commit. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:55:03 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:14:15 +00:00

[PR #4788] [CLOSED] fix(electron): report ELF and PE architectures in fuse inspection #6409

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4786

No description provided.

Rows
Columns