[PR #1754] [MERGED] fix(setup): preserve unrelated Hermes YAML line formatting #4795

New issue

Closed

opened 2026-10-31 00:55:08 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:55:08 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1754
Author: @zaydiscold
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/hermes-preserve-yaml-lines

📝 Commits (1)

989e0fb fix(setup): preserve unrelated Hermes YAML line formatting

📊 Changes

2 files changed (+25 additions, -1 deletions)

View changed files

📝 src/application/ClientConfigurationDocument.ts (+2 -1)
📝 tests/boundary/filesystem/hermesClientConfiguration.test.ts (+23 -0)

📄 Description

When REA updates or removes its Hermes MCP entry, the YAML serializer uses its default line width and rewraps unrelated long values, including user prompts. Disable that wrapping for existing documents so the change stays confined to the REA registration.

The regression test writes a long personality value, runs the production setup and uninstall paths, and checks that the original line survives setup and the complete original file is restored after uninstall. The test fails on current main and passes with this change.

Validation on macOS ARM64:

Hermes and OMP client suites: 10 tests passed.
npm run check:fast: typecheck and lint passed.
npm run build:cached: passed.
Personal installation verification: REA 6.4.0 doctor reports Claude Code, Codex, Hermes, OMP and Ghidra healthy; Hermes discovers 170 tools; OMP exposes REA in its running tool catalog; a compiled ARM64 smoke target was analyzed through Ghidra.

Follow-up to #1403. This does not change configuration values or MCP registration fields.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1754 **Author:** [@zaydiscold](https://github.com/zaydiscold) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/hermes-preserve-yaml-lines` --- ### 📝 Commits (1) - [`989e0fb`](https://github.com/morluto/rea/commit/989e0fb8a8b5dc80a1ef07b4f85132dc0969fd7d) fix(setup): preserve unrelated Hermes YAML line formatting ### 📊 Changes **2 files changed** (+25 additions, -1 deletions) <details> <summary>View changed files</summary> 📝 `src/application/ClientConfigurationDocument.ts` (+2 -1) 📝 `tests/boundary/filesystem/hermesClientConfiguration.test.ts` (+23 -0) </details> ### 📄 Description When REA updates or removes its Hermes MCP entry, the YAML serializer uses its default line width and rewraps unrelated long values, including user prompts. Disable that wrapping for existing documents so the change stays confined to the REA registration. The regression test writes a long personality value, runs the production setup and uninstall paths, and checks that the original line survives setup and the complete original file is restored after uninstall. The test fails on current main and passes with this change. Validation on macOS ARM64: - Hermes and OMP client suites: 10 tests passed. - `npm run check:fast`: typecheck and lint passed. - `npm run build:cached`: passed. - Personal installation verification: REA 6.4.0 doctor reports Claude Code, Codex, Hermes, OMP and Ghidra healthy; Hermes discovers 170 tools; OMP exposes REA in its running tool catalog; a compiled ARM64 smoke target was analyzed through Ghidra. Follow-up to #1403. This does not change configuration values or MCP registration fields. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:55:08 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-10-31 01:14:16 +00:00

[PR #4795] [CLOSED] fix(ghidra): prepare ownership before the Java probe deadline #6411

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4795

No description provided.

Rows
Columns