morluto/rea

Fork 0

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

[PR #1880] [CLOSED] fix(android): restore real-lane verifier imports #4875

New issue

Closed

opened 2026-10-31 00:56:15 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:56:15 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1880
Author: @Kenmege
Created: 10/11/2026
Status: ❌ Closed

Base: main ← Head: fix/android-verifier-jadx-config

📝 Commits (1)

61ee515 fix(android): restore real-lane verifier imports

📊 Changes

2 files changed (+37 additions, -3 deletions)

View changed files

📝 scripts/verify/android/analysis.mjs (+23 -2)
📝 scripts/verify/android/windows-lifecycle.mjs (+14 -1)

📄 Description

Summary

npm run verify:android (the real JADX lane) fails on current main before any Android check runs. scripts/verify/android/analysis.mjs and windows-lifecycle.mjs import two helpers that recent source changes removed. This PR restores the verifier without changing any runtime source. No issue is linked because I found no existing issue or PR for it (searched resolveJadxConfiguration).

Problem and expected behavior

resolveJadxConfiguration was split into resolveJadxConfigurationInputs + validateJadxConfiguration in acd8d868.
hashAndroidFile was removed from AndroidTargetSnapshot in db8ccaa2.

Smallest trigger: node scripts/verify/android/analysis.mjs on main (fb94d9dd) after a build fails at ESM link time:

SyntaxError: The requested module '../../../dist/android/JadxConfiguration.js' does not provide an export named 'resolveJadxConfiguration'

After that is fixed, the same failure appears for hashAndroidFile. Expected: the real lane runs its checks.

Change and scope

Both scripts import the two new functions and compose them in a local resolveJadxConfiguration helper. This keeps the verifier's previous behavior of resolving and then validating, which matches what a new engine session does.
analysis.mjs hashes fixtures with a local streaming SHA-256 helper. It is identical to the one in scripts/fixtures/android/fetch.mjs, so no verifier-only export is added back to src.
Not included: any change to src/, contracts, or tests.

Contract and boundary impact

Semantic owner and earliest changed stage: verification scripts only
CLI and MCP/tool-catalog contract: none
Provider, bridge, target-format, or platform compatibility: none
Evidence, artifact, provenance, or reconstruction contract: none
Process execution, authorization, cleanup, or containment impact: none
Generated metadata, package, or installation impact: none (scripts/verify is not packaged runtime)

Evidence and regression coverage

Tests added or updated: none. The change is to the real-provider verifier itself.
Base reproduction or other evidence: I ran this. On base fb94d9dd the run fails with the SyntaxError above. A script that compares every dist/ named import in scripts/verify/android/*.mjs with the module's real exports reported 1 missing name after the first fix and 0 after this change.
User-visible CLI/MCP output: not applicable
Remaining proof gaps: windows-lifecycle.mjs runs only on Windows and was not run. I checked its imports against the built dist exports.

Validation performed

REA_JADX_MCP_JAR=…/jadx-headless-mcp-0.7.1-all.jar REA_ANDROID_TEST_APK=…/ApiDemos-debug.apk JAVA_HOME=<JDK 21> node scripts/verify/android/analysis.mjs: exit 0 on macOS arm64 (Node 22.23.3, OpenJDK 21.0.12.1). The fixtures came from npm run fixtures:android, and their hashes matched. The report includes cli_mcp_parity: true, original_apk_unchanged: true, apk_executed: false, cli_sigterm_cleanup: true, metadata_without_code_generation: true and stable_overload_selection: true.
npx oxfmt --check and npx oxlint on both files: clean
npm run jscpd: exit 0, with no clones reported in scripts/verify/android
The pre-commit (lint-staged) and pre-push hooks passed

Compatibility, safety, and release

Breaking changes or migration steps: none
Real Hopper/Ghidra, browser, or OS coverage: real JADX 0.7.1 on macOS arm64. Windows was not run.
Package or release metadata impact: none
Security, privacy, process, or containment review: no new process or filesystem behavior. The hashing is read-only streaming.

Review checklist

This PR addresses a concrete problem or an agreed enhancement.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1880 **Author:** [@Kenmege](https://github.com/Kenmege) **Created:** 10/11/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/android-verifier-jadx-config` --- ### 📝 Commits (1) - [`61ee515`](https://github.com/morluto/rea/commit/61ee5152e39e77555bf9274c3d8343dd6adbe6c4) fix(android): restore real-lane verifier imports ### 📊 Changes **2 files changed** (+37 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `scripts/verify/android/analysis.mjs` (+23 -2) 📝 `scripts/verify/android/windows-lifecycle.mjs` (+14 -1) </details> ### 📄 Description ## Summary `npm run verify:android` (the real JADX lane) fails on current `main` before any Android check runs. `scripts/verify/android/analysis.mjs` and `windows-lifecycle.mjs` import two helpers that recent source changes removed. This PR restores the verifier without changing any runtime source. No issue is linked because I found no existing issue or PR for it (searched `resolveJadxConfiguration`). ## Problem and expected behavior - `resolveJadxConfiguration` was split into `resolveJadxConfigurationInputs` + `validateJadxConfiguration` in acd8d868. - `hashAndroidFile` was removed from `AndroidTargetSnapshot` in db8ccaa2. Smallest trigger: `node scripts/verify/android/analysis.mjs` on `main` (fb94d9dd) after a build fails at ESM link time: ``` SyntaxError: The requested module '../../../dist/android/JadxConfiguration.js' does not provide an export named 'resolveJadxConfiguration' ``` After that is fixed, the same failure appears for `hashAndroidFile`. Expected: the real lane runs its checks. ## Change and scope - Both scripts import the two new functions and compose them in a local `resolveJadxConfiguration` helper. This keeps the verifier's previous behavior of resolving and then validating, which matches what a new engine session does. - `analysis.mjs` hashes fixtures with a local streaming SHA-256 helper. It is identical to the one in `scripts/fixtures/android/fetch.mjs`, so no verifier-only export is added back to `src`. - Not included: any change to `src/`, contracts, or tests. ## Contract and boundary impact - Semantic owner and earliest changed stage: verification scripts only - CLI and MCP/tool-catalog contract: none - Provider, bridge, target-format, or platform compatibility: none - Evidence, artifact, provenance, or reconstruction contract: none - Process execution, authorization, cleanup, or containment impact: none - Generated metadata, package, or installation impact: none (scripts/verify is not packaged runtime) ## Evidence and regression coverage - Tests added or updated: none. The change is to the real-provider verifier itself. - Base reproduction or other evidence: I ran this. On base fb94d9dd the run fails with the SyntaxError above. A script that compares every `dist/` named import in `scripts/verify/android/*.mjs` with the module's real exports reported 1 missing name after the first fix and 0 after this change. - User-visible CLI/MCP output: not applicable - Remaining proof gaps: `windows-lifecycle.mjs` runs only on Windows and was not run. I checked its imports against the built `dist` exports. ## Validation performed - `REA_JADX_MCP_JAR=…/jadx-headless-mcp-0.7.1-all.jar REA_ANDROID_TEST_APK=…/ApiDemos-debug.apk JAVA_HOME=<JDK 21> node scripts/verify/android/analysis.mjs`: exit 0 on macOS arm64 (Node 22.23.3, OpenJDK 21.0.12.1). The fixtures came from `npm run fixtures:android`, and their hashes matched. The report includes `cli_mcp_parity: true`, `original_apk_unchanged: true`, `apk_executed: false`, `cli_sigterm_cleanup: true`, `metadata_without_code_generation: true` and `stable_overload_selection: true`. - `npx oxfmt --check` and `npx oxlint` on both files: clean - `npm run jscpd`: exit 0, with no clones reported in `scripts/verify/android` - The pre-commit (lint-staged) and pre-push hooks passed ## Compatibility, safety, and release - Breaking changes or migration steps: none - Real Hopper/Ghidra, browser, or OS coverage: real JADX 0.7.1 on macOS arm64. Windows was not run. - Package or release metadata impact: none - Security, privacy, process, or containment review: no new process or filesystem behavior. The hashing is read-only streaming. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:56:15 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4875

No description provided.

Rows
Columns