[PR #1896] [CLOSED] fix: pass AbortSignal and timeout when stopSignal is provided #4886

New issue

Closed

opened 2026-10-31 00:56:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:56:25 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1896
Author: @isharak7m
Created: 10/11/2026
Status: ❌ Closed

Base: main ← Head: main

📄 Description

When both signal (AbortSignal) and stopSignal were provided to execFileOutput, the function ignored signal and timeout, passing only killSignal to execFile.

This change ensures that signal and timeout are also passed when stopSignal is provided.

The existing test in ExecFileOutput.test.ts (lines 56–58) exercises the case where both signal and stopSignal are provided.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1896 **Author:** [@isharak7m](https://github.com/isharak7m) **Created:** 10/11/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `main` --- ### 📄 Description When both signal (AbortSignal) and stopSignal were provided to execFileOutput, the function ignored signal and timeout, passing only killSignal to execFile. This change ensures that signal and timeout are also passed when stopSignal is provided. The existing test in ExecFileOutput.test.ts (lines 56–58) exercises the case where both signal and stopSignal are provided. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:56:25 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:45:07 +00:00

[PR #5794] feat(binary-ninja): add GUI MCP analysis provider #7067

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4886

No description provided.

Rows
Columns