morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #1907] [MERGED] fix(process): retain owned command cleanup diagnostics #4899

New issue

Closed

opened 2026-10-31 00:56:33 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:56:33 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/1907
Author: @N0zoM1z0
Created: 10/11/2026
Status: ✅ Merged
Merged: 10/11/2026
Merged by: @N0zoM1z0

Base: main ← Head: fix/1856-owned-command-cleanup-ledger

📝 Commits (1)

33cf4c3 fix(process): retain owned command cleanup diagnostics

📊 Changes

8 files changed (+209 additions, -29 deletions)

View changed files

📝 src/process/OwnedCommand.ts (+20 -4)
📝 src/process/ProcessOwnership.part2.test.ts (+1 -1)
📝 src/process/ProcessOwnership.test.ts (+2 -2)
📝 src/process/ProcessOwnership.ts (+18 -14)
📝 src/process/ProcessOwnership.validation.test.ts (+4 -4)
📝 src/process/ProviderProcess.ts (+16 -3)
📝 tests/boundary/process/ownedCommand.test.ts (+97 -1)
📝 tests/boundary/process/providerProcess.test.ts (+51 -0)

📄 Description

Summary

An interrupted owned command can retain cleanup ownership while losing the diagnostics explaining which member could not be verified. Preserve that verification ledger through the supervisor and command failure, and identify the observed token mismatch in its summary. Fixes #1856.

Problem and expected behavior

A source-owned parent starts a child with a different ownership token in the same process group. On cancellation or timeout, cleanup correctly refuses to signal the mixed-ownership group. Its lower result identifies the child's PID and run-token-mismatch, but the supervisor previously discarded those fields and the command returned only process tree contains an unowned or PID-reused process.

Callers should receive the actual verification failures and retained owner, without treating an ordinary token mismatch as proof of PID reuse or acquiring additional authority.

Change and scope

Name the existing failed-cleanup representation and preserve it as optional cleanupResult on incomplete supervisor results and owned-command failures, including cleanup revalidation after launcher grace. Member failures, diagnostic reasons and sweep uncertainty remain intact.
Describe token mismatches with deterministic, deduplicated PID coordinates. Existing callers retaining the summary receive useful coordinates too.
Keep the existing fail-closed signal decisions, command failure reason/output, resource identities and retryable retained supervisor. Once the fixture cooperatively exits, a subsequent verified stop settles normally.

Contract and boundary impact

Semantic owner and earliest changed stage: process ownership verification produces the summary; the supervisor retains its complete failure result rather than reducing it to text.
CLI and MCP/tool-catalog contract: no advertised schema or operation changes. Failed-cleanup summaries become more specific; the shared process helper gains additive diagnostic fields.
Provider, bridge, target-format, or platform compatibility: no protocol or target-format change. Cleanup records retain their existing semantics.
Evidence, artifact, provenance, or reconstruction contract: no Evidence format change; captured command output and original interruption reason are preserved.
Process execution, authorization, cleanup, or containment impact: no new signaling authority. Unverified members remain unsignaled and ownership remains retained until a verified stop succeeds.
Generated metadata, package, or installation impact: none.

Evidence and regression coverage

Tests added or updated: actual parent/child cancellation and timeout cases; a controlled adapter case for a failed cleanup recheck retaining both member failures and sweep uncertainty. Existing ownership assertions now expect the factual token-mismatch summary.
Base reproduction: both new real process cases fail on the base because OwnedCommandFailure.cleanupResult is absent, while the lower cleanup result contains the exact child failure. Their cooperative cleanup still completes, so the tests leave no fixture processes behind.
User-visible output: the summary identifies the failed PID coordinates; process callers can inspect cleanupResult.failures for run-token-mismatch, environment-unreadable or process-identity-unavailable, and cleanupResult.unverified for sweep uncertainty.
Remaining proof gaps: no provider-specific leak, PID reuse or successful full client-family cleanup is inferred from this fixture. The recheck's unavailable-identity observation is deliberately injected; the parent/child token mismatch is observed through the real operating-system boundary.
Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

npm run test:focused -- tests/boundary/process/ownedCommand.test.ts tests/boundary/process/providerProcess.test.ts src/process/ProcessOwnership.test.ts src/process/ProcessOwnership.part2.test.ts src/process/ProcessOwnership.part3.test.ts src/process/ProcessOwnership.validation.test.ts src/process/ProcessOwnership.identity.test.ts src/process/ProcessOwnership.observation.test.ts — 107 tests passed, one platform-conditional test skipped, eight files passed.
Final affected boundary reruns — passed after test-only type narrowing and ready-fixture PID validation.
Actual built-runtime helper on a source-owned nested-token process fixture — retained per-member diagnostics, unsignaled unresolved group and later verified settlement passed.
npm run check — passed.
npm run verify:test-discovery and git diff --check — passed.

Compatibility, safety, and release

Breaking changes or migration steps: none; cleanupResult is additive and absent when no structured failure was produced. Consumers should use typed verification reasons instead of parsing historical summary text.
Real Hopper/Ghidra, browser, or OS coverage: Linux process ownership and supervision exercised. Other operating systems and real analysis engines were not locally exercised for this change.
Package or release metadata impact: none.
Security, privacy, process, or containment review: preserve the existing token/identity checks, authority refusal and retained ownership. No ambient environment or token values are persisted. Verification ran serially under one CPU and 3 GiB; no binaries or generated outputs are committed.

Review checklist

This PR addresses a concrete problem or an agreed enhancement.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed (none changed).
User-visible CLI/MCP changes include representative output (shared failure summary described above).
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/1907 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/11/2026 **Status:** ✅ Merged **Merged:** 10/11/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `fix/1856-owned-command-cleanup-ledger` --- ### 📝 Commits (1) - [`33cf4c3`](https://github.com/morluto/rea/commit/33cf4c34ec6a0291c2ea0168a1c47e084a91eb78) fix(process): retain owned command cleanup diagnostics ### 📊 Changes **8 files changed** (+209 additions, -29 deletions) <details> <summary>View changed files</summary> 📝 `src/process/OwnedCommand.ts` (+20 -4) 📝 `src/process/ProcessOwnership.part2.test.ts` (+1 -1) 📝 `src/process/ProcessOwnership.test.ts` (+2 -2) 📝 `src/process/ProcessOwnership.ts` (+18 -14) 📝 `src/process/ProcessOwnership.validation.test.ts` (+4 -4) 📝 `src/process/ProviderProcess.ts` (+16 -3) 📝 `tests/boundary/process/ownedCommand.test.ts` (+97 -1) 📝 `tests/boundary/process/providerProcess.test.ts` (+51 -0) </details> ### 📄 Description ## Summary An interrupted owned command can retain cleanup ownership while losing the diagnostics explaining which member could not be verified. Preserve that verification ledger through the supervisor and command failure, and identify the observed token mismatch in its summary. Fixes #1856. ## Problem and expected behavior A source-owned parent starts a child with a different ownership token in the same process group. On cancellation or timeout, cleanup correctly refuses to signal the mixed-ownership group. Its lower result identifies the child's PID and `run-token-mismatch`, but the supervisor previously discarded those fields and the command returned only `process tree contains an unowned or PID-reused process`. Callers should receive the actual verification failures and retained owner, without treating an ordinary token mismatch as proof of PID reuse or acquiring additional authority. ## Change and scope - Name the existing failed-cleanup representation and preserve it as optional `cleanupResult` on incomplete supervisor results and owned-command failures, including cleanup revalidation after launcher grace. Member failures, diagnostic reasons and sweep uncertainty remain intact. - Describe token mismatches with deterministic, deduplicated PID coordinates. Existing callers retaining the summary receive useful coordinates too. - Keep the existing fail-closed signal decisions, command failure reason/output, resource identities and retryable retained supervisor. Once the fixture cooperatively exits, a subsequent verified stop settles normally. ## Contract and boundary impact - Semantic owner and earliest changed stage: process ownership verification produces the summary; the supervisor retains its complete failure result rather than reducing it to text. - CLI and MCP/tool-catalog contract: no advertised schema or operation changes. Failed-cleanup summaries become more specific; the shared process helper gains additive diagnostic fields. - Provider, bridge, target-format, or platform compatibility: no protocol or target-format change. Cleanup records retain their existing semantics. - Evidence, artifact, provenance, or reconstruction contract: no Evidence format change; captured command output and original interruption reason are preserved. - Process execution, authorization, cleanup, or containment impact: no new signaling authority. Unverified members remain unsignaled and ownership remains retained until a verified stop succeeds. - Generated metadata, package, or installation impact: none. ## Evidence and regression coverage - Tests added or updated: actual parent/child cancellation and timeout cases; a controlled adapter case for a failed cleanup recheck retaining both member failures and sweep uncertainty. Existing ownership assertions now expect the factual token-mismatch summary. - Base reproduction: both new real process cases fail on the base because `OwnedCommandFailure.cleanupResult` is absent, while the lower cleanup result contains the exact child failure. Their cooperative cleanup still completes, so the tests leave no fixture processes behind. - User-visible output: the summary identifies the failed PID coordinates; process callers can inspect `cleanupResult.failures` for `run-token-mismatch`, `environment-unreadable` or `process-identity-unavailable`, and `cleanupResult.unverified` for sweep uncertainty. - Remaining proof gaps: no provider-specific leak, PID reuse or successful full client-family cleanup is inferred from this fixture. The recheck's unavailable-identity observation is deliberately injected; the parent/child token mismatch is observed through the real operating-system boundary. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run test:focused -- tests/boundary/process/ownedCommand.test.ts tests/boundary/process/providerProcess.test.ts src/process/ProcessOwnership.test.ts src/process/ProcessOwnership.part2.test.ts src/process/ProcessOwnership.part3.test.ts src/process/ProcessOwnership.validation.test.ts src/process/ProcessOwnership.identity.test.ts src/process/ProcessOwnership.observation.test.ts` — 107 tests passed, one platform-conditional test skipped, eight files passed. - Final affected boundary reruns — passed after test-only type narrowing and ready-fixture PID validation. - Actual built-runtime helper on a source-owned nested-token process fixture — retained per-member diagnostics, unsignaled unresolved group and later verified settlement passed. - `npm run check` — passed. - `npm run verify:test-discovery` and `git diff --check` — passed. ## Compatibility, safety, and release - Breaking changes or migration steps: none; `cleanupResult` is additive and absent when no structured failure was produced. Consumers should use typed verification reasons instead of parsing historical summary text. - Real Hopper/Ghidra, browser, or OS coverage: Linux process ownership and supervision exercised. Other operating systems and real analysis engines were not locally exercised for this change. - Package or release metadata impact: none. - Security, privacy, process, or containment review: preserve the existing token/identity checks, authority refusal and retained ownership. No ambient environment or token values are persisted. Verification ran serially under one CPU and 3 GiB; no binaries or generated outputs are committed. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed (none changed). - [x] User-visible CLI/MCP changes include representative output (shared failure summary described above). - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:56:33 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:42:10 +00:00

[PR #4899] [CLOSED] fix(setup): preserve unresolved launcher identity #6668

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4899

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns