[PR #2031] [MERGED] test(javascript): consolidate module lookup regressions #4971

New issue

Closed

opened 2026-10-31 00:57:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented 2026-10-31 00:57:34 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2031
Author: @xu91102
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @morluto

Base: main ← Head: fix/esm-relative-exact-files

---

📝 Commits (4)

• 4e6a47e fix(javascript): resolve relative ESM URLs as exact files
• 48b82a9 test(javascript): merge main and retain exact ESM regressions
• 6ece0ee test(javascript): consolidate module lookup regressions
• 8f96a93 test(javascript): align module coverage with upstream controls

📊 Changes

1 file changed (+39 additions, -14 deletions)

View changed files

📝 tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts (+39 -14)

📄 Description

Summary

The separate module-lookup acceptance files repeat the compiled CLI and stdio MCP workflows already owned by JavaScriptModuleLookupCli.test.ts. Fold their useful assertions into that existing journey and give the fixture an explicit CommonJS package scope so Node controls are independent of the temporary directory's parent package.

Refs #2020, #2021 and #2022. The production loader fixes are already on main in c0904b4c1a; the query-bearing ESM and index.cjs controls are also upstream in b7f563e15f. This diff retains the additional fixture isolation, TypeScript inference and value assertions in the existing test file.

Problem and expected behavior

The original standalone CommonJS fixture fails when TMPDIR is inside an ESM package: its .js controls inherit ESM scope and return an empty module namespace instead of the expected value. The regression fixture must own its module type, preserve Node's actual success/failure behavior and avoid adding parallel workflows for the same loader rules.

Change and scope

• Reuse the upstream query-bearing ESM and index.cjs controls without duplicate fixtures; extend the existing CLI/MCP matrix with a rejected extensionless .mjs candidate, a valid index.js directory and .mts/.cts emitted-source counterpart inference.
• Assert real Node return values, including the empty-main fallback's value 42, while retaining the existing rejection and package-ancestry assertions.
• Set the fixture root's package type to CommonJS. No additional test file or parameterized workflow is added.

Contract and boundary impact

• Semantic owner and earliest changed stage: existing JavaScript module-lookup acceptance fixture; production resolution is unchanged.
• CLI and MCP/tool-catalog contract: unchanged; both compiled public surfaces are exercised.
• Provider, bridge, target-format, or platform compatibility: unchanged.
• Evidence, artifact, provenance, or reconstruction contract: preserve resolved paths, explicit lookup failures and native Node controls.
• Process execution, authorization, cleanup, or containment impact: existing fixture-owned temporary-directory cleanup and CLI/MCP harness retained.
• Generated metadata, package, or installation impact: none.

Evidence and regression coverage

• Tests updated: JavaScriptModuleLookupCli.test.ts.

• Base evidence: the previous standalone CommonJS test produced 1 failed / 1 passed case with TMPDIR inside the ESM checkout. The consolidated fixture passed both cases in that same parent package scope.

• User-visible CLI/MCP output: query-bearing exact paths and TypeScript source counterparts resolve; unsupported CommonJS extension/index probes remain unresolved.

• Remaining proof gaps: TypeScript cases assert REA's static source-counterpart inference; they do not compile or execute those TypeScript fixtures. Full deterministic CI and other operating systems are pending.

• Observed, derived, and inferred claims remain distinguishable.

• Artifact identity, source provenance, and failed attempts remain preserved.

• Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Executed with Node 24.18.0 / npm 11.16.0 on macOS arm64:

• npm run test:focused -- tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts src/application/javascript/JavaScriptArtifactPathResolution.test.ts tests/boundary/filesystem/javascript-applications/javascriptApplicationTypeScript.test.ts — 120 tests / 3 files passed.
• npm run test:focused -- tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts, with fixture TMPDIR inside the ESM checkout — 2 tests passed; owned temporary directory cleaned up.
• npm run check — all 6 tasks and architecture guards passed; 844 lint warnings, 0 errors.
• npm run verify:test-discovery — 909 test files discovered exactly once.
• Independent Standards and Spec review of the final diff — passed.

Compatibility, safety, and release

• Breaking changes or migration steps: none.
• Real Hopper/Ghidra, browser, or OS coverage: real local Node, compiled CLI and stdio MCP; no browser/native provider or cross-platform run.
• Package or release metadata impact: none.
• Security, privacy, process, or containment review: only existing test fixtures and controls change; no new external provider or production authorization behavior.

Review checklist

• This PR addresses a concrete problem or an agreed enhancement.
• The PR has one focused outcome and the title follows type(scope): outcome.
• Related issue is linked.
• Tests cover changed observable behavior and meaningful failure paths.
• Owning docs, contracts, and generated metadata are updated where needed (no production contract changes).
• User-visible CLI/MCP assertions cover representative resolved and unresolved paths.
• I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

---

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2031 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/esm-relative-exact-files` --- ### 📝 Commits (4) - [`4e6a47e`](https://github.com/morluto/rea/commit/4e6a47e57a538e02194279f7fd67ed48884ad0d2) fix(javascript): resolve relative ESM URLs as exact files - [`48b82a9`](https://github.com/morluto/rea/commit/48b82a97266683b948c60c7c7b2491c05f62f037) test(javascript): merge main and retain exact ESM regressions - [`6ece0ee`](https://github.com/morluto/rea/commit/6ece0eea4fb0c408c530dd4555b3d4397caa69d6) test(javascript): consolidate module lookup regressions - [`8f96a93`](https://github.com/morluto/rea/commit/8f96a93cdd70b6add4b1af34351f866029189f65) test(javascript): align module coverage with upstream controls ### 📊 Changes **1 file changed** (+39 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts` (+39 -14) </details> ### 📄 Description ## Summary The separate module-lookup acceptance files repeat the compiled CLI and stdio MCP workflows already owned by `JavaScriptModuleLookupCli.test.ts`. Fold their useful assertions into that existing journey and give the fixture an explicit CommonJS package scope so Node controls are independent of the temporary directory's parent package. Refs #2020, #2021 and #2022. The production loader fixes are already on main in c0904b4c1aabfccf2f0ab12f44960a0a1fbbbfae; the query-bearing ESM and `index.cjs` controls are also upstream in b7f563e15f854061dc1507896181b7b24ac3b5f0. This diff retains the additional fixture isolation, TypeScript inference and value assertions in the existing test file. ## Problem and expected behavior The original standalone CommonJS fixture fails when `TMPDIR` is inside an ESM package: its `.js` controls inherit ESM scope and return an empty module namespace instead of the expected value. The regression fixture must own its module type, preserve Node's actual success/failure behavior and avoid adding parallel workflows for the same loader rules. ## Change and scope - Reuse the upstream query-bearing ESM and `index.cjs` controls without duplicate fixtures; extend the existing CLI/MCP matrix with a rejected extensionless `.mjs` candidate, a valid `index.js` directory and `.mts`/`.cts` emitted-source counterpart inference. - Assert real Node return values, including the empty-main fallback's value 42, while retaining the existing rejection and package-ancestry assertions. - Set the fixture root's package type to CommonJS. No additional test file or parameterized workflow is added. ## Contract and boundary impact - Semantic owner and earliest changed stage: existing JavaScript module-lookup acceptance fixture; production resolution is unchanged. - CLI and MCP/tool-catalog contract: unchanged; both compiled public surfaces are exercised. - Provider, bridge, target-format, or platform compatibility: unchanged. - Evidence, artifact, provenance, or reconstruction contract: preserve resolved paths, explicit lookup failures and native Node controls. - Process execution, authorization, cleanup, or containment impact: existing fixture-owned temporary-directory cleanup and CLI/MCP harness retained. - Generated metadata, package, or installation impact: none. ## Evidence and regression coverage - Tests updated: `JavaScriptModuleLookupCli.test.ts`. - Base evidence: the previous standalone CommonJS test produced 1 failed / 1 passed case with `TMPDIR` inside the ESM checkout. The consolidated fixture passed both cases in that same parent package scope. - User-visible CLI/MCP output: query-bearing exact paths and TypeScript source counterparts resolve; unsupported CommonJS extension/index probes remain unresolved. - Remaining proof gaps: TypeScript cases assert REA's static source-counterpart inference; they do not compile or execute those TypeScript fixtures. Full deterministic CI and other operating systems are pending. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Executed with Node 24.18.0 / npm 11.16.0 on macOS arm64: - `npm run test:focused -- tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts src/application/javascript/JavaScriptArtifactPathResolution.test.ts tests/boundary/filesystem/javascript-applications/javascriptApplicationTypeScript.test.ts` — 120 tests / 3 files passed. - `npm run test:focused -- tests/acceptance/applications/JavaScriptModuleLookupCli.test.ts`, with fixture `TMPDIR` inside the ESM checkout — 2 tests passed; owned temporary directory cleaned up. - `npm run check` — all 6 tasks and architecture guards passed; 844 lint warnings, 0 errors. - `npm run verify:test-discovery` — 909 test files discovered exactly once. - Independent Standards and Spec review of the final diff — passed. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: real local Node, compiled CLI and stdio MCP; no browser/native provider or cross-platform run. - Package or release metadata impact: none. - Security, privacy, process, or containment review: only existing test fixtures and controls change; no new external provider or production authorization behavior. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed (no production contract changes). - [x] User-visible CLI/MCP assertions cover representative resolved and unresolved paths. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- _{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

bsakaguchi 2026-10-31 00:57:34 +00:00

• closed this issue
• added the
  pull-request
  label

bsakaguchi referenced this issue 2026-11-01 21:10:54 +00:00

[GH-ISSUE #3795] [Tracker] Open documentation issues and pull requests (October 2026) #1468

bsakaguchi referenced this issue 2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue 2026-11-01 21:42:25 +00:00

[PR #4971] docs(i18n): add Azerbaijani README and sync Turkish edition #6704

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels   

area: bridge

  

area: bridge

  

area: build

  

area: build

  

area: build

  

area: cli

  

area: domain

  

area: evidence

  

area: mcp

  

area: native

  

area: providers

  

area: runtime

  

area: server

  

area: setup

  

area: tests

  

bug

  

design

  

documentation

  

enhancement

  

enhancement

  

enhancement

  

experiment

  

help wanted

  

i18n

  

invalid

  

P0: critical

  

P1: high

  

P2: medium

  

P2: medium

  

P2: medium

  

P3: low

  

performance

  

provider-request

  

pull-request

Mirrored from GitHub Pull Request

  

question

  

roadmap

  

triage

No labels

area: bridge

area: bridge

area: build

area: build

area: build

area: cli

area: domain

area: evidence

area: mcp

area: native

area: providers

area: runtime

area: server

area: setup

area: tests

bug

design

documentation

enhancement

enhancement

enhancement

experiment

help wanted

i18n

invalid

P0: critical

P1: high

P2: medium

P2: medium

P2: medium

P3: low

performance

provider-request

pull-request

question

roadmap

triage

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4971

No description provided.