[PR #2032] [CLOSED] test(javascript): verify CommonJS extension lookup through CLI and MCP #4972

New issue

Closed

opened 2026-10-31 00:57:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:57:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2032
Author: @xu91102
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: fix/commonjs-extension-candidates

📝 Commits (2)

1ba62e9 fix(javascript): restrict CommonJS extension lookup to Node suffixes
8b70853 test(javascript): merge main and retain CommonJS lookup regressions

📊 Changes

1 file changed (+135 additions, -0 deletions)

View changed files

➕ tests/acceptance/applications/commonJsExtensionCli.test.ts (+135 -0)

📄 Description

Disposition

Closing this duplicate acceptance PR in favor of #2031. Refs #2022.

The production CommonJS extension-candidate fix is already on main in c0904b4c1a; the distinct index.cjs rejection control is also upstream in b7f563e15f. The remaining standalone matrix overlaps the existing JavaScriptModuleLookupCli.test.ts journey.

The additional .mjs rejection, valid index.js control and .cts source-counterpart inference now extend the existing matrix in #2031. It reuses the upstream directory control and explicitly owns a CommonJS package scope: the old fixture's inherited-ESM failure was reproduced, and both consolidated public cases passed with TMPDIR inside an ESM package. TypeScript cases check static inference, not compiled TypeScript execution.

The replacement's final diff passed 120 related tests, npm run check, test discovery and independent Standards/Spec review. The original production reproduction remains documented in #2022.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2032 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/commonjs-extension-candidates` --- ### 📝 Commits (2) - [`1ba62e9`](https://github.com/morluto/rea/commit/1ba62e9bc9d80a58042906880d7a823824456184) fix(javascript): restrict CommonJS extension lookup to Node suffixes - [`8b70853`](https://github.com/morluto/rea/commit/8b70853b2a84c06c8069a25111c18f5879e42def) test(javascript): merge main and retain CommonJS lookup regressions ### 📊 Changes **1 file changed** (+135 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `tests/acceptance/applications/commonJsExtensionCli.test.ts` (+135 -0) </details> ### 📄 Description ## Disposition Closing this duplicate acceptance PR in favor of #2031. Refs #2022. The production CommonJS extension-candidate fix is already on main in c0904b4c1aabfccf2f0ab12f44960a0a1fbbbfae; the distinct `index.cjs` rejection control is also upstream in b7f563e15f854061dc1507896181b7b24ac3b5f0. The remaining standalone matrix overlaps the existing `JavaScriptModuleLookupCli.test.ts` journey. The additional `.mjs` rejection, valid `index.js` control and `.cts` source-counterpart inference now extend the existing matrix in #2031. It reuses the upstream directory control and explicitly owns a CommonJS package scope: the old fixture's inherited-ESM failure was reproduced, and both consolidated public cases passed with `TMPDIR` inside an ESM package. TypeScript cases check static inference, not compiled TypeScript execution. The replacement's final diff passed 120 related tests, `npm run check`, test discovery and independent Standards/Spec review. The original production reproduction remains documented in #2022. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:57:34 +00:00