[PR #2028] [CLOSED] test(javascript): verify empty package main fallback through CLI and MCP #4975

New issue

Closed

opened 2026-10-31 00:57:34 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:57:34 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2028
Author: @xu91102
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: fix/legacy-empty-main

📝 Commits (2)

d8c8f36 fix(javascript): use index fallback for empty package main
021f5cc test(javascript): merge main and retain empty-main regressions

📊 Changes

1 file changed (+49 additions, -0 deletions)

View changed files

➕ tests/acceptance/applications/packageEmptyMainCli.test.ts (+49 -0)

📄 Description

Disposition

Closing this duplicate acceptance PR in favor of #2031. Refs #2020.

The production empty-main fallback fix is already on main in c0904b4c1a. The remaining standalone workflow duplicates JavaScriptModuleLookupCli.test.ts, which already covers import and require through compiled CLI and stdio MCP.

The useful native Node value assertion (both loaders return 42) is now included in that existing journey in #2031, without another pair of full workflows. The replacement's final diff passed 120 related tests, both public cases with TMPDIR inside an ESM package, npm run check, test discovery and independent Standards/Spec review. The original reproduction remains documented in #2020.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2028 **Author:** [@xu91102](https://github.com/xu91102) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/legacy-empty-main` --- ### 📝 Commits (2) - [`d8c8f36`](https://github.com/morluto/rea/commit/d8c8f36b562a13ee93ce96c5e54f09260956b100) fix(javascript): use index fallback for empty package main - [`021f5cc`](https://github.com/morluto/rea/commit/021f5cc6efa950db6166d443d7ae85fef5905b7f) test(javascript): merge main and retain empty-main regressions ### 📊 Changes **1 file changed** (+49 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `tests/acceptance/applications/packageEmptyMainCli.test.ts` (+49 -0) </details> ### 📄 Description ## Disposition Closing this duplicate acceptance PR in favor of #2031. Refs #2020. The production empty-main fallback fix is already on main in c0904b4c1aabfccf2f0ab12f44960a0a1fbbbfae. The remaining standalone workflow duplicates `JavaScriptModuleLookupCli.test.ts`, which already covers import and require through compiled CLI and stdio MCP. The useful native Node value assertion (both loaders return 42) is now included in that existing journey in #2031, without another pair of full workflows. The replacement's final diff passed 120 related tests, both public cases with `TMPDIR` inside an ESM package, `npm run check`, test discovery and independent Standards/Spec review. The original reproduction remains documented in #2020. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:57:34 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:42:26 +00:00

[PR #4975] [MERGED] feat(environment): serve an environment manifest as a replay environment #6707

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4975

No description provided.

Rows
Columns