[PR #2055] [MERGED] test(process): preserve terminal deadline expiry regression #4994

New issue

Closed

opened 2026-10-31 00:57:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:57:47 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2055
Author: @Akashmdshetty
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/import-map-help-descriptions

📝 Commits (7)

2089faa fix(cli): preserve import-map option descriptions
a6ba7ba chore(ci): sync current main verification fixes
f09af4e fix(process): report no remaining time after a provider deadline fires
8f27913 chore: merge pinned main and preserve deadline regression coverage
90a673c test(process): keep terminal deadline expiry sticky
32708c3 fix: refresh import map help PR with main
e372387 chore: refresh with latest main

📊 Changes

2 files changed (+8 additions, -4 deletions)

View changed files

📝 src/process/ProviderDeadline.test.ts (+6 -3)
📝 src/process/ProviderDeadline.ts (+2 -1)

📄 Description

Summary

Strengthen the provider startup deadline regression: after terminal expiry, move the mocked monotonic clock below the deadline and verify that remainingMs() stays zero.
Clarify the existing terminal-timeout guard comment. Runtime behavior is unchanged.

The original import-map help fix is already present in the base branch; it is no longer part of this PR's diff.

Validation

npm run test:focused -- src/process/ProviderDeadline.test.ts — all 10 tests passed with Node 24.18.0 and npm 11.16.0.
Mutation check: temporarily removing the terminal-timeout guard makes the strengthened regression fail (remainingMs() returns 1 instead of 0); the guard was restored and the worktree is clean.
Confirmed that src/cli/webModuleCommands.ts matches the base branch byte for byte.

Validation covers the shared deadline owner. No real-provider verification was run for this test/comment change.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2055 **Author:** [@Akashmdshetty](https://github.com/Akashmdshetty) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/import-map-help-descriptions` --- ### 📝 Commits (7) - [`2089faa`](https://github.com/morluto/rea/commit/2089faa9ec551dc43817264ecfe0f6e0e675174e) fix(cli): preserve import-map option descriptions - [`a6ba7ba`](https://github.com/morluto/rea/commit/a6ba7bac757bdf6bb1f7e1a224dfef4a969e8af9) chore(ci): sync current main verification fixes - [`f09af4e`](https://github.com/morluto/rea/commit/f09af4e8a57a9921bd9ee982f763babbcfec613b) fix(process): report no remaining time after a provider deadline fires - [`8f27913`](https://github.com/morluto/rea/commit/8f2791319154da69742ec770a05b15dad4141b5d) chore: merge pinned main and preserve deadline regression coverage - [`90a673c`](https://github.com/morluto/rea/commit/90a673cf0959802169752ad66ec4f0692d3d65a4) test(process): keep terminal deadline expiry sticky - [`32708c3`](https://github.com/morluto/rea/commit/32708c3a4a164a63ac4101e285aaef29e5c57c68) fix: refresh import map help PR with main - [`e372387`](https://github.com/morluto/rea/commit/e372387ce5e2e57783e8978fc5074cc82225667e) chore: refresh with latest main ### 📊 Changes **2 files changed** (+8 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `src/process/ProviderDeadline.test.ts` (+6 -3) 📝 `src/process/ProviderDeadline.ts` (+2 -1) </details> ### 📄 Description ## Summary - Strengthen the provider startup deadline regression: after terminal expiry, move the mocked monotonic clock below the deadline and verify that `remainingMs()` stays zero. - Clarify the existing terminal-timeout guard comment. Runtime behavior is unchanged. The original import-map help fix is already present in the base branch; it is no longer part of this PR's diff. ## Validation - `npm run test:focused -- src/process/ProviderDeadline.test.ts` — all 10 tests passed with Node 24.18.0 and npm 11.16.0. - Mutation check: temporarily removing the terminal-timeout guard makes the strengthened regression fail (`remainingMs()` returns 1 instead of 0); the guard was restored and the worktree is clean. - Confirmed that `src/cli/webModuleCommands.ts` matches the base branch byte for byte. Validation covers the shared deadline owner. No real-provider verification was run for this test/comment change. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:57:47 +00:00