morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #2059] [MERGED] fix(artifacts): describe ZIP non-entry coverage accurately #4995

New issue

Closed

opened 2026-10-31 00:57:47 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:57:47 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2059
Author: @1052326311
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/zip-non-entry-coverage

📝 Commits (9)

be2bc68 fix(artifacts): describe ZIP non-entry coverage accurately
7940226 fix(artifacts): preserve ZIP scope across retained evidence
f81d79d fix(process): report no remaining time after a provider deadline fires
0dbf5da chore: merge captured main into PR 2059
9e43115 style: format comparison and IDA sources
cf910e5 chore: merge main into PR #2059
f07ce2b Merge commit '8fef2aa64e' into codex/ci-wave3-2059
72e92e7 Merge branch 'main' into fix/zip-non-entry-coverage
7726970 fix(artifacts): reconcile ZIP inventory coverage with main

📊 Changes

5 files changed (+103 additions, -9 deletions)

View changed files

📝 src/artifacts/inventory/reader.ts (+2 -2)
📝 src/domain/artifactInventoryEvidence.ts (+2 -2)
📝 src/domain/zipPackageFormat.ts (+9 -3)
📝 tests/boundary/filesystem/artifactComparison.test.ts (+88 -0)
📝 tests/boundary/filesystem/harmony/application.test.ts (+2 -2)

📄 Description

Summary

Correct the ZIP inventory explanation that places an APK Signing Block after the central directory. The block is immediately before it; a ZIP comment follows the directory. Preserve comparisons against previously retained Evidence carrying the old explanation.

Problem and expected behavior

inspect-artifact package.apk --format json currently emits:

Bytes after the central directory, including an APK Signing Block or a ZIP comment, are not occurrences.

This misstates the APK Signing Block layout. Inventory enumerates central-directory entries, not all non-entry bytes on either side of the directory. This was found while inspecting the current contract; there is no separate issue.

Change and scope

The inventory now says:

Non-entry bytes, including an APK Signing Block before the central directory or a ZIP comment after it, are not occurrences.

Rename the owning constant to avoid describing all non-entry bytes as a tail. Keep recognition of the exact historical wording beside the current wording in zipPackageFormat, so previously retained inventories remain comparable. Other limitations still indicate unknown coverage. No new archive parser or signature-verification capability is introduced.

Contract and boundary impact

Semantic owner and earliest changed stage: ZIP inventory scope description; artifact comparison consumes its compatibility classifier.
CLI and MCP/tool-catalog contract: corrected inventory limitation text; no schema or tool changes.
Provider, bridge, target-format, or platform compatibility: ZIP-backed formats share the corrected text; no engine/bridge changes.
Evidence, artifact, provenance, or reconstruction contract: old Evidence remains untouched and accepted; root hashes still detect non-entry byte changes.
Process execution, authorization, cleanup, or containment impact: none.
Generated metadata, package, or installation impact: none; generated checks pass and outputs remain ignored.

Evidence and regression coverage

A real ZIP fixture receives APK Signing Block framing immediately before its central directory. Only the opaque padding pair changes between two files. Inventory retains the same entry, and comparison reports the root content change without claiming unknown entry coverage.
The regression checks current-versus-historical scope descriptions and an unrelated read limitation that must remain unknown.
Restoring all three changed production files to base 3bdc8730bd98e073522bcb8ba86527be402c0cbe makes this regression fail at the emitted explanation (5 existing tests pass). Restoring the fix passes all 6 tests.
A compiled inspect-artifact CLI smoke against a local ZIP exits 0 and returns the corrected text.
The fixture is structural, not a cryptographically signed APK; signature verification is not claimed. No separate live MCP or native-engine run.

For evidence-bearing changes:

Observed, derived, and inferred claims remain distinguishable.
Artifact identity, source provenance, and failed attempts remain preserved.
Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

Node 24.18.0 / npm 11.16.0, macOS arm64:

npm run test:focused -- tests/boundary/filesystem/artifactComparison.test.ts tests/boundary/filesystem/artifactComparisonSummary.test.ts tests/boundary/filesystem/android/application.test.ts tests/boundary/filesystem/harmony/application.test.ts — 32 tests passed.
npm run check — passed (lint reports warnings, zero errors).
npm run docs:check — passed.
npm run verify:test-discovery — all 912 test files discovered exactly once.
node scripts/rea.mjs inspect-artifact <local-fixture.zip> --format json — passed; corrected output verified.
git diff --check — passed.

Compatibility, safety, and release

Breaking changes or migration steps: none. Historical limitation wording is recognized without rewriting retained Evidence.
Real Hopper/Ghidra, browser, or OS coverage: not applicable to this static ZIP inventory change; local filesystem/CLI exercised on macOS.
Package or release metadata impact: none.
Security, privacy, process, or containment review: no execution, trust, signature, or containment authority changed.

Review checklist

This PR addresses a concrete problem or an agreed enhancement.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

AI-assisted with Codex.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2059 **Author:** [@1052326311](https://github.com/1052326311) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/zip-non-entry-coverage` --- ### 📝 Commits (9) - [`be2bc68`](https://github.com/morluto/rea/commit/be2bc6828b61e5e648931afe18b94786fa25cdff) fix(artifacts): describe ZIP non-entry coverage accurately - [`7940226`](https://github.com/morluto/rea/commit/794022690b9d82514f54e2ec0063fcc6d3f3fb6f) fix(artifacts): preserve ZIP scope across retained evidence - [`f81d79d`](https://github.com/morluto/rea/commit/f81d79d14d89820baedfda103a4ecee4637b3fb1) fix(process): report no remaining time after a provider deadline fires - [`0dbf5da`](https://github.com/morluto/rea/commit/0dbf5dab65cb455c3f152a27b51e9d3d1adbac5e) chore: merge captured main into PR 2059 - [`9e43115`](https://github.com/morluto/rea/commit/9e43115ccb891268e67af5d0d8142a3122471516) style: format comparison and IDA sources - [`cf910e5`](https://github.com/morluto/rea/commit/cf910e53d329cf3bc371de9bfd82678a726cad56) chore: merge main into PR #2059 - [`f07ce2b`](https://github.com/morluto/rea/commit/f07ce2bf468da8ea5397ede09d2ec10cbd6b4b41) Merge commit '8fef2aa64ec1ee742e8b70b825938d30a0ea7319' into codex/ci-wave3-2059 - [`72e92e7`](https://github.com/morluto/rea/commit/72e92e79e5f2a5911890958fbefa867da2378c20) Merge branch 'main' into fix/zip-non-entry-coverage - [`7726970`](https://github.com/morluto/rea/commit/7726970b2a3a8b8072f4c2c22d39ce7798f03ae2) fix(artifacts): reconcile ZIP inventory coverage with main ### 📊 Changes **5 files changed** (+103 additions, -9 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/inventory/reader.ts` (+2 -2) 📝 `src/domain/artifactInventoryEvidence.ts` (+2 -2) 📝 `src/domain/zipPackageFormat.ts` (+9 -3) 📝 `tests/boundary/filesystem/artifactComparison.test.ts` (+88 -0) 📝 `tests/boundary/filesystem/harmony/application.test.ts` (+2 -2) </details> ### 📄 Description ## Summary Correct the ZIP inventory explanation that places an APK Signing Block after the central directory. The block is immediately **before** it; a ZIP comment follows the directory. Preserve comparisons against previously retained Evidence carrying the old explanation. ## Problem and expected behavior `inspect-artifact package.apk --format json` currently emits: > Bytes after the central directory, including an APK Signing Block or a ZIP comment, are not occurrences. This misstates the [APK Signing Block layout](https://source.android.com/docs/security/features/apksigning/v2#apk-signing-block). Inventory enumerates central-directory entries, not all non-entry bytes on either side of the directory. This was found while inspecting the current contract; there is no separate issue. ## Change and scope The inventory now says: > Non-entry bytes, including an APK Signing Block before the central directory or a ZIP comment after it, are not occurrences. Rename the owning constant to avoid describing all non-entry bytes as a tail. Keep recognition of the exact historical wording beside the current wording in `zipPackageFormat`, so previously retained inventories remain comparable. Other limitations still indicate unknown coverage. No new archive parser or signature-verification capability is introduced. ## Contract and boundary impact - Semantic owner and earliest changed stage: ZIP inventory scope description; artifact comparison consumes its compatibility classifier. - CLI and MCP/tool-catalog contract: corrected inventory limitation text; no schema or tool changes. - Provider, bridge, target-format, or platform compatibility: ZIP-backed formats share the corrected text; no engine/bridge changes. - Evidence, artifact, provenance, or reconstruction contract: old Evidence remains untouched and accepted; root hashes still detect non-entry byte changes. - Process execution, authorization, cleanup, or containment impact: none. - Generated metadata, package, or installation impact: none; generated checks pass and outputs remain ignored. ## Evidence and regression coverage - A real ZIP fixture receives APK Signing Block framing immediately before its central directory. Only the opaque padding pair changes between two files. Inventory retains the same entry, and comparison reports the root content change without claiming unknown entry coverage. - The regression checks current-versus-historical scope descriptions and an unrelated read limitation that must remain unknown. - Restoring all three changed production files to base `3bdc8730bd98e073522bcb8ba86527be402c0cbe` makes this regression fail at the emitted explanation (5 existing tests pass). Restoring the fix passes all 6 tests. - A compiled `inspect-artifact` CLI smoke against a local ZIP exits 0 and returns the corrected text. - The fixture is structural, not a cryptographically signed APK; signature verification is not claimed. No separate live MCP or native-engine run. For evidence-bearing changes: - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed Node 24.18.0 / npm 11.16.0, macOS arm64: - `npm run test:focused -- tests/boundary/filesystem/artifactComparison.test.ts tests/boundary/filesystem/artifactComparisonSummary.test.ts tests/boundary/filesystem/android/application.test.ts tests/boundary/filesystem/harmony/application.test.ts` — 32 tests passed. - `npm run check` — passed (lint reports warnings, zero errors). - `npm run docs:check` — passed. - `npm run verify:test-discovery` — all 912 test files discovered exactly once. - `node scripts/rea.mjs inspect-artifact <local-fixture.zip> --format json` — passed; corrected output verified. - `git diff --check` — passed. ## Compatibility, safety, and release - Breaking changes or migration steps: none. Historical limitation wording is recognized without rewriting retained Evidence. - Real Hopper/Ghidra, browser, or OS coverage: not applicable to this static ZIP inventory change; local filesystem/CLI exercised on macOS. - Package or release metadata impact: none. - Security, privacy, process, or containment review: no execution, trust, signature, or containment authority changed. ## Review checklist - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. AI-assisted with Codex. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:57:47 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:11:07 +00:00

[GH-ISSUE #5654] [Tracker] Open PRs that can't merge yet: conflicts and red CI (October 2026) #3425

bsakaguchi referenced this issue

2026-11-01 21:42:31 +00:00

[PR #4995] fix(browser): reclaim scenario profiles whose owner is gone #6717

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#4995

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns