[PR #2073] [MERGED] fix(setup): separate host support and stop skill checks after drift #5005

New issue

Closed

opened 2026-10-31 00:57:54 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:57:54 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2073
Author: @txiki739
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/host-support-vs-hopper-installer

📝 Commits (3)

dc4115e fix(host): separate REA host support from Hopper installer targets
46fa0d9 fix(setup): stop skill checks after first drift
7f5e029 fix(setup): decode quoted os-release identities before host classification

📊 Changes

13 files changed (+156 additions, -59 deletions)

View changed files

📝 docs/installation.md (+6 -3)
📝 src/application/Doctor.test.ts (+32 -8)
📝 src/application/DoctorDiagnostics.ts (+3 -3)
📝 src/application/LinuxHopper.test.ts (+31 -6)
📝 src/application/LinuxHopper.ts (+31 -12)
📝 src/application/Setup.configuration.test.ts (+2 -2)
📝 src/application/Setup.planning.test.ts (+3 -3)
📝 src/application/Setup.recovery.test.ts (+2 -2)
📝 src/application/SetupHost.ts (+2 -1)
📝 src/application/SetupPlan.ts (+2 -1)
📝 src/application/SetupSkill.ts (+40 -16)
📝 src/ghidra/GhidraDoctor.test.ts (+1 -1)
📝 tests/boundary/filesystem/setupSkillCleanupOwnership.test.ts (+1 -1)

📄 Description

Host support now follows recognized apt, dnf, and pacman families independently of the narrower tested Hopper installer list. The os-release parser also decodes single-quoted identities before either decision, so valid Debian-derived hosts are classified consistently.

Setup skill inspection now stops at the first managed-file drift rather than probing later files and destinations. This preserves the observed drift as the determining setup result and avoids unrelated later read/cleanup failures replacing it; the existing recovery and cleanup-ownership cases remain in the branch.

Validation for this revision: source inspection and git diff --check. Tests, builds, CI reruns, and real-provider qualification were skipped at the explicit user request. Earlier contributor verification is not a qualification of this revision.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2073 **Author:** [@txiki739](https://github.com/txiki739) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/host-support-vs-hopper-installer` --- ### 📝 Commits (3) - [`dc4115e`](https://github.com/morluto/rea/commit/dc4115e5f627f7d01628616035ea151ef65ff160) fix(host): separate REA host support from Hopper installer targets - [`46fa0d9`](https://github.com/morluto/rea/commit/46fa0d982d16da0fe979d601f2bf447622cc31e3) fix(setup): stop skill checks after first drift - [`7f5e029`](https://github.com/morluto/rea/commit/7f5e029337969ec1308123600172bc63a32abdbb) fix(setup): decode quoted os-release identities before host classification ### 📊 Changes **13 files changed** (+156 additions, -59 deletions) <details> <summary>View changed files</summary> 📝 `docs/installation.md` (+6 -3) 📝 `src/application/Doctor.test.ts` (+32 -8) 📝 `src/application/DoctorDiagnostics.ts` (+3 -3) 📝 `src/application/LinuxHopper.test.ts` (+31 -6) 📝 `src/application/LinuxHopper.ts` (+31 -12) 📝 `src/application/Setup.configuration.test.ts` (+2 -2) 📝 `src/application/Setup.planning.test.ts` (+3 -3) 📝 `src/application/Setup.recovery.test.ts` (+2 -2) 📝 `src/application/SetupHost.ts` (+2 -1) 📝 `src/application/SetupPlan.ts` (+2 -1) 📝 `src/application/SetupSkill.ts` (+40 -16) 📝 `src/ghidra/GhidraDoctor.test.ts` (+1 -1) 📝 `tests/boundary/filesystem/setupSkillCleanupOwnership.test.ts` (+1 -1) </details> ### 📄 Description Host support now follows recognized apt, dnf, and pacman families independently of the narrower tested Hopper installer list. The os-release parser also decodes single-quoted identities before either decision, so valid Debian-derived hosts are classified consistently. Setup skill inspection now stops at the first managed-file drift rather than probing later files and destinations. This preserves the observed drift as the determining setup result and avoids unrelated later read/cleanup failures replacing it; the existing recovery and cleanup-ownership cases remain in the branch. Validation for this revision: source inspection and git diff --check. Tests, builds, CI reruns, and real-provider qualification were skipped at the explicit user request. Earlier contributor verification is not a qualification of this revision. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:57:54 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:42:36 +00:00

[PR #5005] [CLOSED] docs(jeb): qualify JEB Linux CE launch and native method references (#4996) #6725

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5005

No description provided.

Rows
Columns