[PR #2100] [MERGED] fix(targets): compare the Info.plist bplist prefix without ASCII folding #5026

New issue

Closed

opened 2026-10-31 00:58:55 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 00:58:55 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2100
Author: @fisforfaheem
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/compare-app-plist-prefix-without-ascii-folding

📝 Commits (3)

8e700d8 fix(targets): compare the Info.plist bplist prefix without ASCII folding
218e95a fix(targets): satisfy the strict index check in the plist prefix test
e13b003 fix(targets): reconcile plist prefix validation and fixture cleanup

📊 Changes

1 file changed (+34 additions, -0 deletions)

View changed files

➕ src/application/AppBundleExecutable.test.ts (+34 -0)

📄 Description

Summary

The app-bundle resolver treated the first six Info.plist bytes as bplist through Buffer.toString("ascii"), which drops the high bit.
Compare those bytes with Buffer.equals, so only a real binary-plist prefix is sent to the binary decoder. This is the bundle-prefix counterpart of #2069.

Test plan

npm run test:focused -- src/application/AppBundleExecutable.test.ts
Pre-push typecheck and lint

Made with Cursor

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2100 **Author:** [@fisforfaheem](https://github.com/fisforfaheem) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/compare-app-plist-prefix-without-ascii-folding` --- ### 📝 Commits (3) - [`8e700d8`](https://github.com/morluto/rea/commit/8e700d836840327b386e6a7a79e8c2dbf92b0792) fix(targets): compare the Info.plist bplist prefix without ASCII folding - [`218e95a`](https://github.com/morluto/rea/commit/218e95a26c23536481496456d4e854d1a3cec524) fix(targets): satisfy the strict index check in the plist prefix test - [`e13b003`](https://github.com/morluto/rea/commit/e13b0031a677a91783ddcb6e0b31d39495627268) fix(targets): reconcile plist prefix validation and fixture cleanup ### 📊 Changes **1 file changed** (+34 additions, -0 deletions) <details> <summary>View changed files</summary> ➕ `src/application/AppBundleExecutable.test.ts` (+34 -0) </details> ### 📄 Description ## Summary - The app-bundle resolver treated the first six `Info.plist` bytes as `bplist` through `Buffer.toString("ascii")`, which drops the high bit. - Compare those bytes with `Buffer.equals`, so only a real binary-plist prefix is sent to the binary decoder. This is the bundle-prefix counterpart of #2069. ## Test plan - [x] `npm run test:focused -- src/application/AppBundleExecutable.test.ts` - [x] Pre-push `typecheck` and `lint` Made with [Cursor](https://cursor.com) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 00:58:55 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5026

No description provided.

Rows
Columns