[PR #2118] [MERGED] fix(setup): name each skill directory in the uninstall summary #5043

New issue

Closed

opened 2026-10-31 01:00:17 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:00:17 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2118
Author: @kaoru0822-kitauji
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/12/2026
Merged by: @kaoru0822-kitauji

Base: main ← Head: fix/issue-2111

📝 Commits (2)

92eff17 fix(setup): name each skill directory in the uninstall summary
18afb74 Merge remote-tracking branch 'origin/main' into fix/issue-2111

📊 Changes

2 files changed (+41 additions, -7 deletions)

View changed files

📝 src/application/Uninstall.ts (+4 -7)
📝 tests/boundary/cli/clientProfileLifecycle.test.ts (+37 -0)

📄 Description

Summary

rea uninstall checks every skill destination, but each result was labeled only skill (or Claude Code skill). A retained or failed destination couldn't be located from the summary. Each per-destination result is now labeled with the skill directory it refers to.

Fixes #2111

Before / after

Isolated HOME with a non-REA SKILL.md in ~/.agents/skills/reverse-engineer-anything and in ~/.claude/skills/reverse-engineer-anything:

before: skill: retained (Skill manifest is not REA-owned.) Claude Code skill: retained (Skill manifest is not REA-owned.) skill: skipped (…) skill: skipped (…)
after:  <home>/.agents/skills/reverse-engineer-anything: retained (Skill manifest is not REA-owned.) <home>/.claude/skills/reverse-engineer-anything: retained (Skill manifest is not REA-owned.) …

The top-level item is still name: "skill", and status aggregation is unchanged. Only the per-destination labels inside detail change.

Validation

New CLI boundary test uninstall names each retained skill directory (tests/boundary/cli/clientProfileLifecycle.test.ts). It fails on main (labels without paths) and passes with this change; the other 4 tests in the file pass.
npm run lint: passes. The only warnings are existing max-depth warnings in scripts/verify-adb.mjs.
npm test: 9150 passed, 15 failed in 8 files. The same 8 files and 15 tests fail on clean origin/main (c22111eca) on this host, so they are environmental: no Hopper installed, Command Line Tools only (no full ibtool), the hdiutil verify refusal, and JavaScript inspector target-location tests on this macOS host. Files: hopperStartupRecovery, hopperLaunchFailureCli, interfaceBuilderBundle, nibNativeHierarchy, javascriptRuntimeObservation, javascriptRuntimeTargetLocations, promptCompletion, nativeDmgArtifactReader.

No real-provider behavior is involved.

🤖 Generated with Claude Code

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2118 **Author:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/12/2026 **Merged by:** [@kaoru0822-kitauji](https://github.com/kaoru0822-kitauji) **Base:** `main` ← **Head:** `fix/issue-2111` --- ### 📝 Commits (2) - [`92eff17`](https://github.com/morluto/rea/commit/92eff17f93d233214f64240f2ae55d61b6891db7) fix(setup): name each skill directory in the uninstall summary - [`18afb74`](https://github.com/morluto/rea/commit/18afb744e30271740ae83c4da37acdc112e4e068) Merge remote-tracking branch 'origin/main' into fix/issue-2111 ### 📊 Changes **2 files changed** (+41 additions, -7 deletions) <details> <summary>View changed files</summary> 📝 `src/application/Uninstall.ts` (+4 -7) 📝 `tests/boundary/cli/clientProfileLifecycle.test.ts` (+37 -0) </details> ### 📄 Description ## Summary `rea uninstall` checks every skill destination, but each result was labeled only `skill` (or `Claude Code skill`). A retained or failed destination couldn't be located from the summary. Each per-destination result is now labeled with the skill directory it refers to. Fixes #2111 ## Before / after Isolated HOME with a non-REA `SKILL.md` in `~/.agents/skills/reverse-engineer-anything` and in `~/.claude/skills/reverse-engineer-anything`: ```text before: skill: retained (Skill manifest is not REA-owned.) Claude Code skill: retained (Skill manifest is not REA-owned.) skill: skipped (…) skill: skipped (…) after: <home>/.agents/skills/reverse-engineer-anything: retained (Skill manifest is not REA-owned.) <home>/.claude/skills/reverse-engineer-anything: retained (Skill manifest is not REA-owned.) … ``` The top-level item is still `name: "skill"`, and status aggregation is unchanged. Only the per-destination labels inside `detail` change. ## Validation - New CLI boundary test `uninstall names each retained skill directory` (`tests/boundary/cli/clientProfileLifecycle.test.ts`). It fails on main (labels without paths) and passes with this change; the other 4 tests in the file pass. - `npm run lint`: passes. The only warnings are existing `max-depth` warnings in `scripts/verify-adb.mjs`. - `npm test`: 9150 passed, 15 failed in 8 files. The same 8 files and 15 tests fail on clean `origin/main` (c22111eca) on this host, so they are environmental: no Hopper installed, Command Line Tools only (no full `ibtool`), the `hdiutil verify` refusal, and JavaScript inspector target-location tests on this macOS host. Files: `hopperStartupRecovery`, `hopperLaunchFailureCli`, `interfaceBuilderBundle`, `nibNativeHierarchy`, `javascriptRuntimeObservation`, `javascriptRuntimeTargetLocations`, `promptCompletion`, `nativeDmgArtifactReader`. No real-provider behavior is involved. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:00:17 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5043

No description provided.

Rows
Columns