[PR #2203] [MERGED] fix(readiness): deduplicate stage-level missing-evidence findings #5081

New issue

Closed

opened 2026-10-31 01:03:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:03:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2203
Author: @Totopo27
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/issue-2178-stage-level-missing-evidence

📝 Commits (2)

6a2a5af fix(readiness): deduplicate stage-level missing-evidence findings
8483748 fix(readiness): reconcile missing evidence deduplication with main

📄 Description

Closes #2178

Summary

In \src/domain/reconstructionReadinessJourneyFindings.ts, \ddMissingEvidenceFindings\ was invoked inside the per-check loop with [...stage.evidence_ids, ...check.evidence_ids]. Consequently, if an Evidence ID was referenced on the stage level and absent from the evidence bundle, it generated an identical
eferenced-evidence-missing\ finding for each required check in that stage.

Changes

Check \stage.evidence_ids\ once per stage prior to iterating over required checks.
Inside the required-checks loop, verify only \check.evidence_ids.
Add a unit test in \src/domain/reconstructionReadiness.test.ts\ verifying that absent stage-level Evidence IDs emit exactly one finding.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2203 **Author:** [@Totopo27](https://github.com/Totopo27) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/issue-2178-stage-level-missing-evidence` --- ### 📝 Commits (2) - [`6a2a5af`](https://github.com/morluto/rea/commit/6a2a5afd2a5cda71f840435be5a6c445735ca97a) fix(readiness): deduplicate stage-level missing-evidence findings - [`8483748`](https://github.com/morluto/rea/commit/8483748e1b417f90e9c0d3b95830cea83e0804b4) fix(readiness): reconcile missing evidence deduplication with main ### 📄 Description Closes #2178 ### Summary In \src/domain/reconstructionReadinessJourneyFindings.ts\, \ddMissingEvidenceFindings\ was invoked inside the per-check loop with \[...stage.evidence_ids, ...check.evidence_ids]\. Consequently, if an Evidence ID was referenced on the stage level and absent from the evidence bundle, it generated an identical \ eferenced-evidence-missing\ finding for each required check in that stage. ### Changes - Check \stage.evidence_ids\ once per stage prior to iterating over required checks. - Inside the required-checks loop, verify only \check.evidence_ids\. - Add a unit test in \src/domain/reconstructionReadiness.test.ts\ verifying that absent stage-level Evidence IDs emit exactly one finding. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:03:32 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5081

No description provided.

Rows
Columns