[PR #2249] [CLOSED] fix(apple): join NIBArchive nibValues resource keys in asset catalog inspection #5117

New issue

Closed

opened 2026-10-31 01:04:06 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:06 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2249
Author: @Bappaditya-kuilya
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: fix/apple-nibarchive-resource-keys

📝 Commits (1)

84898fd fix(apple): join NIBArchive nibValues resource keys in asset catalog inspection

📊 Changes

2 files changed (+131 additions, -3 deletions)

View changed files

📝 src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts (+111 -0)
📝 src/artifacts/apple/AppleAssetCatalogAnalysis.ts (+20 -3)

📄 Description

Fixes #2176.

collectInterfaceBuilderResourceKeys only scanned top-level node attributes, so recognized fields nested under nibValues (NIBArchive representation, e.g. NSImageName) never produced resource_key_matches. Keyed-archive resources were unaffected because that decoder flattens fields to the top level.

Change is scoped to the collector: same recognized set, same nonempty-string and archive-provenance guards, field reported as the inner key name. No decoder, schema, or projection changes.

Validation (Linux):

New collector unit test (nibValues match + title-only negative control).
New bundle workflow tests with the issue fixture bytes: unmatched with no catalog, matched with one catalog record.
Suites: src/artifacts/apple + src/domain/apple, 182 passed. tsc, oxlint, oxfmt clean.
Full CLI repro needs macOS (nondarwin assetutil guard); service-level path exercised instead via injected runAssetUtil.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2249 **Author:** [@Bappaditya-kuilya](https://github.com/Bappaditya-kuilya) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/apple-nibarchive-resource-keys` --- ### 📝 Commits (1) - [`84898fd`](https://github.com/morluto/rea/commit/84898fddf781894ea3cd5eefb0d6d2eb088a0429) fix(apple): join NIBArchive nibValues resource keys in asset catalog inspection ### 📊 Changes **2 files changed** (+131 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/artifacts/apple/AppleAssetCatalogAnalysis.test.ts` (+111 -0) 📝 `src/artifacts/apple/AppleAssetCatalogAnalysis.ts` (+20 -3) </details> ### 📄 Description Fixes #2176. collectInterfaceBuilderResourceKeys only scanned top-level node attributes, so recognized fields nested under nibValues (NIBArchive representation, e.g. NSImageName) never produced resource_key_matches. Keyed-archive resources were unaffected because that decoder flattens fields to the top level. Change is scoped to the collector: same recognized set, same nonempty-string and archive-provenance guards, field reported as the inner key name. No decoder, schema, or projection changes. Validation (Linux): - New collector unit test (nibValues match + title-only negative control). - New bundle workflow tests with the issue fixture bytes: unmatched with no catalog, matched with one catalog record. - Suites: src/artifacts/apple + src/domain/apple, 182 passed. tsc, oxlint, oxfmt clean. - Full CLI repro needs macOS (nondarwin assetutil guard); service-level path exercised instead via injected runAssetUtil. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:06 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:11:00 +00:00

[GH-ISSUE #5653] [Tracker] New issue intake by area (October 2026) #3423

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5117

No description provided.

Rows
Columns