[PR #2266] [CLOSED] fix(windows): classify transient native self-test failures as retryable #5126

New issue

Closed

opened 2026-10-31 01:04:11 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:11 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2266
Author: @chqcjq
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: fix/windows-native-retryable-classification

📝 Commits (1)

8809647 fix(windows): classify transient native self-test failures as retryable

📊 Changes

5 files changed (+19 additions, -5 deletions)

View changed files

📝 src/domain/analysisErrorCore.ts (+6 -1)
📝 src/domain/analysisErrorProjection.ts (+3 -1)
📝 src/javascript/analysis/JavaScriptAnalysisWorker.ts (+1 -1)
📝 src/process/PrivateRuntimeRoot.ts (+7 -2)
📝 src/process/WindowsAuthority.ts (+2 -0)

📄 Description

Fixes #2257.

Problem

A transient Windows file sharing violation (Win32 32, ERROR_SHARING_VIOLATION) during the native self-test is classified as capability_unavailable / unsupported_provider / retryable: false. The wording tells the caller the target or host is permanently unsupported, when the failure is transient and a retry succeeds.

Root cause

WindowsNativeLoader already marks self-test failures as retryable: true, but that flag is dropped before the error reaches the classification layer. AnalysisCapabilityUnavailableError has a static unsupported_provider category with retryable: false.

Fix

Propagate retryable: true from WindowsNativeLoadResult through WindowsNativeCapability and PrivateRuntimeRootUnavailableError.
AnalysisCapabilityUnavailableError now accepts an optional retryable flag; the classification layer checks it alongside RETRYABLE_CODES.
JavaScriptAnalysisWorker passes the flag when wrapping PrivateRuntimeRootUnavailableError.

Verification

npm run check, docs:check, and verify:test-discovery (943 files) all pass.
The classification change is minimal: only transient self-test failures (already marked retryable: true by the loader) now surface as retryable. All other capability-unavailable errors keep their existing classification.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2266 **Author:** [@chqcjq](https://github.com/chqcjq) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/windows-native-retryable-classification` --- ### 📝 Commits (1) - [`8809647`](https://github.com/morluto/rea/commit/8809647f31a19c73b4d860f87b7845e89d21ed04) fix(windows): classify transient native self-test failures as retryable ### 📊 Changes **5 files changed** (+19 additions, -5 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/analysisErrorCore.ts` (+6 -1) 📝 `src/domain/analysisErrorProjection.ts` (+3 -1) 📝 `src/javascript/analysis/JavaScriptAnalysisWorker.ts` (+1 -1) 📝 `src/process/PrivateRuntimeRoot.ts` (+7 -2) 📝 `src/process/WindowsAuthority.ts` (+2 -0) </details> ### 📄 Description Fixes #2257. ## Problem A transient Windows file sharing violation (Win32 32, ERROR_SHARING_VIOLATION) during the native self-test is classified as `capability_unavailable` / `unsupported_provider` / `retryable: false`. The wording tells the caller the target or host is permanently unsupported, when the failure is transient and a retry succeeds. ## Root cause `WindowsNativeLoader` already marks self-test failures as `retryable: true`, but that flag is dropped before the error reaches the classification layer. `AnalysisCapabilityUnavailableError` has a static `unsupported_provider` category with `retryable: false`. ## Fix - Propagate `retryable: true` from `WindowsNativeLoadResult` through `WindowsNativeCapability` and `PrivateRuntimeRootUnavailableError`. - `AnalysisCapabilityUnavailableError` now accepts an optional `retryable` flag; the classification layer checks it alongside `RETRYABLE_CODES`. - `JavaScriptAnalysisWorker` passes the flag when wrapping `PrivateRuntimeRootUnavailableError`. ## Verification - `npm run check`, `docs:check`, and `verify:test-discovery` (943 files) all pass. - The classification change is minimal: only transient self-test failures (already marked `retryable: true` by the loader) now surface as retryable. All other capability-unavailable errors keep their existing classification. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:11 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:42:58 +00:00

[PR #5126] [MERGED] fix(setup): treat empty APPDATA as unset for VS Code, Trae and Devin #6778

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5126

No description provided.

Rows
Columns