morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #2291] [MERGED] fix(ida): stop the private input of a universal Mach-O at the end of the selected slice #5143

New issue
Closed
opened 2026-10-31 01:04:18 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 01:04:18 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2291
Author: @nikolay-dementiev
Created: 10/12/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/ida-fat-slice-copy-bounds

📝 Commits (2)

  • 8499cce test(ida): expect the private input of a universal Mach-O to end at the selected slice
  • bb7d139 fix(ida): stop the private input of a universal Mach-O at the end of the selected slice

📊 Changes

2 files changed (+96 additions, -3 deletions)

View changed files

📝 src/ida/IdaWorkspace.ts (+4 -2)
📝 src/ida/IdaWorkspaceThinning.test.ts (+92 -1)

📄 Description

Summary

When IDA opens a universal Mach-O, REA copies only the selected slice into the private input. The copy also appended the head of the following slice whenever the selected slice ended before a 64 KiB read boundary and another slice followed it. The copy now ends exactly at the selected slice.

Fixes #2285

Regression of #2201, which closed #2139.

Problem and expected behavior

IdaWorkspace.copyInput() reads the admitted source in 64 KiB chunks and writes bytes.subarray(start - position, end - position) with start = max(position, slice.offset) and end = min(position + bytes.length, slice.offset + slice.size). For the first chunk that starts after the slice end, end - position is negative, and Buffer.subarray counts a negative end from the end of the chunk, so it returns a non-empty prefix. Those bytes were written to the private input and added to its digest.

Real reproduction (macOS arm64, IDA Professional 9.1): clang -O0 -arch x86_64, -arch arm64 and -arch arm64e of one source, combined with lipo -create: x86_64 at 4096 (8480 bytes), arm64 at 16384 (33464 bytes), arm64e at 65536 (33464 bytes), 99000 bytes in total. REA selects the arm64 slice on this host; the private copy was 51240 bytes, not 33464. The first 33464 bytes equal the arm64 slice and the last 17776 bytes are the first 17776 bytes of the arm64e slice. IDA still analysed ARM code here because its loader ignored the trailing bytes. /usr/bin/caffeinate with its first slice selected gave 91296 bytes instead of 37456. The bug does not appear when the selected slice is the last one or ends on a 64 KiB boundary.

Expected: the private input is exactly the selected slice (length slice.size, SHA-256 equal to the slice's).

Change and scope

  • src/ida/IdaWorkspace.ts: write and hash a chunk's bytes only when end > start. The whole-source digest check and the copy of non-universal targets are unchanged.

Intentionally not included: no change to slice selection or admission, and no docs change (no document describes the copy semantics beyond "thinned to the selected slice").

Contract and boundary impact

  • Semantic owner and earliest changed stage: the IDA workspace, at the private input copy.
  • CLI and MCP/tool-catalog contract: none.
  • Provider, bridge, target-format, or platform compatibility: IDA headless profile with universal Mach-O targets; other formats and providers are unchanged.
  • Evidence, artifact, provenance, or reconstruction contract: the private input digest and the bytes IDA receives now equal the selected slice; nothing else in Evidence changes.
  • Process execution, authorization, cleanup, or containment impact: none.
  • Generated metadata/package/installation impact: none.

Evidence and regression coverage

  • Tests added or updated: src/ida/IdaWorkspaceThinning.test.ts (beside the existing thinning tests, real workspace and real file, no mocks): a 99000-byte universal file with the layout above (synthetic bytes, each slice filled with its own value) and a host that selects the middle slice; and a universal file whose first slice is selected with another slice after it. Each asserts that the private input length equals slice.size, that its bytes equal the slice, and that inputSha256 equals the slice's SHA-256.
  • Base reproduction or other evidence: both new tests fail on ec2d251c0 with the private input at 51240 bytes instead of 33464 and 59224 instead of 37456. Real IDA Professional 9.1 (headless idalib, ida-pro-mcp c133c38, macOS arm64) on the lipo layout above: on ec2d251c0 the private input was 51240 bytes; with this branch it is 33464 bytes and byte-identical to the arm64 slice, IDA still analyses ARM code, rea function /usr/bin/caffeinate start still returns arm64e code at 0x100000740, and npm run verify:ida passes.
  • Remaining proof gaps: only macOS arm64 was exercised; other hosts and IDA versions were not.
  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity, source provenance, and failed attempts remain preserved.
  • Unsupported, incomplete, unavailable, or uncertain outcomes remain visible.

Validation performed

  • npm run check:fast, npm run check, npm run verify:test-discovery (950 files) - green
  • npm run test:focused -- src/ida/IdaWorkspaceThinning.test.ts - 7 passed
  • npm run test:fast - 404 files, 5245 passed, 7 skipped, 0 failed
  • Mutation check, reverted: replacing the new guard with true fails both new tests (51240 and 59224 bytes)

macOS arm64 only; Linux and Windows were not executed. test:boundary was not run because no boundary file is touched.

Compatibility, safety, and release

  • Breaking changes or migration steps: none.
  • Real Hopper/Ghidra, browser, or OS coverage: real IDA 9.1 on macOS arm64 (see above); Hopper, Ghidra and browser not applicable.
  • Package or release metadata impact: none.
  • Security, privacy, process, or containment review: the private input no longer contains bytes outside the admitted slice.

Review checklist

  • The change addresses a concrete problem, not an unscoped refactor.
  • The PR has one focused outcome, and the title follows type(scope): outcome.
  • Related issue is linked.
  • Tests cover changed behavior and failure paths.
  • Owning docs, contracts, and generated metadata are updated.
  • User-visible CLI/MCP changes include representative output.
  • I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2291 **Author:** [@nikolay-dementiev](https://github.com/nikolay-dementiev) **Created:** 10/12/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/ida-fat-slice-copy-bounds` --- ### 📝 Commits (2) - [`8499cce`](https://github.com/morluto/rea/commit/8499cce37f6d93b8806144fa5cab11313aafdb3b) test(ida): expect the private input of a universal Mach-O to end at the selected slice - [`bb7d139`](https://github.com/morluto/rea/commit/bb7d139b20e08662b29bad98e3c4abd88b9b80e3) fix(ida): stop the private input of a universal Mach-O at the end of the selected slice ### 📊 Changes **2 files changed** (+96 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/ida/IdaWorkspace.ts` (+4 -2) 📝 `src/ida/IdaWorkspaceThinning.test.ts` (+92 -1) </details> ### 📄 Description ## Summary When IDA opens a universal Mach-O, REA copies only the selected slice into the private input. The copy also appended the head of the following slice whenever the selected slice ended before a 64 KiB read boundary and another slice followed it. The copy now ends exactly at the selected slice. Fixes #2285 Regression of #2201, which closed #2139. ## Problem and expected behavior `IdaWorkspace.copyInput()` reads the admitted source in 64 KiB chunks and writes `bytes.subarray(start - position, end - position)` with `start = max(position, slice.offset)` and `end = min(position + bytes.length, slice.offset + slice.size)`. For the first chunk that starts after the slice end, `end - position` is negative, and `Buffer.subarray` counts a negative end from the end of the chunk, so it returns a non-empty prefix. Those bytes were written to the private input and added to its digest. Real reproduction (macOS arm64, IDA Professional 9.1): `clang -O0 -arch x86_64`, `-arch arm64` and `-arch arm64e` of one source, combined with `lipo -create`: x86_64 at 4096 (8480 bytes), arm64 at 16384 (33464 bytes), arm64e at 65536 (33464 bytes), 99000 bytes in total. REA selects the arm64 slice on this host; the private copy was 51240 bytes, not 33464. The first 33464 bytes equal the arm64 slice and the last 17776 bytes are the first 17776 bytes of the arm64e slice. IDA still analysed ARM code here because its loader ignored the trailing bytes. `/usr/bin/caffeinate` with its first slice selected gave 91296 bytes instead of 37456. The bug does not appear when the selected slice is the last one or ends on a 64 KiB boundary. Expected: the private input is exactly the selected slice (length `slice.size`, SHA-256 equal to the slice's). ## Change and scope - `src/ida/IdaWorkspace.ts`: write and hash a chunk's bytes only when `end > start`. The whole-source digest check and the copy of non-universal targets are unchanged. Intentionally not included: no change to slice selection or admission, and no docs change (no document describes the copy semantics beyond "thinned to the selected slice"). ## Contract and boundary impact - Semantic owner and earliest changed stage: the IDA workspace, at the private input copy. - CLI and MCP/tool-catalog contract: none. - Provider, bridge, target-format, or platform compatibility: IDA headless profile with universal Mach-O targets; other formats and providers are unchanged. - Evidence, artifact, provenance, or reconstruction contract: the private input digest and the bytes IDA receives now equal the selected slice; nothing else in Evidence changes. - Process execution, authorization, cleanup, or containment impact: none. - Generated metadata/package/installation impact: none. ## Evidence and regression coverage - Tests added or updated: `src/ida/IdaWorkspaceThinning.test.ts` (beside the existing thinning tests, real workspace and real file, no mocks): a 99000-byte universal file with the layout above (synthetic bytes, each slice filled with its own value) and a host that selects the middle slice; and a universal file whose first slice is selected with another slice after it. Each asserts that the private input length equals `slice.size`, that its bytes equal the slice, and that `inputSha256` equals the slice's SHA-256. - Base reproduction or other evidence: both new tests fail on `ec2d251c0` with the private input at 51240 bytes instead of 33464 and 59224 instead of 37456. Real IDA Professional 9.1 (headless idalib, ida-pro-mcp c133c38, macOS arm64) on the `lipo` layout above: on `ec2d251c0` the private input was 51240 bytes; with this branch it is 33464 bytes and byte-identical to the arm64 slice, IDA still analyses ARM code, `rea function /usr/bin/caffeinate start` still returns arm64e code at `0x100000740`, and `npm run verify:ida` passes. - Remaining proof gaps: only macOS arm64 was exercised; other hosts and IDA versions were not. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity, source provenance, and failed attempts remain preserved. - [x] Unsupported, incomplete, unavailable, or uncertain outcomes remain visible. ## Validation performed - `npm run check:fast`, `npm run check`, `npm run verify:test-discovery` (950 files) - green - `npm run test:focused -- src/ida/IdaWorkspaceThinning.test.ts` - 7 passed - `npm run test:fast` - 404 files, 5245 passed, 7 skipped, 0 failed - Mutation check, reverted: replacing the new guard with `true` fails both new tests (51240 and 59224 bytes) macOS arm64 only; Linux and Windows were not executed. `test:boundary` was not run because no boundary file is touched. ## Compatibility, safety, and release - Breaking changes or migration steps: none. - Real Hopper/Ghidra, browser, or OS coverage: real IDA 9.1 on macOS arm64 (see above); Hopper, Ghidra and browser not applicable. - Package or release metadata impact: none. - Security, privacy, process, or containment review: the private input no longer contains bytes outside the admitted slice. ## Review checklist - [x] The change addresses a concrete problem, not an unscoped refactor. - [x] The PR has one focused outcome, and the title follows `type(scope): outcome`. - [x] Related issue is linked. - [x] Tests cover changed behavior and failure paths. - [x] Owning docs, contracts, and generated metadata are updated. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 01:04:18 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#5143
No description provided.