morluto/rea

Fork

You've already forked rea

mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00

Code Issues 1.3k Projects Packages Wiki Activity

[PR #2313] [CLOSED] fix(cli): report command failures as ok:false in the full-output envelope #5158

New issue

Closed

opened 2026-10-31 01:04:25 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:25 +00:00

Owner

Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2313
Author: @jasonchen505
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: contrib/cli-full-output-error-envelope

📝 Commits (2)

853ed5a fix(cli): report command failures as ok:false in the full-output envelope
d7b6041 fix(cli): honor per-command failure checks in the full-output envelope

📊 Changes

3 files changed (+162 additions, -3 deletions)

View changed files

📝 src/cli/streamedJsonOutput.ts (+17 -3)
📝 src/cliLogging.ts (+22 -0)
➕ tests/boundary/cli/streamedJsonOutput.test.ts (+123 -0)

📄 Description

Summary

Fixes #2273. With --full-output, CLI analysis failures were wrapped in {"ok": true, "data": ...} while the process exited 1. The envelope now renders failed commands as { ok: false, error, meta } so the ok flag agrees with the exit code.

Problem and expected behavior

Smallest trigger: rea inspect-managed-artifact /definitely/missing/x.dll --format json --full-output. Observed: exit 1 with {"ok": true, "data": {"error": "Analysis failed", "code": "target_unavailable", ...}}. Violated invariant: the ok flag in the full-output envelope must agree with the process exit code. Framework-level failures from the same binary already produced {"ok": false, "error": {...}}. Analysis failures did not.

Change and scope

src/cli/streamedJsonOutput.ts now classifies the command value with isCliOperationFailure, the same predicate logCliCommand uses to set the exit code, and renders failures as { ok: false, error, meta }. The unfiltered value decides ok. The filtered payload is preserved in error when --filter-output is combined with --full-output.

Not included: --format yaml envelopes are built by the incur framework, not by REA code, so that path is unchanged.

Contribution scope fit: isolated regression fix within existing CLI output boundaries. No target execution, no new providers, no authority or cleanup changes. No maintainer scope decision required.

Contract and boundary impact

Semantic owner and earliest changed stage: CLI JSON output rendering in src/cli/streamedJsonOutput.ts, after command completion.
Contribution scope fit and linked maintainer decision: in scope as an isolated regression fix. Not applicable.
CLI and MCP/tool-catalog contract: CLI only. MCP tool catalog unchanged. No generated metadata changes.
Provider, bridge, target-format, or platform compatibility: none.
Evidence, artifact, provenance, or reconstruction contract: none.
Target selection, authority, upstream behavior, and cleanup details: not applicable.
Generated metadata, package, or installation impact: none.

Expected effects:

Read existing files or captured data.
Launch or attach to a process.
Inject instrumentation or run scripts/code.
Change process memory, registers, files, or configuration.
Contact network services.
Recover protected code or work around protections.
Documentation or usability only; no target interaction.
Not sure yet; investigation or maintainer guidance needed.

Evidence and regression coverage

Tests added or updated: tests/boundary/cli/streamedJsonOutput.test.ts with 4 tests covering the success envelope, a CLI error envelope failure, a bare analysis error projection failure, and the unchanged non-full-output failure output.
Base reproduction: published rea-agents@6.4.0 printed {"ok": true, ...} with exit 1 before the fix. After the fix the built CLI prints {"ok": false, "error": {"code": "target_unavailable", ...}, "meta": {...}} with exit 1.
User-visible CLI/MCP output: shown above.
Remaining proof gaps: the --format yaml path is owned by incur and unchanged.

Validation performed

npm run test:focused -- tests/boundary/cli/streamedJsonOutput.test.ts — 4 passed
npm run test:focused -- tests/boundary/cli/jsonOutput.test.ts — 28 passed
npm run test:local -- src/cliLogging.test.ts — 6 passed
npm run test:focused -- tests/acceptance/managedCliOutput.test.ts — 7 passed
npm run check:fast — typecheck and lint passed
Manual end to end: node scripts/rea.mjs inspect-managed-artifact /definitely/missing/x.dll --format json --full-output — {"ok": false, ...}, exit 1

Compatibility, safety, and release

Breaking changes or migration steps: callers that parsed ok: true alongside an error payload will now see ok: false. This corrects the envelope to match the exit code and the existing framework-failure contract. No migration beyond reading the ok flag.
Real Hopper/Ghidra, browser, or OS coverage: none required. No analysis engines involved.
Package or release metadata impact: none.
Security, privacy, process, or containment review: none.

Before merge

This PR addresses a concrete problem or an agreed enhancement.
Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff.
The PR has one focused outcome and the title follows type(scope): outcome.
Related issue is linked, or the reason for not linking one is stated above.
Tests cover changed observable behavior and meaningful failure paths.
Owning docs, contracts, and generated metadata are updated where needed.
User-visible CLI/MCP changes include representative output.
I checked the final diff for secrets, unrelated cleanup, and unsupported claims.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2313 **Author:** [@jasonchen505](https://github.com/jasonchen505) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `contrib/cli-full-output-error-envelope` --- ### 📝 Commits (2) - [`853ed5a`](https://github.com/morluto/rea/commit/853ed5a3878f9ac4cf18154e835cd17da5640306) fix(cli): report command failures as ok:false in the full-output envelope - [`d7b6041`](https://github.com/morluto/rea/commit/d7b604102479deaaed14ec991ddc45d420a188b6) fix(cli): honor per-command failure checks in the full-output envelope ### 📊 Changes **3 files changed** (+162 additions, -3 deletions) <details> <summary>View changed files</summary> 📝 `src/cli/streamedJsonOutput.ts` (+17 -3) 📝 `src/cliLogging.ts` (+22 -0) ➕ `tests/boundary/cli/streamedJsonOutput.test.ts` (+123 -0) </details> ### 📄 Description ## Summary Fixes #2273. With `--full-output`, CLI analysis failures were wrapped in `{"ok": true, "data": ...}` while the process exited 1. The envelope now renders failed commands as `{ ok: false, error, meta }` so the `ok` flag agrees with the exit code. ## Problem and expected behavior Smallest trigger: `rea inspect-managed-artifact /definitely/missing/x.dll --format json --full-output`. Observed: exit 1 with `{"ok": true, "data": {"error": "Analysis failed", "code": "target_unavailable", ...}}`. Violated invariant: the `ok` flag in the full-output envelope must agree with the process exit code. Framework-level failures from the same binary already produced `{"ok": false, "error": {...}}`. Analysis failures did not. ## Change and scope `src/cli/streamedJsonOutput.ts` now classifies the command value with `isCliOperationFailure`, the same predicate `logCliCommand` uses to set the exit code, and renders failures as `{ ok: false, error, meta }`. The unfiltered value decides `ok`. The filtered payload is preserved in `error` when `--filter-output` is combined with `--full-output`. Not included: `--format yaml` envelopes are built by the incur framework, not by REA code, so that path is unchanged. Contribution scope fit: isolated regression fix within existing CLI output boundaries. No target execution, no new providers, no authority or cleanup changes. No maintainer scope decision required. ## Contract and boundary impact - Semantic owner and earliest changed stage: CLI JSON output rendering in `src/cli/streamedJsonOutput.ts`, after command completion. - Contribution scope fit and linked maintainer decision: in scope as an isolated regression fix. Not applicable. - CLI and MCP/tool-catalog contract: CLI only. MCP tool catalog unchanged. No generated metadata changes. - Provider, bridge, target-format, or platform compatibility: none. - Evidence, artifact, provenance, or reconstruction contract: none. - Target selection, authority, upstream behavior, and cleanup details: not applicable. - Generated metadata, package, or installation impact: none. Expected effects: - [ ] Read existing files or captured data. - [ ] Launch or attach to a process. - [ ] Inject instrumentation or run scripts/code. - [ ] Change process memory, registers, files, or configuration. - [ ] Contact network services. - [ ] Recover protected code or work around protections. - [x] Documentation or usability only; no target interaction. - [ ] Not sure yet; investigation or maintainer guidance needed. ## Evidence and regression coverage - Tests added or updated: `tests/boundary/cli/streamedJsonOutput.test.ts` with 4 tests covering the success envelope, a CLI error envelope failure, a bare analysis error projection failure, and the unchanged non-full-output failure output. - Base reproduction: published `rea-agents@6.4.0` printed `{"ok": true, ...}` with exit 1 before the fix. After the fix the built CLI prints `{"ok": false, "error": {"code": "target_unavailable", ...}, "meta": {...}}` with exit 1. - User-visible CLI/MCP output: shown above. - Remaining proof gaps: the `--format yaml` path is owned by incur and unchanged. ## Validation performed - `npm run test:focused -- tests/boundary/cli/streamedJsonOutput.test.ts` — 4 passed - `npm run test:focused -- tests/boundary/cli/jsonOutput.test.ts` — 28 passed - `npm run test:local -- src/cliLogging.test.ts` — 6 passed - `npm run test:focused -- tests/acceptance/managedCliOutput.test.ts` — 7 passed - `npm run check:fast` — typecheck and lint passed - Manual end to end: `node scripts/rea.mjs inspect-managed-artifact /definitely/missing/x.dll --format json --full-output` — `{"ok": false, ...}`, exit 1 ## Compatibility, safety, and release - Breaking changes or migration steps: callers that parsed `ok: true` alongside an error payload will now see `ok: false`. This corrects the envelope to match the exit code and the existing framework-failure contract. No migration beyond reading the `ok` flag. - Real Hopper/Ghidra, browser, or OS coverage: none required. No analysis engines involved. - Package or release metadata impact: none. - Security, privacy, process, or containment review: none. ## Before merge - [x] This PR addresses a concrete problem or an agreed enhancement. - [x] Material scope and authority questions are resolved, and any required maintainer scope decision covers the final diff. - [x] The PR has one focused outcome and the title follows `type(scope): outcome`. - [x] Related issue is linked, or the reason for not linking one is stated above. - [x] Tests cover changed observable behavior and meaningful failure paths. - [x] Owning docs, contracts, and generated metadata are updated where needed. - [x] User-visible CLI/MCP changes include representative output. - [x] I checked the final diff for secrets, unrelated cleanup, and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:25 +00:00

closed this issue
added the
pull-request
label

No Branch/Tag specified

main

codex/procedure-reference-stacked

release-please--branches--main--components--rea-agents

release-please--branches--main--components--rea-agents--release-notes

codex/kuna-independent-retry

codex/byte-search-overlay-coverage

codex/open-failure-target-receipt

codex/kuna-xref-evidence

codex/ghidra-ambiguous-procedure-recovery

codex/function-source-bundle

codex/trace-function-integration-prototype

codex/snapshot-source-closure

codex/recorded-evidence-array-pages

codex/evidence-recovery-redesign

codex/trace-feature-address-scope

codex/call-discovery-scope

codex/ghidra-literal-candidate-evidence

codex/decompile-directory-independent-retry

codex/retry-provenance-base

codex/value-flow-capability-experiment

codex/ghidra-containing-instruction

cursor/readme-discord-button-ef9f

dependabot/github_actions/actions/setup-node-7.1.0

dependabot/github_actions/actions/upload-artifact-7.0.2

dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df

codex/kuna-1989

fix/8559-native-ui-fixture-ownership

fix/8555-go-verifier-mcp-ownership

codex/provider-capability-recovery

fix/8642-rizin-target-stdin

codex/ghidra-memory-effect-scope

codex/ghidra-annotation-entry-selector

codex/ghidra-readonly-recovery

codex/ghidra-regex-verifier-recovery

codex/evidence-discovery-view-guidance

fix/8545-bulk-append-overflow

fix/8428-navigation-refusal-alternatives

codex/address-context-recovery

codex/matching-member-limitations

codex/unknown-scope-contract

codex/evidence-view-guidance

feat/8373-native-trace-views

codex/ghidra-snapshot-verifier-binding

codex/elf-export-visibility

codex/evidence-view-recovery

codex/native-reference-cli-help

codex/provider-candidate-observation-scope

codex/kuna-session-verification

codex/ghidra-switch-lifetime-guidance

codex/pseudocode-paging-discovery

codex/clarify-evidence-view-support

codex/kuna-xrefs-selector-recovery

codex/context-capacity-recovery

codex/evidence-closure-large-links

codex/same-function-evidence-identity

codex/ghidra-verifier-inspected-jdk

codex/audit-guided-workflows

codex/crash-prompt-retained-dossiers

codex/analysis-view-error-recovery

codex/kuna-verifier-target-selection

codex/ghidra-selected-project-call-coverage

codex/docs-native-analysis-scope

codex/ghidra-java-socket-boundary

codex/ghidra-retained-snapshot-verifier

codex/ghidra-search-inventory-facts

fix/8284-zero-argument-parameter-bindings

fix/8198-ui-action-handler-offset

fix/8257-elf-entry-label-identity

fix/8304-deferred-output-schema-projection

fix/8277-call-path-computed-target-uncertainty

fix/pr-8089-conflicts

fix/ci-static-duplicate-export

dependabot/npm_and_yarn/lint-staged-17.6.0

dependabot/github_actions/actions/download-artifact-8.0.2

dependabot/npm_and_yarn/write-file-atomic-8.0.0

dependabot/npm_and_yarn/canonicalize-5.1.0

dependabot/github_actions/actions/cache/restore-6.1.0

dependabot/npm_and_yarn/toon-format/toon-4.4.0

dependabot/github_actions/actions/deploy-pages-5.0.1

codex/review-fixes-pr-2403

codex/review-fixes-pr-2400

codex/process-terminal-width

codex/test-brittleness-cleanup

verify/7167-browser-connect-macos

fix/7167-browser-connect

feat/native-matching-allowance-setting

feat/browser-scenario-dry-run

test/managed-caller-parameters-20261024

codex/parser-fortythird-boundaries

fix/6926-pinvoke-platform-decorations-20261023

fix/6889-har-body-encoding-20261023

fix/6888-sqlite-schema-budget-20261023

fix/dependency-security-gates-6708

cursor/evidence-overwrite-rebase-b4ac

feat/4057-verify-native-exports

fix/windows-acl-observer-overhead-20261022

cursor/erlang-beam-restack-4476

cursor/pe-certificate-review-bf32

fix/6116-javascript-application-fs-errors

fix/6061-unmapped-runtime-script-unknown

feat/browser-scenario-summary

fix/pe-certificates

codex/verify-3407

cursor/rebase-5699

cursor/rebase-5352

cursor/rebase-5600

cursor/fix-cli-schema-omission-10a8

codex/audit-hopper-shutdown-reasons-20261021

fix/demangle-swift-omitted-record

fix/nib-boolean-value-types

cursor/cancellation-partial-observation-a5ac

fix/ib-object-limit-reasons

fix/electron-fuse-limit-advice

fix/kuna-doctor-dangling-cache

fix/fixed-budget-refusal-advice

fix/js-ipc-listener-dedup

fix/js-return-member-provenance

fix/dmg-integrity-retry-advice

fix/ida-doctor-readiness

fix/kuna-version-probe-output-drain

fix/legacy-swift-runtime-name-matching

fix/dylib-lazy-load-commands

fix/browser-scenario-startup-cancel

fix/swift-nested-punycode-classification

fix/compare-unselected-scopes

fix/objc-method-budget-coverage

fix/dmg-mounted-root-observations

audit/ci-tests-20261019-round2

release/6.7.0

fix/wabt-cleanup-retry-resolution

fix/electron-fuse-elf-pe-architecture

fix/native-plist-descriptor-ownership

fix/kuna-caller-cleanup-ownership

experiment/atomic-codemode-20261016

review/first-contributor-3776

fix/call-resolution-full-read-cycles

fix/member-mutation-selection-repeat

experiment/atomic-re-tools-20261015

perf/member-mutation-lazy-origins

perf/static-network-mutation-index

fix/hopper-startup-lifecycle

audit/3050-windows-proof-20261015

feat/windows-window-capture-2183

audit/3049-windows-proof-20261015

audit/3735-macos-fixtures-20261015

fix/batch-decompile-null-pseudocode

fix/kuna-inventory-honors-jobs

experiment/browser-codemode-tool-design-20261015

fix/hopper-clean-runtime-argv

codex/review-2049-27f1b367

review-fixes/pr-2787-routing

fix/3360-scoped-this-emitters

fix/3367-replaced-global-effects

fix/3838-compact-any-value-items

test/hopper-download-probe-20261015

codex/windows-runtime-creation-red-green-20261015

codex/windows-readonly-root-red-green-20261015

codex/windows-root-share-red-green-20261015

codex/exp-1685-win-mcp-startup

codex/bug-sweep-20261015

investigate/2190-windows-package-phases

investigate/3543-macos-cli-deadline

perf/3281-reverse-tools-feedback-quality

fix/3406-hopper-doctor-fixture

fix/3341-wrapper-require-test-context

fix/3301-owned-uninstall-fixtures

fix/3164-compiler-input-ownership

fix/pcap-cleanup-stdout-newline-20261014

perf/interface-builder-summary

codex/review-fixes-pr-1977

fix/ghidra-effective-jvm-platform

fix/docs-turkish-rust-link-20261013

fix/main-maintenance-ci-20261010

fix/recover-binary-session-process-effects

codex/review-fixes-pr-2457

codex/ci-required-cancellation-gate

fix/main-format-baseline-20261013

fix/setup-preserve-entry-fields

cursor/restore-main-checks-1ffc

fix/ghidra-bridge-hashmap-import

codex/shared-ci-jadx-json-default-20261013

codex/shared-ci-ghidra-test-groups-20261013

codex/shared-ci-java-fixture-format-20261013

codex/fix-intrinsic-invocation-boundaries

test/release-preflight-reusable-jobs

test/js-parameter-provenance-expectation

fix/linux-hopper-verification-current

test/2419-ghidra-elf-probe-size

followup/pr-1544-native-ida

codex/fold-pr-2230-contribution

docs/readme-responsible-use

fix/issue-2064

fix/issue-2050

fix/issue-2053

fix/issue-1968

fix/issue-1945

experiment/codemode-bridge-20261011

fix/tool-effects-negative-wording-1904-20261012

fix/1842-electron-interop-provenance

feat/recover-javascript-multi-input

refactor/website-i18n-prep

fix/nativeaot-pe-virtual-extent

fix/browser-verifier-ci-hang

fix/pe-resources-input-selection

docs/beginner-friendly-guides

docs/beginner-setup-guide

fix/javascript-analysis-worker-1563

fix/1649-ghidra-duplicate-names

fix/javascript-export-keys-integration-1369

test/maintenance-boundary-contracts-20261011

review/javascript-export-keys-1369

review/process-live-progress-1483

test/javascript-1495-growth-ratio

fix/ci-escape-timing

docs/normalized-terminal-geometry-1450

release/6.3.0

archive/release-6.3.0-pr1381

release/6.2.0

fix/electron-preload-dynamic-override

fix/javascript-self-referential-bundler-edges

release/6.1.0

cursor/grok-client-cherry-pick-0b56

feat/signature-posture

feat/dyld-shared-cache

feat/artifact-integrity-policy

feat/pkg-inventory

release/6.0.0

chore/sync-release-5.0.0

release/5.0.0

cursor/cloud-agent-node-787e

fix/javascript-xhr-open-endpoints

review/pr-711-realpath-fallback-wording

cleanup/replay-confinement

codex/test-suite-performance

codex/issue-foundations

codex/address-open-issues-2026-07-20

agent/javascript-vite-rollup-esbuild-adapters

agent/process-cleanup

agent/triage-integration

agent/unknown-commands-registry

feat/mcp-identity-metadata

morlvps/issue_cleanup

codex/installer-redesign

morl/roadmap-investigation-core

morl/roadmap-investigation-docs

release-please--branches--main--components--rea

rea-agents-6.8.0

rea-agents-6.7.0

rea-agents-6.6.0

experiment/atomic-codemode-wait-runtime-20261016

rea-agents-6.5.0

rea-agents-6.4.0

rea-agents-6.3.0

rea-agents-6.2.0

rea-agents-6.1.0

rea-agents-6.0.0

rea-agents-5.0.0

rea-agents-4.1.0

rea-agents-4.0.1

rea-agents-4.0.0

rea-agents-3.2.1

rea-agents-3.2.0

rea-agents-3.1.0

rea-agents-3.0.0

rea-agents-2.7.0

rea-agents-2.6.0

rea-agents-2.5.1

rea-agents-2.5.0

rea-agents-2.4.0

rea-agents-2.3.0

rea-agents-2.2.0

rea-agents-2.1.0

rea-agents-2.0.0

rea-agents-1.7.0

rea-agents-1.6.0

rea-agents-1.5.0

rea-agents-1.4.0

rea-agents-1.3.0

rea-agents-1.2.0

rea-agents-1.1.0

rea-agents-1.0.0

rea-agents-0.5.0

rea-agents-0.4.0

rea-agents-0.3.0

rea-0.2.1

rea-0.2.0

Labels

Clear labels

Mirrored from GitHub Pull Request

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5158

Reference in a new issue

Repository

morluto/rea

Title

Body

No description provided.

Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?

Rows
Columns