[PR #2337] [CLOSED] fix(artifacts): describe ZIP non-entry coverage accurately #5173

New issue

Closed

opened 2026-10-31 01:04:32 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:32 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2337
Author: @matbrgz
Created: 10/12/2026
Status: ❌ Closed

Base: main ← Head: fix/zip-inventory-coverage-description

📝 Commits (1)

0bdb537 fix(artifacts): describe ZIP non-entry coverage accurately

📊 Changes

5 files changed (+79 additions, -2 deletions)

View changed files

➕ docs/specs/001-zip-inventory-coverage/plan.md (+14 -0)
➕ docs/specs/001-zip-inventory-coverage/spec.md (+22 -0)
➕ docs/specs/001-zip-inventory-coverage/tasks.md (+6 -0)
📝 src/domain/zipPackageFormat.ts (+2 -2)
📝 tests/boundary/providers/native/artifactProvider.archiveInventory.test.ts (+35 -0)

📄 Description

Archive inventory currently says the APK Signing Block is after the central directory. It is before it. Correct the canonical coverage limitation to explain that non-entry bytes are omitted regardless of position. The exported constant name is preserved and comparison continues to consume the same owner.

Closes #2330.

Spec, plan and tasks: docs/specs/001-zip-inventory-coverage/.

The new boundary regression inventories two actual ZIPs with identical entry bytes and different equal-length comments: entry content identities match, whole-file hashes differ, comments do not become occurrences, and the result reports the corrected limitation.

Validation: npm run test:focused passed 11 tests across archive inventory and both artifact comparison suites. npm run check passed type checking, lint, formatting, knip, metadata and architecture/module guards. npm run verify:test-discovery also passed. Toolchain: Node 24.18.0, npm 11.16.0.

No target execution or new provider is involved. Signature parsing and verification remain outside this change. Format reference: https://source.android.com/docs/security/features/apksigning/v2#apk-signing-block

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2337 **Author:** [@matbrgz](https://github.com/matbrgz) **Created:** 10/12/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/zip-inventory-coverage-description` --- ### 📝 Commits (1) - [`0bdb537`](https://github.com/morluto/rea/commit/0bdb5376ece15e3dc3235f9f5cc668223f9017dd) fix(artifacts): describe ZIP non-entry coverage accurately ### 📊 Changes **5 files changed** (+79 additions, -2 deletions) <details> <summary>View changed files</summary> ➕ `docs/specs/001-zip-inventory-coverage/plan.md` (+14 -0) ➕ `docs/specs/001-zip-inventory-coverage/spec.md` (+22 -0) ➕ `docs/specs/001-zip-inventory-coverage/tasks.md` (+6 -0) 📝 `src/domain/zipPackageFormat.ts` (+2 -2) 📝 `tests/boundary/providers/native/artifactProvider.archiveInventory.test.ts` (+35 -0) </details> ### 📄 Description Archive inventory currently says the APK Signing Block is after the central directory. It is before it. Correct the canonical coverage limitation to explain that non-entry bytes are omitted regardless of position. The exported constant name is preserved and comparison continues to consume the same owner. Closes #2330. Spec, plan and tasks: `docs/specs/001-zip-inventory-coverage/`. The new boundary regression inventories two actual ZIPs with identical entry bytes and different equal-length comments: entry content identities match, whole-file hashes differ, comments do not become occurrences, and the result reports the corrected limitation. Validation: `npm run test:focused` passed 11 tests across archive inventory and both artifact comparison suites. `npm run check` passed type checking, lint, formatting, knip, metadata and architecture/module guards. `npm run verify:test-discovery` also passed. Toolchain: Node 24.18.0, npm 11.16.0. No target execution or new provider is involved. Signature parsing and verification remain outside this change. Format reference: https://source.android.com/docs/security/features/apksigning/v2#apk-signing-block --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:32 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:07 +00:00

[PR #5173] [CLOSED] Fix/psx zero gp unknown 4138 #6800

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5173

No description provided.

Rows
Columns