[PR #2421] [CLOSED] test(ghidra): derive ELF probe sizes from fixture bytes #5215

New issue

Closed

opened 2026-10-31 01:04:52 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:52 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2421
Author: @N0zoM1z0
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: test/2419-ghidra-elf-probe-size

📝 Commits (1)

f620dbb test(ghidra): derive ELF probe sizes from fixture bytes

📊 Changes

1 file changed (+9 additions, -12 deletions)

View changed files

📝 src/ghidra/GhidraInstallation.test.ts (+9 -12)

📄 Description

Latest main fails three native-decompiler admission assertions on both Linux shard 4/6 and the Windows curated lane. The shared ELF fixture now returns a complete 64-byte ELF64 header, while these test probes still claim a 52-byte file. The stricter fixed-header validator correctly rejects that contradictory observation, leaving optional installation diagnosis unknown.

Build ELF probe observations from one buffer and derive their file size from that buffer, including the existing ELF32 case. All admission, refusal, and diagnostic assertions remain intact; executable validation and production probing are unchanged.

Closes #2419.

Validation:

Reproduced the untouched-main failure locally: 3 failed / 42 passed, matching both CI lanes.
Corrected Ghidra and shared executable-header parser suites: 81 passed.
Fresh npm run check:ci, test discovery (1,002 files exactly once), LLDB Python producer suite (9 passed), and npm run docs:check passed.
Actionlint passed for all workflows (syntax/expression validation; external shellcheck/pyflakes disabled).
Complete local V8 coverage suite is running and will be recorded before merge. PR CI must validate the final commit, including Linux shards and Windows curated tests.

Review: traced fixture construction through the shared parser and fixed-header validator to Ghidra installation diagnosis; production probes obtain bytes and size from the same opened file. The correction removes the duplicated size assumption without weakening malformed-header handling.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2421 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `test/2419-ghidra-elf-probe-size` --- ### 📝 Commits (1) - [`f620dbb`](https://github.com/morluto/rea/commit/f620dbb14099327e07b99997e68d2cc931f3c47d) test(ghidra): derive ELF probe sizes from fixture bytes ### 📊 Changes **1 file changed** (+9 additions, -12 deletions) <details> <summary>View changed files</summary> 📝 `src/ghidra/GhidraInstallation.test.ts` (+9 -12) </details> ### 📄 Description Latest main fails three native-decompiler admission assertions on both Linux shard 4/6 and the Windows curated lane. The shared ELF fixture now returns a complete 64-byte ELF64 header, while these test probes still claim a 52-byte file. The stricter fixed-header validator correctly rejects that contradictory observation, leaving optional installation diagnosis unknown. Build ELF probe observations from one buffer and derive their file size from that buffer, including the existing ELF32 case. All admission, refusal, and diagnostic assertions remain intact; executable validation and production probing are unchanged. Closes #2419. Validation: - Reproduced the untouched-main failure locally: 3 failed / 42 passed, matching both CI lanes. - Corrected Ghidra and shared executable-header parser suites: 81 passed. - Fresh `npm run check:ci`, test discovery (1,002 files exactly once), LLDB Python producer suite (9 passed), and `npm run docs:check` passed. - Actionlint passed for all workflows (syntax/expression validation; external shellcheck/pyflakes disabled). - Complete local V8 coverage suite is running and will be recorded before merge. PR CI must validate the final commit, including Linux shards and Windows curated tests. Review: traced fixture construction through the shared parser and fixed-header validator to Ghidra installation diagnosis; production probes obtain bytes and size from the same opened file. The correction removes the duplicated size assumption without weakening malformed-header handling. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:52 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5215

No description provided.

Rows
Columns