[PR #2436] [CLOSED] fix(pwntools): include retained process group in cleanup resources #5227

New issue

Closed

opened 2026-10-31 01:04:58 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:04:58 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2436
Author: @BeqaKs
Created: 10/13/2026
Status: ❌ Closed

Base: main ← Head: fix/pwntools-cleanup-resources

📝 Commits (1)

d5ef136 fix(pwntools): include retained process group in cleanup resources

📊 Changes

5 files changed (+82 additions, -17 deletions)

View changed files

📝 src/native/pwntools/PwntoolsDecoder.ts (+13 -6)
➕ src/process/OwnedCommand.resources.test.ts (+35 -0)
📝 src/process/OwnedCommand.ts (+13 -6)
📝 tests/boundary/process/ownedCommand.test.ts (+5 -3)
📝 tests/process-global/pwntoolsStageRetirement.test.ts (+16 -2)

📄 Description

Summary

Add ownedCommandResources() so owned-command and pwntools decoder cleanup errors list runId, optional runtime directory, pid:<leader>, and process-group:<id> consistently.
Use it in PwntoolsDecoder.#retireProcess when process stop is incomplete (fixes #2274).
Regression: pwntoolsStageRetirement asserts full details.resources; unit test covers the helper.

Test plan

npm run test:local -- src/process/OwnedCommand.resources.test.ts
npm run check:fast
CI: tests/process-global/pwntoolsStageRetirement.test.ts, tests/boundary/process/ownedCommand.test.ts (require Darwin ownership inspector compile locally)

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2436 **Author:** [@BeqaKs](https://github.com/BeqaKs) **Created:** 10/13/2026 **Status:** ❌ Closed **Base:** `main` ← **Head:** `fix/pwntools-cleanup-resources` --- ### 📝 Commits (1) - [`d5ef136`](https://github.com/morluto/rea/commit/d5ef13645c545b600d311fce101965f9bc1c4371) fix(pwntools): include retained process group in cleanup resources ### 📊 Changes **5 files changed** (+82 additions, -17 deletions) <details> <summary>View changed files</summary> 📝 `src/native/pwntools/PwntoolsDecoder.ts` (+13 -6) ➕ `src/process/OwnedCommand.resources.test.ts` (+35 -0) 📝 `src/process/OwnedCommand.ts` (+13 -6) 📝 `tests/boundary/process/ownedCommand.test.ts` (+5 -3) 📝 `tests/process-global/pwntoolsStageRetirement.test.ts` (+16 -2) </details> ### 📄 Description ## Summary - Add `ownedCommandResources()` so owned-command and pwntools decoder cleanup errors list `runId`, optional runtime directory, `pid:<leader>`, and `process-group:<id>` consistently. - Use it in `PwntoolsDecoder.#retireProcess` when process stop is incomplete (fixes #2274). - Regression: `pwntoolsStageRetirement` asserts full `details.resources`; unit test covers the helper. ## Test plan - [x] `npm run test:local -- src/process/OwnedCommand.resources.test.ts` - [x] `npm run check:fast` - [ ] CI: `tests/process-global/pwntoolsStageRetirement.test.ts`, `tests/boundary/process/ownedCommand.test.ts` (require Darwin ownership inspector compile locally) --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:04:58 +00:00