morluto/rea
1
0
Fork 0
mirror of https://github.com/morluto/rea.git synced 2026-11-05 06:45:22 +00:00
Code Issues 1.3k Projects Packages Wiki Activity

[PR #2439] [MERGED] feat(android): expose exact DEX descriptors and direct invoke sites #5232

New issue
Closed
opened 2026-10-31 01:05:00 +00:00 by bsakaguchi · 0 comments
bsakaguchi commented 2026-10-31 01:05:00 +00:00
Owner
Copy link

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2439
Author: @LcokHcak
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: codex/rea-android-invokes

📝 Commits (3)

  • b6220ed feat(android): expose precise method references and DEX invoke sites
  • d17dee5 fix(android): bound invoke evidence without losing reference inventory
  • a4a9e5d perf(android): skip invoke admission for class references

📊 Changes

17 files changed (+870 additions, -38 deletions)

View changed files

📝 bridge/android/ReaJadxBridge.java (+107 -9)
📝 docs/android-analysis.md (+29 -7)
📝 scripts/verify/android/analysis.mjs (+45 -1)
➕ scripts/verify/android/direct-invokes.mjs (+112 -0)
📝 scripts/verify/android/metadata.mjs (+25 -0)
📝 src/android/JadxAnalysis.ts (+32 -7)
📝 src/android/JadxProtocol.ts (+16 -0)
📝 src/android/JadxRelease.ts (+2 -1)
📝 src/cli/androidCommands.ts (+12 -2)
📝 src/contracts/android/androidToolContracts.ts (+3 -3)
📝 src/domain/android/androidAnalysis.ts (+35 -2)
➕ tests/boundary/android/JadxAnalysis.test.ts (+304 -0)
📝 tests/boundary/process/jadxIntegration.test.ts (+16 -3)
📝 tests/conformance/android/ReaJadxMetadataRegression.java (+104 -2)
➕ tests/fixtures/android/direct-invokes/Caller.smali (+9 -0)
➕ tests/fixtures/android/direct-invokes/Target.smali (+7 -0)
📝 tests/fixtures/android/jadx-mcp.mjs (+12 -1)

📄 Description

Summary

Expose exact DEX method descriptors and individual direct invoke-* sites in Android reference results. This lets an analyst distinguish a method that uses a target from each call instruction inside that method.

Problem and expected behavior

In the included two-invoke fixture, fixture.Caller.twice() calls fixture.Target.mark() twice. JADX getUseIn() reports one using method, so REA previously returned total: 1 with no instruction location. The result looked complete at method granularity but could not answer how many direct calls existed or where they occurred.

Change and scope

The JADX bridge now provides the DEX descriptor and direct invoke instruction data when the producer can match them. The Android adapter validates and carries the source method identity, DEX entry, code-unit offset, method index and opcode through the domain result and both CLI/MCP paths. total and reference_unit: "using_node" keep their existing meaning; direct_invokes is separate instruction evidence. No APK is executed and no new provider is introduced. No issue is linked because this was reproduced with a controlled repository fixture.

Contract and boundary impact

  • Semantic owner and earliest changed stage: JADX bridge producer, followed by Android protocol validation and result mapping.
  • Contribution scope fit and linked maintainer decision: ordinary static cross-reference improvement within the existing JADX provider; a separate scope decision is not applicable.
  • CLI and MCP/tool-catalog contract: additive dex_descriptor and direct_invokes fields, with the same result through both adapters; no new tool.
  • Provider, bridge, target-format, or platform compatibility: fixed JADX 0.7.1 bridge; DEX offsets are code units and may be unavailable when producer evidence is absent.
  • Evidence and provenance: retain method-level usage counts and exact instruction facts without presenting them as runtime calls.
  • Authority and cleanup: existing local APK/JAR reads, Java bridge process and private workspace; no added target execution or mutation.
  • Generated metadata and package impact: Android documentation and contracts updated; no additional packaged binary.

Known workflow effects: reads the selected APK and supplied JADX JAR, runs the existing local Java bridge, and uses its private temporary workspace. It does not run APK code or contact a target service.

Evidence and regression coverage

The controlled fixture now returns one using method with two direct invoke offsets, 0 and 3, for fixture.Caller.twice()V. Tests cover overload identity, malformed producer values, single/multi-DEX source identity, CLI/MCP parity, and unchanged APK bytes. These are static observations; runtime call counts remain unknown. The regression would fail on the base revision because direct_invokes and the exact descriptor were absent.

  • Observed, derived, and inferred claims remain distinguishable.
  • Artifact identity and source provenance remain preserved.
  • Unsupported or incomplete instruction evidence remains visible.

Validation performed

  • On the standalone Android branch at 37b7550: npm run build:cached and the full real Android/JADX lane passed with JDK 21, fixed JADX 0.7.1 JAR and public ApiDemos APK. Single/multi-DEX offsets, overload identity, CLI/MCP parity and APK hash checks passed.
  • On the combined branch at 37b7550: npm run check, npm run docs:check, npm run verify:test-discovery, 16 relevant Vitest tests and the full real Android and Chrome lanes passed.
  • The branch was rebased without conflict onto 4773c15; npm run check passed on the combined branch at that base. The four intervening upstream commits did not change the Android invoke files.

Compatibility, safety, and release

  • Breaking changes or migration steps: none intended; new fields are additive.
  • Real-provider coverage: Windows/JDK 21/JADX 0.7.1/public APK. Linux, macOS and other JADX versions were not run here.
  • Security/privacy: no vulnerability claim or target execution; retain artifact provenance and private-workspace cleanup behavior.

Before merge

  • Concrete reproduced analyst problem and one focused outcome.
  • Scope and authority reviewed against CONTRIBUTING.md.
  • No issue linked; controlled fixture and expected behavior are described above.
  • Tests cover observable behavior and malformed/partial evidence.
  • Owning documentation and contracts updated.
  • CLI/MCP output represented by the fixture example above.
  • Diff checked for secrets, unrelated cleanup and unsupported claims.

🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2439 **Author:** [@LcokHcak](https://github.com/LcokHcak) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `codex/rea-android-invokes` --- ### 📝 Commits (3) - [`b6220ed`](https://github.com/morluto/rea/commit/b6220ede304527a7b40fbb3702799ebcd94c1dbd) feat(android): expose precise method references and DEX invoke sites - [`d17dee5`](https://github.com/morluto/rea/commit/d17dee591db6e3687c9833b3fc477a98f900a33d) fix(android): bound invoke evidence without losing reference inventory - [`a4a9e5d`](https://github.com/morluto/rea/commit/a4a9e5db1a2f6c3eede5cd51840808dc02c5f8c2) perf(android): skip invoke admission for class references ### 📊 Changes **17 files changed** (+870 additions, -38 deletions) <details> <summary>View changed files</summary> 📝 `bridge/android/ReaJadxBridge.java` (+107 -9) 📝 `docs/android-analysis.md` (+29 -7) 📝 `scripts/verify/android/analysis.mjs` (+45 -1) ➕ `scripts/verify/android/direct-invokes.mjs` (+112 -0) 📝 `scripts/verify/android/metadata.mjs` (+25 -0) 📝 `src/android/JadxAnalysis.ts` (+32 -7) 📝 `src/android/JadxProtocol.ts` (+16 -0) 📝 `src/android/JadxRelease.ts` (+2 -1) 📝 `src/cli/androidCommands.ts` (+12 -2) 📝 `src/contracts/android/androidToolContracts.ts` (+3 -3) 📝 `src/domain/android/androidAnalysis.ts` (+35 -2) ➕ `tests/boundary/android/JadxAnalysis.test.ts` (+304 -0) 📝 `tests/boundary/process/jadxIntegration.test.ts` (+16 -3) 📝 `tests/conformance/android/ReaJadxMetadataRegression.java` (+104 -2) ➕ `tests/fixtures/android/direct-invokes/Caller.smali` (+9 -0) ➕ `tests/fixtures/android/direct-invokes/Target.smali` (+7 -0) 📝 `tests/fixtures/android/jadx-mcp.mjs` (+12 -1) </details> ### 📄 Description ## Summary Expose exact DEX method descriptors and individual direct `invoke-*` sites in Android reference results. This lets an analyst distinguish a method that uses a target from each call instruction inside that method. ## Problem and expected behavior In the included two-invoke fixture, `fixture.Caller.twice()` calls `fixture.Target.mark()` twice. JADX `getUseIn()` reports one using method, so REA previously returned `total: 1` with no instruction location. The result looked complete at method granularity but could not answer how many direct calls existed or where they occurred. ## Change and scope The JADX bridge now provides the DEX descriptor and direct invoke instruction data when the producer can match them. The Android adapter validates and carries the source method identity, DEX entry, code-unit offset, method index and opcode through the domain result and both CLI/MCP paths. `total` and `reference_unit: "using_node"` keep their existing meaning; `direct_invokes` is separate instruction evidence. No APK is executed and no new provider is introduced. No issue is linked because this was reproduced with a controlled repository fixture. ## Contract and boundary impact - Semantic owner and earliest changed stage: JADX bridge producer, followed by Android protocol validation and result mapping. - Contribution scope fit and linked maintainer decision: ordinary static cross-reference improvement within the existing JADX provider; a separate scope decision is not applicable. - CLI and MCP/tool-catalog contract: additive `dex_descriptor` and `direct_invokes` fields, with the same result through both adapters; no new tool. - Provider, bridge, target-format, or platform compatibility: fixed JADX 0.7.1 bridge; DEX offsets are code units and may be unavailable when producer evidence is absent. - Evidence and provenance: retain method-level usage counts and exact instruction facts without presenting them as runtime calls. - Authority and cleanup: existing local APK/JAR reads, Java bridge process and private workspace; no added target execution or mutation. - Generated metadata and package impact: Android documentation and contracts updated; no additional packaged binary. Known workflow effects: reads the selected APK and supplied JADX JAR, runs the existing local Java bridge, and uses its private temporary workspace. It does not run APK code or contact a target service. ## Evidence and regression coverage The controlled fixture now returns one using method with two direct invoke offsets, `0` and `3`, for `fixture.Caller.twice()V`. Tests cover overload identity, malformed producer values, single/multi-DEX source identity, CLI/MCP parity, and unchanged APK bytes. These are static observations; runtime call counts remain unknown. The regression would fail on the base revision because `direct_invokes` and the exact descriptor were absent. - [x] Observed, derived, and inferred claims remain distinguishable. - [x] Artifact identity and source provenance remain preserved. - [x] Unsupported or incomplete instruction evidence remains visible. ## Validation performed - On the standalone Android branch at `37b7550`: `npm run build:cached` and the full real Android/JADX lane passed with JDK 21, fixed JADX 0.7.1 JAR and public ApiDemos APK. Single/multi-DEX offsets, overload identity, CLI/MCP parity and APK hash checks passed. - On the combined branch at `37b7550`: `npm run check`, `npm run docs:check`, `npm run verify:test-discovery`, 16 relevant Vitest tests and the full real Android and Chrome lanes passed. - The branch was rebased without conflict onto `4773c15`; `npm run check` passed on the combined branch at that base. The four intervening upstream commits did not change the Android invoke files. ## Compatibility, safety, and release - Breaking changes or migration steps: none intended; new fields are additive. - Real-provider coverage: Windows/JDK 21/JADX 0.7.1/public APK. Linux, macOS and other JADX versions were not run here. - Security/privacy: no vulnerability claim or target execution; retain artifact provenance and private-workspace cleanup behavior. ## Before merge - [x] Concrete reproduced analyst problem and one focused outcome. - [x] Scope and authority reviewed against `CONTRIBUTING.md`. - [x] No issue linked; controlled fixture and expected behavior are described above. - [x] Tests cover observable behavior and malformed/partial evidence. - [x] Owning documentation and contracts updated. - [x] CLI/MCP output represented by the fixture example above. - [x] Diff checked for secrets, unrelated cleanup and unsupported claims. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>
bsakaguchi 2026-10-31 01:05:00 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
codex/procedure-reference-stacked
release-please--branches--main--components--rea-agents
release-please--branches--main--components--rea-agents--release-notes
codex/kuna-independent-retry
codex/byte-search-overlay-coverage
codex/open-failure-target-receipt
codex/kuna-xref-evidence
codex/ghidra-ambiguous-procedure-recovery
codex/function-source-bundle
codex/trace-function-integration-prototype
codex/snapshot-source-closure
codex/recorded-evidence-array-pages
codex/evidence-recovery-redesign
codex/trace-feature-address-scope
codex/call-discovery-scope
codex/ghidra-literal-candidate-evidence
codex/decompile-directory-independent-retry
codex/retry-provenance-base
codex/value-flow-capability-experiment
codex/ghidra-containing-instruction
cursor/readme-discord-button-ef9f
dependabot/github_actions/actions/setup-node-7.1.0
dependabot/github_actions/actions/upload-artifact-7.0.2
dependabot/npm_and_yarn/npm-minor-and-patch-d8d97ce6df
codex/kuna-1989
fix/8559-native-ui-fixture-ownership
fix/8555-go-verifier-mcp-ownership
codex/provider-capability-recovery
fix/8642-rizin-target-stdin
codex/ghidra-memory-effect-scope
codex/ghidra-annotation-entry-selector
codex/ghidra-readonly-recovery
codex/ghidra-regex-verifier-recovery
codex/evidence-discovery-view-guidance
fix/8545-bulk-append-overflow
fix/8428-navigation-refusal-alternatives
codex/address-context-recovery
codex/matching-member-limitations
codex/unknown-scope-contract
codex/evidence-view-guidance
feat/8373-native-trace-views
codex/ghidra-snapshot-verifier-binding
codex/elf-export-visibility
codex/evidence-view-recovery
codex/native-reference-cli-help
codex/provider-candidate-observation-scope
codex/kuna-session-verification
codex/ghidra-switch-lifetime-guidance
codex/pseudocode-paging-discovery
codex/clarify-evidence-view-support
codex/kuna-xrefs-selector-recovery
codex/context-capacity-recovery
codex/evidence-closure-large-links
codex/same-function-evidence-identity
codex/ghidra-verifier-inspected-jdk
codex/audit-guided-workflows
codex/crash-prompt-retained-dossiers
codex/analysis-view-error-recovery
codex/kuna-verifier-target-selection
codex/ghidra-selected-project-call-coverage
codex/docs-native-analysis-scope
codex/ghidra-java-socket-boundary
codex/ghidra-retained-snapshot-verifier
codex/ghidra-search-inventory-facts
fix/8284-zero-argument-parameter-bindings
fix/8198-ui-action-handler-offset
fix/8257-elf-entry-label-identity
fix/8304-deferred-output-schema-projection
fix/8277-call-path-computed-target-uncertainty
fix/pr-8089-conflicts
fix/ci-static-duplicate-export
dependabot/npm_and_yarn/lint-staged-17.6.0
dependabot/github_actions/actions/download-artifact-8.0.2
dependabot/npm_and_yarn/write-file-atomic-8.0.0
dependabot/npm_and_yarn/canonicalize-5.1.0
dependabot/github_actions/actions/cache/restore-6.1.0
dependabot/npm_and_yarn/toon-format/toon-4.4.0
dependabot/github_actions/actions/deploy-pages-5.0.1
codex/review-fixes-pr-2403
codex/review-fixes-pr-2400
codex/process-terminal-width
codex/test-brittleness-cleanup
verify/7167-browser-connect-macos
fix/7167-browser-connect
feat/native-matching-allowance-setting
feat/browser-scenario-dry-run
test/managed-caller-parameters-20261024
codex/parser-fortythird-boundaries
fix/6926-pinvoke-platform-decorations-20261023
fix/6889-har-body-encoding-20261023
fix/6888-sqlite-schema-budget-20261023
fix/dependency-security-gates-6708
cursor/evidence-overwrite-rebase-b4ac
feat/4057-verify-native-exports
fix/windows-acl-observer-overhead-20261022
cursor/erlang-beam-restack-4476
cursor/pe-certificate-review-bf32
fix/6116-javascript-application-fs-errors
fix/6061-unmapped-runtime-script-unknown
feat/browser-scenario-summary
fix/pe-certificates
codex/verify-3407
cursor/rebase-5699
cursor/rebase-5352
cursor/rebase-5600
cursor/fix-cli-schema-omission-10a8
codex/audit-hopper-shutdown-reasons-20261021
fix/demangle-swift-omitted-record
fix/nib-boolean-value-types
cursor/cancellation-partial-observation-a5ac
fix/ib-object-limit-reasons
fix/electron-fuse-limit-advice
fix/kuna-doctor-dangling-cache
fix/fixed-budget-refusal-advice
fix/js-ipc-listener-dedup
fix/js-return-member-provenance
fix/dmg-integrity-retry-advice
fix/ida-doctor-readiness
fix/kuna-version-probe-output-drain
fix/legacy-swift-runtime-name-matching
fix/dylib-lazy-load-commands
fix/browser-scenario-startup-cancel
fix/swift-nested-punycode-classification
fix/compare-unselected-scopes
fix/objc-method-budget-coverage
fix/dmg-mounted-root-observations
audit/ci-tests-20261019-round2
release/6.7.0
fix/wabt-cleanup-retry-resolution
fix/electron-fuse-elf-pe-architecture
fix/native-plist-descriptor-ownership
fix/kuna-caller-cleanup-ownership
experiment/atomic-codemode-20261016
review/first-contributor-3776
fix/call-resolution-full-read-cycles
fix/member-mutation-selection-repeat
experiment/atomic-re-tools-20261015
perf/member-mutation-lazy-origins
perf/static-network-mutation-index
fix/hopper-startup-lifecycle
audit/3050-windows-proof-20261015
feat/windows-window-capture-2183
audit/3049-windows-proof-20261015
audit/3735-macos-fixtures-20261015
fix/batch-decompile-null-pseudocode
fix/kuna-inventory-honors-jobs
experiment/browser-codemode-tool-design-20261015
fix/hopper-clean-runtime-argv
codex/review-2049-27f1b367
review-fixes/pr-2787-routing
fix/3360-scoped-this-emitters
fix/3367-replaced-global-effects
fix/3838-compact-any-value-items
test/hopper-download-probe-20261015
codex/windows-runtime-creation-red-green-20261015
codex/windows-readonly-root-red-green-20261015
codex/windows-root-share-red-green-20261015
codex/exp-1685-win-mcp-startup
codex/bug-sweep-20261015
investigate/2190-windows-package-phases
investigate/3543-macos-cli-deadline
perf/3281-reverse-tools-feedback-quality
fix/3406-hopper-doctor-fixture
fix/3341-wrapper-require-test-context
fix/3301-owned-uninstall-fixtures
fix/3164-compiler-input-ownership
fix/pcap-cleanup-stdout-newline-20261014
perf/interface-builder-summary
codex/review-fixes-pr-1977
fix/ghidra-effective-jvm-platform
fix/docs-turkish-rust-link-20261013
fix/main-maintenance-ci-20261010
fix/recover-binary-session-process-effects
codex/review-fixes-pr-2457
codex/ci-required-cancellation-gate
fix/main-format-baseline-20261013
fix/setup-preserve-entry-fields
cursor/restore-main-checks-1ffc
fix/ghidra-bridge-hashmap-import
codex/shared-ci-jadx-json-default-20261013
codex/shared-ci-ghidra-test-groups-20261013
codex/shared-ci-java-fixture-format-20261013
codex/fix-intrinsic-invocation-boundaries
test/release-preflight-reusable-jobs
test/js-parameter-provenance-expectation
fix/linux-hopper-verification-current
test/2419-ghidra-elf-probe-size
followup/pr-1544-native-ida
codex/fold-pr-2230-contribution
docs/readme-responsible-use
fix/issue-2064
fix/issue-2050
fix/issue-2053
fix/issue-1968
fix/issue-1945
experiment/codemode-bridge-20261011
fix/tool-effects-negative-wording-1904-20261012
fix/1842-electron-interop-provenance
feat/recover-javascript-multi-input
refactor/website-i18n-prep
fix/nativeaot-pe-virtual-extent
fix/browser-verifier-ci-hang
fix/pe-resources-input-selection
docs/beginner-friendly-guides
docs/beginner-setup-guide
fix/javascript-analysis-worker-1563
fix/1649-ghidra-duplicate-names
fix/javascript-export-keys-integration-1369
test/maintenance-boundary-contracts-20261011
review/javascript-export-keys-1369
review/process-live-progress-1483
test/javascript-1495-growth-ratio
fix/ci-escape-timing
docs/normalized-terminal-geometry-1450
release/6.3.0
archive/release-6.3.0-pr1381
release/6.2.0
fix/electron-preload-dynamic-override
fix/javascript-self-referential-bundler-edges
release/6.1.0
cursor/grok-client-cherry-pick-0b56
feat/signature-posture
feat/dyld-shared-cache
feat/artifact-integrity-policy
feat/pkg-inventory
release/6.0.0
chore/sync-release-5.0.0
release/5.0.0
cursor/cloud-agent-node-787e
fix/javascript-xhr-open-endpoints
review/pr-711-realpath-fallback-wording
cleanup/replay-confinement
codex/test-suite-performance
codex/issue-foundations
codex/address-open-issues-2026-07-20
agent/javascript-vite-rollup-esbuild-adapters
agent/process-cleanup
agent/triage-integration
agent/unknown-commands-registry
feat/mcp-identity-metadata
morlvps/issue_cleanup
codex/installer-redesign
morl/roadmap-investigation-core
morl/roadmap-investigation-docs
release-please--branches--main--components--rea
rea-agents-6.8.0
rea-agents-6.7.0
rea-agents-6.6.0
experiment/atomic-codemode-wait-runtime-20261016
rea-agents-6.5.0
rea-agents-6.4.0
rea-agents-6.3.0
rea-agents-6.2.0
rea-agents-6.1.0
rea-agents-6.0.0
rea-agents-5.0.0
rea-agents-4.1.0
rea-agents-4.0.1
rea-agents-4.0.0
rea-agents-3.2.1
rea-agents-3.2.0
rea-agents-3.1.0
rea-agents-3.0.0
rea-agents-2.7.0
rea-agents-2.6.0
rea-agents-2.5.1
rea-agents-2.5.0
rea-agents-2.4.0
rea-agents-2.3.0
rea-agents-2.2.0
rea-agents-2.1.0
rea-agents-2.0.0
rea-agents-1.7.0
rea-agents-1.6.0
rea-agents-1.5.0
rea-agents-1.4.0
rea-agents-1.3.0
rea-agents-1.2.0
rea-agents-1.1.0
rea-agents-1.0.0
rea-agents-0.5.0
rea-agents-0.4.0
rea-agents-0.3.0
rea-0.2.1
rea-0.2.0
Labels
Clear labels   
area: bridge

   
area: bridge

   
area: build

   
area: build

   
area: build

   
area: cli

   
area: domain

   
area: evidence

   
area: mcp

   
area: native

   
area: providers

   
area: runtime

   
area: server

   
area: setup

   
area: tests

   
bug

   
design

   
documentation

   
enhancement

   
enhancement

   
enhancement

   
experiment

   
help wanted

   
i18n

   
invalid

   
P0: critical

   
P1: high

   
P2: medium

   
P2: medium

   
P2: medium

   
P3: low

   
performance

   
provider-request

   
pull-request
Mirrored from GitHub Pull Request

  
question

   
roadmap

   
triage
No labels
area: bridge
area: bridge
area: build
area: build
area: build
area: cli
area: domain
area: evidence
area: mcp
area: native
area: providers
area: runtime
area: server
area: setup
area: tests
bug
design
documentation
enhancement
enhancement
enhancement
experiment
help wanted
i18n
invalid
P0: critical
P1: high
P2: medium
P2: medium
P2: medium
P3: low
performance
provider-request
pull-request
question
roadmap
triage
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
morluto/rea#5232
No description provided.