[PR #2469] [MERGED] test(mcp): reuse advertised schema in inventory check #5251

New issue

Closed

opened 2026-10-31 01:05:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2469
Author: @N0zoM1z0
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @N0zoM1z0

Base: main ← Head: test/mcp-inventory-schema-reuse-20261013

📝 Commits (3)

2db5ee5 test(mcp): reuse advertised schema for inventory status
41139dd Merge commit 'bb154d1067' into test/mcp-inventory-schema-reuse-20261013
fd54f00 Merge commit '172407787f' into test/mcp-inventory-schema-reuse-20261013

📊 Changes

1 file changed (+11 additions, -4 deletions)

View changed files

📝 tests/boundary/mcp/serverWorkflowMcp.test.ts (+11 -4)

📄 Description

The session inventory check lists the entire catalog and then calls binary_session. The first cached SDK call constructs output validators for all 187 tools, making this functional check repeatedly exceed its 10-second deadline in complete local coverage runs.

Pass the exact binary_session definition from the current listing to the SDK's supported toolDefinition option. The SDK still validates the actual reply; all existing inventory, availability, remediation, metadata and schema assertions, cleanup and the original 10-second deadline remain. Only this test file changes.

Validation:

Complete local coverage on f254f5ac2 + 2db5ee5d6: 1,005 files, 10,230 passed / 92 skipped / zero failures; all coverage thresholds pass. The inventory case completes in 1.32 seconds in that full run. No observed surviving process generation remains.
Latest bb154d1067 and 172407787 merged into the branch: static/type/architecture checks and website maintenance checks pass; discovery finds 1,013 files exactly once. All 16 changed/related capture, analysis-view, schema and inventory test files pass (210 cases, two expected capability skips); inventory completes in 1.04 seconds. An additional ten Flutter/runtime/shared-schema files pass all 123 cases on 172407787, including inventory in 0.87 seconds. The original complete local result is not attributed to these newer files. Initial combined-source PR CI passed all 1,010 files (10,272 passed / 94 skipped); the updated 1,013-file head must pass full CI before merge.
Three drift/fault mutants fail on catalog equality, exact metadata equality and genuine SDK output-schema rejection. Temporary fault/timing code was removed.
Six alternating covered measurements complete the same assertions: inventory 8.06–9.35 s before, 1.30–1.38 s after; focused-runner CPU 28.35–30.44 s before, 19.61–20.81 s after. Detailed memory/cold-warm/host limitations are in the issue. Focused coverage diagnostics retain the whole-repository thresholds and exit nonzero for incomplete overall coverage. This is a local case/file improvement; the full suite still takes approximately 36 minutes and no large whole-CI acceleration is claimed.

Updated Python gate: 20 cases passed. Real Chrome SVG/XHTML cases pass in both focused and complete covered runs. Website behavior was independently verified in an actual browser, including persisted theme, cross-tab updates and mobile RTL.

Closes #2453.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2469 **Author:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@N0zoM1z0](https://github.com/N0zoM1z0) **Base:** `main` ← **Head:** `test/mcp-inventory-schema-reuse-20261013` --- ### 📝 Commits (3) - [`2db5ee5`](https://github.com/morluto/rea/commit/2db5ee5d66cf5c402c3675385e4ef9ea91e7ce70) test(mcp): reuse advertised schema for inventory status - [`41139dd`](https://github.com/morluto/rea/commit/41139ddc9382d7d0e60ade1dffd4990e8ab1b9f0) Merge commit 'bb154d1067b0fc250452b7d468d0b0523031a16f' into test/mcp-inventory-schema-reuse-20261013 - [`fd54f00`](https://github.com/morluto/rea/commit/fd54f00395315a05cdeaa0e01365c7018aabd610) Merge commit '172407787f1842dedbcd27b5385177595f786ce4' into test/mcp-inventory-schema-reuse-20261013 ### 📊 Changes **1 file changed** (+11 additions, -4 deletions) <details> <summary>View changed files</summary> 📝 `tests/boundary/mcp/serverWorkflowMcp.test.ts` (+11 -4) </details> ### 📄 Description The session inventory check lists the entire catalog and then calls `binary_session`. The first cached SDK call constructs output validators for all 187 tools, making this functional check repeatedly exceed its 10-second deadline in complete local coverage runs. Pass the exact `binary_session` definition from the current listing to the SDK's supported `toolDefinition` option. The SDK still validates the actual reply; all existing inventory, availability, remediation, metadata and schema assertions, cleanup and the original 10-second deadline remain. Only this test file changes. Validation: - Complete local coverage on `f254f5ac2 + 2db5ee5d6`: 1,005 files, 10,230 passed / 92 skipped / zero failures; all coverage thresholds pass. The inventory case completes in 1.32 seconds in that full run. No observed surviving process generation remains. - Latest `bb154d1067` and `172407787` merged into the branch: static/type/architecture checks and website maintenance checks pass; discovery finds 1,013 files exactly once. All 16 changed/related capture, analysis-view, schema and inventory test files pass (210 cases, two expected capability skips); inventory completes in 1.04 seconds. An additional ten Flutter/runtime/shared-schema files pass all 123 cases on `172407787`, including inventory in 0.87 seconds. The original complete local result is not attributed to these newer files. Initial combined-source PR CI passed all 1,010 files (10,272 passed / 94 skipped); the updated 1,013-file head must pass full CI before merge. - Three drift/fault mutants fail on catalog equality, exact metadata equality and genuine SDK output-schema rejection. Temporary fault/timing code was removed. - Six alternating covered measurements complete the same assertions: inventory 8.06–9.35 s before, 1.30–1.38 s after; focused-runner CPU 28.35–30.44 s before, 19.61–20.81 s after. Detailed memory/cold-warm/host limitations are in the issue. Focused coverage diagnostics retain the whole-repository thresholds and exit nonzero for incomplete overall coverage. This is a local case/file improvement; the full suite still takes approximately 36 minutes and no large whole-CI acceleration is claimed. Updated Python gate: 20 cases passed. Real Chrome SVG/XHTML cases pass in both focused and complete covered runs. Website behavior was independently verified in an actual browser, including persisted theme, cross-tab updates and mobile RTL. Closes #2453. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:10 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:25 +00:00

[PR #5251] [MERGED] fix(mcp): describe function comparisons in behavior tool #6839

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5251

No description provided.

Rows
Columns