[PR #2468] [MERGED] fix(process): preserve nested path identities during normalization #5252

New issue

Closed

opened 2026-10-31 01:05:10 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:10 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2468
Author: @rudycelekli
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @baron

Base: main ← Head: fix/process-path-normalization

📝 Commits (1)

807f4cc fix(process): preserve nested path identities during normalization

📊 Changes

4 files changed (+141 additions, -14 deletions)

View changed files

📝 src/domain/process/processScenario.ts (+3 -0)
📝 src/process/capture/ProcessNormalization.test.ts (+44 -0)
📝 src/process/capture/ProcessNormalization.ts (+35 -13)
📝 tests/boundary/process/processCaptureNormalization.test.ts (+59 -1)

📄 Description

When a selected executable or filesystem root is inside the working directory, path normalization replaces the parent first. Captures then lose the more specific identities: selected-node becomes <working-directory>/selected-node instead of <executable>, and an observed data root loses its own alias. Match original literal paths once, longest first, while retaining the existing tie priority. Version path-normalized comparison contracts so older semantics are rejected rather than compared silently.

Validation: two module regressions and one real local PTY capture fail on the original implementation. The fix passes 25 module/scenario tests, five native PTY tests (two Linux-only cases skipped on macOS), and npm run check with Node 24.18.0/npm 11.16.0. The capture checks original bytes, normalized identities, legacy-contract rejection and verified owned-process cleanup. An independent Codex review checked alias ties, regexp punctuation and replacement non-cascading on commit 807f4ccbb.

AI assistance: OpenAI Codex authored the analysis, code, tests and this description, with independent automated review. No human maintainer review is claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2468 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@baron](https://github.com/baron) **Base:** `main` ← **Head:** `fix/process-path-normalization` --- ### 📝 Commits (1) - [`807f4cc`](https://github.com/morluto/rea/commit/807f4ccbbf0b40f4f0c4c639882f236442cdc6ca) fix(process): preserve nested path identities during normalization ### 📊 Changes **4 files changed** (+141 additions, -14 deletions) <details> <summary>View changed files</summary> 📝 `src/domain/process/processScenario.ts` (+3 -0) 📝 `src/process/capture/ProcessNormalization.test.ts` (+44 -0) 📝 `src/process/capture/ProcessNormalization.ts` (+35 -13) 📝 `tests/boundary/process/processCaptureNormalization.test.ts` (+59 -1) </details> ### 📄 Description When a selected executable or filesystem root is inside the working directory, path normalization replaces the parent first. Captures then lose the more specific identities: `selected-node` becomes `<working-directory>/selected-node` instead of `<executable>`, and an observed data root loses its own alias. Match original literal paths once, longest first, while retaining the existing tie priority. Version path-normalized comparison contracts so older semantics are rejected rather than compared silently. Validation: two module regressions and one real local PTY capture fail on the original implementation. The fix passes 25 module/scenario tests, five native PTY tests (two Linux-only cases skipped on macOS), and `npm run check` with Node 24.18.0/npm 11.16.0. The capture checks original bytes, normalized identities, legacy-contract rejection and verified owned-process cleanup. An independent Codex review checked alias ties, regexp punctuation and replacement non-cascading on commit 807f4ccbb. AI assistance: OpenAI Codex authored the analysis, code, tests and this description, with independent automated review. No human maintainer review is claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:10 +00:00

closed this issue
added the
pull-request
label

bsakaguchi referenced this issue

2026-11-01 21:43:27 +00:00

[PR #5252] [CLOSED] fix(process): settle native zombies during ownership sweeps #6841

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5252

No description provided.

Rows
Columns