[PR #2474] [MERGED] fix(config): reject NUL bytes in Hopper loader arguments #5257

New issue

Closed

opened 2026-10-31 01:05:13 +00:00 by bsakaguchi · 0 comments

bsakaguchi commented

2026-10-31 01:05:13 +00:00

Owner

📋 Pull Request Information

Original PR: https://github.com/morluto/rea/pull/2474
Author: @rudycelekli
Created: 10/13/2026
Status: ✅ Merged
Merged: 10/13/2026
Merged by: @morluto

Base: main ← Head: fix/hopper-loader-argv-nul

📝 Commits (1)

310108b fix(config): reject NUL bytes in Hopper loader arguments

📊 Changes

2 files changed (+17 additions, -8 deletions)

View changed files

📝 src/config.test.ts (+12 -0)
📝 src/config/parsers.ts (+5 -8)

📄 Description

HOPPER_LOADER_ARGS_JSON currently accepts a string containing a NUL byte even though Node rejects that argument before launching a child process. Validate this restriction at the configuration producer and return the existing typed configuration error with the setting name and a useful NUL explanation. Empty and whitespace arguments retain their existing behavior.

Validation: the new configuration regression fails on f254f5ac2b. All 41 configuration tests and npm run check pass with Node 24.18.0/npm 11.16.0. An independent Node argv-validation oracle returns ERR_INVALID_ARG_VALUE before process launch. This configuration-only change was not tested against a real Hopper installation.

AI assistance: OpenAI Codex authored and reviewed the implementation, tests, analysis and description. Verification and review were automated; no human review is claimed.

_{🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.}

## 📋 Pull Request Information **Original PR:** https://github.com/morluto/rea/pull/2474 **Author:** [@rudycelekli](https://github.com/rudycelekli) **Created:** 10/13/2026 **Status:** ✅ Merged **Merged:** 10/13/2026 **Merged by:** [@morluto](https://github.com/morluto) **Base:** `main` ← **Head:** `fix/hopper-loader-argv-nul` --- ### 📝 Commits (1) - [`310108b`](https://github.com/morluto/rea/commit/310108b635a6b8ab9b1f5132f96d0ed67465c8b1) fix(config): reject NUL bytes in Hopper loader arguments ### 📊 Changes **2 files changed** (+17 additions, -8 deletions) <details> <summary>View changed files</summary> 📝 `src/config.test.ts` (+12 -0) 📝 `src/config/parsers.ts` (+5 -8) </details> ### 📄 Description `HOPPER_LOADER_ARGS_JSON` currently accepts a string containing a NUL byte even though Node rejects that argument before launching a child process. Validate this restriction at the configuration producer and return the existing typed configuration error with the setting name and a useful NUL explanation. Empty and whitespace arguments retain their existing behavior. Validation: the new configuration regression fails on f254f5ac2b804b353a711264bb178f43fdf07867. All 41 configuration tests and `npm run check` pass with Node 24.18.0/npm 11.16.0. An independent Node argv-validation oracle returns `ERR_INVALID_ARG_VALUE` before process launch. This configuration-only change was not tested against a real Hopper installation. AI assistance: OpenAI Codex authored and reviewed the implementation, tests, analysis and description. Verification and review were automated; no human review is claimed. --- <sub>🔄 This issue represents a GitHub Pull Request. It cannot be merged through Gitea due to API limitations.</sub>

bsakaguchi

2026-10-31 01:05:13 +00:00

closed this issue
added the
pull-request
label

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

morluto/rea#5257

No description provided.

Rows
Columns